340131 - Takes two clicks to go to pasted URL

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[Ria Klaassen (not reading all bugmail)]

- Copy an URL
- Right-click and paste it in the location bar
- Click Go
- The dropdown closes
- Click Go

Expected behaviour: the last step should not be necessary.

I'll try to find the regression range. Around 31 May.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Between 1.9a1_2006053108 and 1.9a1_2006053111.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-05-31+07%3A00&maxdate=2006-05-31+12%3A00

Seems to be 339661. 

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

right. It's my regression.
But I don't have an idea for this.
If I cannot find the way, I'll back-out the patch.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

This fixes this bug. But this has a regression that is like bug 339661.
1. Open the history dropdown by inputting the URL(including paste).
2. click dropdown button.

-> the dropdown is reopened.

But this is trivial. I think that it's enough for daily use.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 224232 [details] [diff] [review]
Patch rv1.0

Ok, so we still need/want to fix the other issue, but this matters more for now.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0 for 1.8 branch

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk and 1.8 branch.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I filed new bug for remain issue. That is bug 340839.

Comment 8

[(not reading, please use [e-mail] instead)]

I don't think this bug is really fixed on the trunk.

It appears to be fixed the first time I try to reproduce it for a given window, because of the order of the following calls:

this.openPopup(aElement, "after_start", 0, 0, false, false);
this.popupBoxObject.setConsumeRollupEvent(this.mInput.consumeRollupEvent);

setConsumeRollupEvent() should be called before openPopup()

the second time I try to reproduce this bug in a given window, it still takes me two clicks.

note, my fix for bug #404438 and bug #401712 will address this issue for the trunk.

until then, reopening so that it can be re-verified on the trunk.

Comment 9

[(not reading, please use [e-mail] instead)]

mac has this bug as well.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=5049

in-litmus+

Comment 11

[(not reading, please use [e-mail] instead)]

> mac has this bug as well.

with or without my fix, mac seems to have this problem.

the original bug was windows xp.

is it unexpected for the mac to behave the same way as windows here?

we might need a separate issue on mac.

Comment 12

[Neil Deakin]

Why is the autocomplete dropdown opening on paste? Note that Mac doesn't currently implement the consume rollup flag (It is always handled as true).

Comment 13

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

This was fixed for Windows by bug 404438. It still exists on Mac because Mac always consumes rollup events (bug 415440), I filed bug 425815 for that.