340811 - MailNews does not expand accounts anymore when double-clicking in the white space right of the account name

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Fetch a trunk build of SeaMonkey (possibly Thunderbird works, too)
2. Open MailNews
3. Try expanding a account by double-clicking in the white space right of the account name in the left pane. If you don't have any closed tree/account, then click on the - to get a closed one to test.

Actual results:
MailNews seems to get a signal that the account expanded (for NNTP accounts you see "Checking newsgroup x of y on news.example.com" in the statusbar), but the tree (account with the folders/newsgroups) itself remains closed.

Expected results:
Expand the tree (account).

This worked fine with a build from 2006-06-06-10, but is broken with a build from 2006-06-07-09. This could be a fall-out from Bug 296040.

Comment 1

[Frank Wein [:mcsmurf]]

Something else i also noticed: When clicking on a folder in MailNews, the whole row is now marked as selected (so the blue background expands over the white space up to where the pane ends on the right). With a build from the 6th only the background directly behind the name of the folder was marked with a blue background color when the folder was selected. I can file a new bug for this if you want to.

Comment 2

[Jan Varga [:janv]]

The problem is that the row doesn't get selected in "text" selection mode.
I think the double click handler in tree.xml should be reworked to count with it.

Comment 3

[Jan Varga [:janv]]

Attachment: patch

Comment 4

[[e-mail]]

Comment on attachment 224858 [details] [diff] [review]
patch

You realise this regresses bug 130477, right?

Comment 5

[Jan Varga [:janv]]

thanks Neil, I'll try to solve it w/o regressing that bug

Comment 6

[K Chayka]

Is there any progress being made on this? It's been suggested that this bug is the preventing all keyboard access to the folderpane, until after a mouse click is done. See bug 343636, which still exists as of the Aug 9 nightly SeaMonkey build. :-(

Comment 7

[Wayne Mery (:wsmwk)]

Jan, are you able to give any attention to this major usability issue? It affects several other bugs.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

4 months with this regression; it really sucks that we don't chase these things down like we used to.

Comment 9

[Wayne Mery (:wsmwk)]

Neil in comment #4)
> (From update of attachment 224858 [details] [diff] [review] [edit])
> You realise this regresses bug 130477, right?

is it possible to land this and deal with regression of 130477 (which is the lesser of two evils) as a separate patch in due course?

Comment 10

[[e-mail]]

Attachment: Proposed patch

This patch is in two parts.
The first part is mailnews-specific and makes clicking in the folder pane select the row. This fixes the bug except when clicking under the columnpicker.
The second part makes it so that double-clicking in the space under the columnpicker toggles the open state as if it was on a non-cycler column.

Comment 11

[Nelson Bolyard (seldom reads bugmail)]

Neil, that patch surely works for me!  Thanks!

Comment 12

[Karsten Düsterloh]

Comment on attachment 275265 [details] [diff] [review]
Proposed patch

But what about the visual *row* selection? I still think that just marking the text is not sufficient.

Comment 13

[Stefan [:stefanh]]

(In reply to comment #12)
> (From update of attachment 275265 [details] [diff] [review])
> But what about the visual *row* selection? I still think that just marking the
> text is not sufficient. 
> 

That can be fixed in the theme iirc (yay, I thought it was just me with my mac that wanted it).

Comment 14

[[e-mail]]

Attachment: Row selection (checked in)

Comment 15

[Karsten Düsterloh]

Comment on attachment 275335 [details] [diff] [review]
Row selection (checked in)

This fixes the row selection issue - yay!
This leaves us with just bug 343636: the folderpane does not have the focus on MailNews start-up...

Comment 16

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/200708060303 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

(In reply to comment #10)
> Created an attachment (id=275265) [details]
> Proposed patch
> 
> This patch is in two parts.
> The second part makes it so that double-clicking in the space under the
> columnpicker toggles the open state as if it was on a non-cycler column.

The first part was fixed by the "Row Selection" patch.

This second part was not.
In SM v1.0.9/v1.1.4, the space under the columnpicker did nothing on single/double click.
In the (new) current build, single clicking in that space selects the row.
Is the plan to add the double-clicking behaviour too, or let it be as it is now ?

Comment 17

[Karsten Düsterloh]

> In SM v1.0.9/v1.1.4, the space under the columnpicker did nothing on
> single/double click.

That's not quite true: on branch, doubleclicking a folder row under the columnpicker opens a new mailnews main window.

Comment 18

[Serge Gautherie (:sgautherie)]

Right, and it seems this behaviour did not regressed, then is still there.

I should have given more details:
*on a _folder_ line, double-clicking (anywhere) opens a new window, and does not (yet) toggle the open state.
*on an _account_ line, under the columnpicker, double-clicking (now) behaves like a single click.

Comment 19

[[e-mail]]

I've decided to fix the second part in a different way in bug 306990 instead.

Comment 20

[Nelson Bolyard (seldom reads bugmail)]

I'm running the trunk (a few days old) with this bug's patches and LOVING it.
Thanks Neil.

Comment 21

[Wayne Mery (:wsmwk)]

Neil, thanks for taking this on.

Is this bug, and bug 340867, being looked at as strictly about suite?  Is a separate bug needed for Thunderbird?  Because 
- 340867 is definitely not fixed in thunderbird (should it be?), and 
- this patch affects thunderbird, but differently, oddly, compared to suite.

Thunderbird whitespace behavior
- account whitespace, click or double click - broken, only works if account is already selected (is this what you're attempting to fix in bug 306990?)
- folder whitespace 
  - single click - broken, does not select folder (14 months of ouch)
  - double click - collapses account (unexpected but like that behavior, but ...)
    - double click in any whitespace/any account - expands prior account
    - double click in any whitespace/any account - collapses prior account

Comment 22

[[e-mail]]

(In reply to comment #21)
>Is this bug, and bug 340867, being looked at as strictly about suite?
As far as I'm concerned yes, but 306990 will affect both products.

>Is a separate bug needed for Thunderbird?  Because 
>- 340867 is definitely not fixed in thunderbird (should it be?), and 
>- this patch affects thunderbird, but differently, oddly, compared to suite.
Which patch? The one I checked in was attachment 275335 [details] [diff] [review].
Attachment 275265 [details] [diff] would affect Thunderbird, but then so would bug 306990.

Comment 23

[Wayne Mery (:wsmwk)]

(In reply to comment #22)
> (In reply to comment #21)
> >Is this bug, and bug 340867, being looked at as strictly about suite?
> As far as I'm concerned yes, but 306990 will affect both products.
> 
> >Is a separate bug needed for Thunderbird?  Because 
> >- 340867 is definitely not fixed in thunderbird (should it be?), and 
> >- this patch affects thunderbird, but differently, oddly, compared to suite.
> Which patch? The one I checked in was attachment 275335 [details] [diff] [review].
> Attachment 275265 [details] [diff] would affect Thunderbird, but then so would bug 306990.

the broken behavior I see is from attachment 275265 [details] [diff] [review] checkin to folderpane on 08-05 - I see it  in thunderbird starting 08-06 nightly. As it only partly backs out varga's changes (afaict) it leaves thunderbird folder row selection still broken.


> Thunderbird whitespace behavior
> - account whitespace, click or double click - broken, only works if account is
> already selected (is this what you're attempting to fix in bug 306990?)
> - folder whitespace 
>   - single click - broken, does not select folder (14 months of ouch)
>   - double click - collapses account (unexpected but like that behavior, but
> ...)
>     - double click in any whitespace/any account - expands prior account
>     - double click in any whitespace/any account - collapses prior account

note - last two items only happen to the account that is currently selected

Comment 24

[[e-mail]]

(In reply to comment #23)
>the broken behavior I see is from attachment 275265 [details] [diff] [review]
But I didn't check that patch in...

Comment 25

[Wayne Mery (:wsmwk)]

sorry, attachment 275335 [details] [diff] [review]

Comment 26

[[e-mail]]

(In reply to comment #25)
>sorry, attachment 275335 [details] [diff] [review]
That's a SeaMonkey-only patch.

Comment 27

[Wayne Mery (:wsmwk)]

I filed bug 393711 for the thunderbird part.
If it will be fixed here, feel free to dupe it.
If not, let me know and I'll move the block flag to the new bug.

Comment 28

[Karsten Düsterloh]

Comment on attachment 275335 [details] [diff] [review]
Row selection (checked in)

This was checked in on 2007-08-05, so the actual bug here is fixed...

Comment 29

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)
> I've decided to fix the second part in a different way in bug 306990 instead.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007082302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007082402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Confirming that bug 306990 comment 41 checkin fixed what I described here in comment 18.

Comment 30

[Wayne Mery (:wsmwk)]

WFM current trunk TB and SM : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041201 SeaMonkey/2.0a1pre