393711 - have to click on the text of folder name in the folder pane instead of anywhere in the row to select mail folder

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

regression from 2006 bug 296040

ref: seamonkey/toolkit quoting Bug 340867 comment 0
"I have to click on the text in the folder pane to select a folder, rather than just anywhere in the row.?

Comment 1

[Simon Wilkinson]

Attachment: Trivial fix

Trivial patch, based on the similar fix for SeaMonkey.

Could someone advise on approriate reviewers?

Comment 2

[Phil Ringnalda (:philor)]

Sorry for the review delay - this part of that patch is trivial, but the interconnected tangle of SeaMonkey-only and shared patches and bugs and bugs with patches that are also in other bugs around it aren't trivial or comprehensible, so I'm going to need some time to build and compare and try to make sure we aren't missing anything else from them. Luckily, I don't work on Sunday...

Comment 3

[Wayne Mery (:wsmwk)]

SM fix in this general area was more involved because they still allow double click on account to open new main window.  But the SM fix specific to _folders_ (bug 340867) is attachment 275335 [details] [diff] [review], and it matches Simon's patch here afaict.

Comment 4

[Phil Ringnalda (:philor)]

There's no way I'm going to r- this, since it turns the Mac folder pane from hideous (thanks to what must be either a Widget: Cocoa or Toolkit bug, seltype="text" was already painting the whole row, but also putting an ugly border around the text that makes it look sunken and utterly wrong) to lovely, but Qute's folder icons are not at all designed for having a random background color: the Sent icon pretty much disappears into a blue background, like the Windows default or Linux with Clearlooks, while the Junk icon sort of smears and blends with Ubuntu's default Human theme, and the top of the Drafts icon looks wrong with about any color.

So, are we taking this with a blocking-tb3+ bug blocking it, to rework those icons, or are we taking it as a temporary measure, pending a blocking-whatever+ bug to implement 340867 comment 21 to have separate attributes on trees for painting and selection?

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 284327 [details] [diff] [review]
Trivial fix

Some day, I'll learn to stop asking questions in bugs that nobody ever answers, and just do whatever I want instead :)

r=philringnalda, filed bug 400572 for fixing Qute, since Neil says we aren't going to get selection-without-painting.

Comment 6

[Phil Ringnalda (:philor)]

mail/base/content/messenger.xul 1.84

Thanks for the patch, Simon.

Comment 7

[Wayne Mery (:wsmwk)]

verified. thanks.
works like a charm in both whitespace and anywhere in the row, both before and after the text of the folder name
version 3.0a1pre (2007102103)