340825 - New ATK: Implement nsIAccessibleValue on nsAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Any widget can have a value if it has aaa:valuenow/valuemin/valuemax attributes.

Therefore nsIAccessibleValue should be implemented by nsAccessible whenever there is a role which supports value.

if (mRoleMapEntry && mRoleMapEntry->valueRule != eNoValue) {
  // Support nsIAccessibleValue
}

If we put this in nsAccessible::QueryInterface one issue is that progress meters already implement nsIAccessibleValue would now inherit the interface twice. So, we will have to remove it from the deifinition of the nsXULProgresMeterAccessible class, but still implement the interface for that class, and thus make sure QI still works.

Comment 1

[Aaron Leventhal]

Also remove nsXULProgressMeterAccessibleWrap and implement that in nsXULProgressMeterAccessible cross platform class.

Comment 2

[Aaron Leventhal]

Attachment: See bug comment for description of changes

1) Get rid of unnecessary nsAccessible::GetFinalValue(), just use GetValue()
2) Use nsresult return code instead of boolean success parameter for nsIAccessibleValue::setCurrentValue
3) Add support for minimumIncrement
4) Remove nsXULProgressMeterAccessibleWrap and put into cross platform class
5) Support nsIAccessibleValue in nsAccessible when a DHTML role is used that supports values

Comment 3

[Ginn Chen]

Comment on attachment 225006 [details] [diff] [review]
See bug comment for description of changes

Most of the codes look good to me.

+    aIface->set_current_value = getMinimumIncrementCB;
It's a typo.

And we need to clean up accessible/src/atk/nsXULFormControlAccessible.cpp line 47-53.

Comment 4

[Aaron Leventhal]

Attachment: Patch for checkin

Comment 5

[Aaron Leventhal]

Backing out for now. Checkin accidentally removed some files.