Last Comment Bug 340822 - New ATK: Move accessible/public/atk interfaces to accessible/public
: New ATK: Move accessible/public/atk interfaces to accessible/public
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: ---
Assigned To: Aaron Leventhal
:
:
Mentors:
Depends on:
Blocks: newatk 340825 340827 340829 340833
  Show dependency treegraph
 
Reported: 2006-06-08 06:55 PDT by Aaron Leventhal
Modified: 2006-06-12 22:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
These changes, plus move the idl files from accessible/public/atk up 1 directory (14.65 KB, patch)
2006-06-08 07:07 PDT, Aaron Leventhal
ginn.chen: review-
Details | Diff | Splinter Review
Removed nsRootAccessible changes. This patch also requires the moving of the atk idl up one directory (7.34 KB, patch)
2006-06-09 01:49 PDT, Aaron Leventhal
ginn.chen: review+
benjamin: review+
Details | Diff | Splinter Review

Description Aaron Leventhal 2006-06-08 06:55:44 PDT
The following interfaces now need to be build cross-platform, in order for our new-atk code cleanup to move forward. These interfaces will now be available for JavaScript a11y implementations.

nsIAccessibleEditableText.idl
nsIAccessibleHyperLink.idl
nsIAccessibleHyperText.idl
nsIAccessibleTable.idl
nsIAccessibleText.idl
nsIAccessibleValue.idl

Another reason to do this is for the long term goal of bringing accessibility on Windows platforms much closer to what's on Linux.
Comment 1 Aaron Leventhal 2006-06-08 06:58:30 PDT
Question: how do we move the files with CVS without destroying the CVS blame history?
The only actual change which requires a patch is to the makefiles. The rest is just a file move.
Comment 2 Aaron Leventhal 2006-06-08 07:07:47 PDT
Created attachment 224854 [details] [diff] [review]
These changes, plus move the idl files from accessible/public/atk up 1 directory
Comment 3 Ginn Chen 2006-06-08 20:49:16 PDT
Comment on attachment 224854 [details] [diff] [review]
These changes, plus move the idl files from accessible/public/atk up 1 directory

changes of nsRootAccessible.cpp do not belong to this bug.
Comment 4 Aaron Leventhal 2006-06-09 01:49:09 PDT
Created attachment 224982 [details] [diff] [review]
Removed nsRootAccessible changes. This patch also requires the moving of the atk idl up one directory
Comment 5 neil@parkwaycc.co.uk 2006-06-09 03:06:22 PDT
Comment on attachment 224982 [details] [diff] [review]
Removed nsRootAccessible changes. This patch also requires the moving of the atk idl up one directory

My understanding is that build changes don't require superreview but maybe you should run them past bryner or bsmedberg or someone.

Don't forget to file a dependent server operations bug on the CVS copies required.
Comment 6 Aaron Leventhal 2006-06-09 03:18:21 PDT
Actually the CVS history only contains the initial checkin and a license change by gerv, so a cvs copy is not really necessary. We can do it via cvs add and cvs remove. Benjamin, do you agree?
Comment 7 Benjamin Smedberg [:bsmedberg] 2006-06-09 03:35:03 PDT
Comment on attachment 224982 [details] [diff] [review]
Removed nsRootAccessible changes. This patch also requires the moving of the atk idl up one directory

That's fine

Note You need to log in before you can comment on or make changes to this bug.