The default bug view has changed. See this FAQ.

New ATK: Implement nsIAccessibleTable for all nsHTMLTableAccesible

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Aaron Leventhal, Assigned: Mike Gao)

Tracking

({access})

Trunk
x86
All
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
Remove the atk/nsHTMLTableAccessibleWrap code and move it to html/nsHTMLTableAccessible where all platforms can benefit from nsIAccessibleTable.
(Reporter)

Updated

11 years ago
Summary: Implement nsIAccessibleTable for all nsHTMLTableAccesible → New ATK: Implement nsIAccessibleTable for all nsHTMLTableAccesible
(Reporter)

Updated

11 years ago
Assignee: aaronleventhal → ginn.chen
(Reporter)

Updated

11 years ago
Assignee: ginn.chen → gaomingcn
(Assignee)

Comment 1

11 years ago
Will we remove all the codes in atk/nsHTMLTableAccessibleWrap.cpp and .h and remove the files also? 

I did so and is testing the code.
(Reporter)

Comment 2

11 years ago
(In reply to comment #1)
> Will we remove all the codes in atk/nsHTMLTableAccessibleWrap.cpp and .h and
> remove the files also? 
Those files will go away, and the code will move into the html directory as part of the nsHTMLTableAccssible class which already exists. The Wrap class will no longer be necessary.
(Assignee)

Comment 3

11 years ago
I kept the wrap class just now. Will change the code again. 

how about class nsHTMLTableCellAccessibleWrap and nsHTMLTableHeadAccessible? remove nsHTMLTableCellAccessibleWrap and use nsHTMLTableCellAccessible instead when we need it?  nsHTMLTableHeadAccessible has many methods defined, should we keep this class?
(Reporter)

Comment 4

11 years ago
(In reply to comment #3)
> I kept the wrap class just now. Will change the code again. 
> 
> how about class nsHTMLTableCellAccessibleWrap and nsHTMLTableHeadAccessible?
> remove nsHTMLTableCellAccessibleWrap and use nsHTMLTableCellAccessible instead
> when we need it?  nsHTMLTableHeadAccessible has many methods defined, should we
> keep this class?
> 

We don't want any of the table-related Wrap classes anymore. All of the code should move to cross-platform classes. If there is already a cross platform class for that kind of table element, then merge the code. If there isn't a cross platform class then just move the class into the html directory but make sure it doesn't have "Wrap" in the name.

The idea is that we're going to use all of this stuff for all platforms, not just ATK. Originally we had it in Wrap classes in ATK because we only needed it there.
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

11 years ago
Created attachment 227211 [details] [diff] [review]
patch of this bug.
Attachment #227211 - Flags: review?(aaronleventhal)
(Assignee)

Comment 6

11 years ago
Created attachment 227213 [details] [diff] [review]
I think this patch is also necessary
Attachment #227213 - Flags: review?(aaronleventhal)
(Reporter)

Updated

11 years ago
Attachment #227213 - Flags: review?(aaronleventhal) → review+
(Reporter)

Comment 7

11 years ago
Comment on attachment 227211 [details] [diff] [review]
patch of this bug.

I added some tweaks to the patch:
1) Make Table accessible inherit from nsAccessibleWrap (it's not a hyper text, it can't have direct text children)
2) Don't create accessibles for thead/tbody/tfoot in ATK. At some point we'll need to create those for nsIAccessible, but trim them out in the final ATK tree.
Attachment #227211 - Flags: review?(aaronleventhal) → review+
(Reporter)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.