340976 - Firefox should have a larger Icon for Vista

Status: VERIFIED FIXED

(Firefox :: Shell Integration, enhancement, P1)

Description

[u49640]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

when i set my desktop icons in Vista Beta2 to large, the firefox icon looks badly scaled. (but the IE7 Icon isnt that much better)

see screenshot

Reproducible: Always



Expected Results:  
Firefox should have a larger icon included

Comment 1

[u49640]

Attachment: Firefox and IE Icon on Vista Beta2

Comment 2

[u49640]

Attachment: the correct File, sorry

Comment 3

[Serge]

You are on windows vista I dont think so you have the first version of it but its still windows xp pro you are running...
By looking at your logs its running well lol.

Comment 4

[u49640]

(In reply to comment #3)
> You are on windows vista I dont think so you have the first version of it but
> its still windows xp pro you are running...
> By looking at your logs its running well lol.
> 

I'm sorry, but i dont understand this comment.

Comment 5

[Steven Garrity [:sgarrity]]

Attachment: Firefox ICO file with 128px and 256px sizes included

I checked the Microsoft site for guidelines for Vista icons and found that "This content hasn't been written yet. Please check back later for updated guidelines." [1]

In the meantime, I've attached a version of the Firefox ico file that includes 128px and 256px sizes. I don't have Vista, so I can't test.


[1] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/UxGuide/UXGuide/Visuals/Icons/Icons.asp

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227265 [details]
Firefox ICO file with 128px and 256px sizes included

As I understand it, checking this in over our existing .ico file simply makes the larger sizes available should the OS want to use them.

Comment 7

[u49640]

Attachment: the new icon in Vista

looks fine here (left: old one, right: new icon) with Vista Beta2

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/other-licenses/branding/firefox/firefox.ico 	1.2.18.2
mozilla/other-licenses/branding/firefox/firefox.ico 	1.4

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

This new icon breaks builds using VC6 (see bug 346214) so it will need to be backed out of the branch. There is a workaround solution listed at http://www.rw-designer.com/compile-vista-icon in case we want to change our Windows build process to work around it, but I'm thinking that maybe we don't care that much.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I had to back the icon out of the branch to fix bug 346214.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Benjamin, can you please see the workaround referred to in comment 9 and let us know if it's possible to add that as a step in our official build process so we can get this icon shoehorned into Firefox 2 builds?

Resetting the blocking flag to "?" to see if, given this new workaround requirement, we still feel that this is significant enough to fix for release. I can't target it at a 2.0.0.1 release, otherwise I'd be tempted to!

Comment 12

[Benjamin Smedberg]

I worry vaguely about installing/using random tools off the internet. Integrating with the build environment shouldn't be all that hard. Do we want to make everyone who builds with --enable-official-branding have this tool?

Comment 13

[Mike Connor [:mconnor]]

I'm totally fine with requiring anyone building officially-branded builds to have an additional tool.  That said, I would hope we can find a better way of doing this, and we've already pushed out other Vista integration issues until we have time to focus and have a more finished version of the OS.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Would it be as simple as just using the Vista SDK version of rc.exe & rc.dll on the 1.8 tinderboxen? Or has this bug just been shelved for Fx2?

Comment 17

[Mike Connor [:mconnor]]

do those work with VC6?  I didn't think they would...

Comment 18

[Ryan VanderMeulen [:RyanVM]]

I'll try it and let you know.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

I just successfully built Firefox 2.0.0.4 from the tarball source today with VC6 SP5 with rc.exe & rcdll.dll build 6.0.5724.0 and the newer icon attached to this bug. I simply replaced those two original rc files in the Visual Studio install dir with the Vista SDK versions instead. Upon clobbering my tree, the build went without a hitch and I confirmed with Resource Hacker than the new icon was indeed being used.

So I guess that answers that!

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Attachment: RC files used

For posterity's sake, here are the two rc files I used to replace the original VC6SP5 rc files.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Asking for blocking 1.8.1.5. I think this is a simple and rather low-risk fix and I've shown it can be done without resorting to any third party tools. It could easily be turned on early in a release cycle for nightly testing long before it made it into a shipping release to ensure no regressed functionality.

It's very worthwhile given the other efforts that have been made to make Firefox look polished in Vista given that Fx2 is going to be around for quite awhile still.

Comment 22

[Mike Connor [:mconnor]]

http://www.microsoft.com/downloads/details.aspx?familyid=4377f86d-c913-4b5c-b87e-ef72e5b4e065&displaylang=en is the link to the Vista SDK.  What type of risk is revving the SDK (or pulling the rc.exe/dll out of the SDK and spot-replacing) going to be?  This is something that does make a difference on Vista...

Comment 23

[(not currently active) Ted Mielczarek]

FYI, the new Win32 refplatform will be using MozillaBuild, which doesn't currently detect the Vista SDK.  That's filed as bug 374074.

Comment 24

[Daniel Veditz [:dveditz]]

per mconnor build probably won't be able to get to this one for 1.8.1.5, but definitely wanted.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Like I said previously, the only method I've tested for this was directly replacing the resource compiler binaries with the newer versions from the Vista SDK. I haven't tried a total build with VC6 + the Vista SDK.  I'll try that in the future and if it works, I'll post my configuration here for you guys to use (since we're obviously going to want a customized SDK install that doesn't include the C++ compiler for obvious reasons :-)...)

Comment 27

[Daniel Veditz [:dveditz]]

Polish is nice, but this will happen in FF3. The 1.8 branch releases are always so tight there's no room for mucking with build files unless it's a security bug.

Comment 28

[(not currently active) Ted Mielczarek]

I think we should back this icon out on trunk until the Win32 tinderbox has the appropriate prerequisites to support compiling it.  See the discussion in bug 346214.  In addition, once that happens and we can re-land this, we should check in the same kind of icon for the unofficial branding, so that we can ensure everything works right *before* we try to release something with official branding.

Comment 29

[[e-mail] (:bhearsum)]

(In reply to comment #28)
> I think we should back this icon out on trunk until the Win32 tinderbox has the
> appropriate prerequisites to support compiling it.  See the discussion in bug
> 346214.  In addition, once that happens and we can re-land this, we should
> check in the same kind of icon for the unofficial branding, so that we can
> ensure everything works right *before* we try to release something with
> official branding.
> 

I wholeheartedly support this plan.

Comment 30

[Mike Connor [:mconnor]]

Backed out the icon.

Stephen, can you give us a Vista-sized Minefield icon so we never regress this again? :)

Comment 31

[Steven Garrity [:sgarrity]]

Mike, I think I might have mistook your smiley emoticon for an indication of sarcasm. You do need the vista-sized minefield icon, right? Mind if I take some comic liberties in the giant version?

Comment 32

[Reed Loden [:reed]]

(In reply to comment #31)
> Mike, I think I might have mistook your smiley emoticon for an indication of
> sarcasm. You do need the vista-sized minefield icon, right?

Yeah, we need it so that we can actually use a Vista-based icon in the unofficial builds, too, so that we know our build system is working properly with it, rather than only finding out during release build time that our build system doesn't support the icon.

>  Mind if I take some comic liberties in the giant version?

I'm not mconnor, but I wouldn't see why not, as the current bomb-in-world icon for Minefield is already pretty comedic in itself. ;)

Comment 33

[Alex Faaborg [:faaborg] (Firefox UX)]

>  Mind if I take some comic liberties in the giant version?

I'm personally in favor of comic liberties :)  Apple seems to have established a bar that small jokes must be included in high resolution versions of icons.

Our tone for betas seems to be in general far less formal than the actual product:
http://www.flickr.com/photos/novemberborn/2110674112/

Comment 34

[[e-mail] (:bhearsum)]

The Firefox build machines have all been updated to the new PSDK. We can safely land the new icon now.

As mconnor suggested above, we should also get a Vista-sized Minefield icon. I think this should go in really soon (ie, before we spin Beta 3).

Comment 35

[Steven Garrity [:sgarrity]]

Attachment: Vista-sized Minefield icon

Here's a minefield icon that includes the 128px and Vista 256px sizes. It's actually just a resampling of the 128px icon, but it should do. I'll see if I can get a higher-quality original.

Comment 36

[Mike Connor [:mconnor]]

Gavin, can you reland the vista-sized Firefox and Minefield icons?

Steven, could we get an unbranded icon (the globe-only image) so we have all branding sets covered?

Comment 37

[:Gavin Sharp [email: [e-mail]]]

Landed both the Firefox and the Minefield icon:
mozilla/browser/app/firefox.ico 	1.4
mozilla/other-licenses/branding/firefox/firefox.ico 	1.6

Comment 38

[:Gavin Sharp [email: [e-mail]]]

I backed out the minefield icon, because it broke stuart's machine and we're not sure how common the bustage is. Filed bug 414082.

Comment 39

[Mike Lierman]

*** VERIFIED

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Comment 40

[Tony Chung [:tchung]]

via comment 39

Comment 41

[Steven Garrity [:sgarrity]]

Attachment: Firefox icon with new Vista-friendly sizes

It turns out the previous Firefox icon with the new vista sizes was based on the Firefox 1.5 icon rather than the updated Firefox 2 icon. Shame on me! Here's the proper Firefox 2 icon with the Vista sizes. This is what should be used in Firefox 3.

Comment 42

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Comparison of icons

Here are comparisons of the the new icon to the previous one, on XP (left) and Vista (right).  I'm seeing slight color variations, but very strangely only on XP.

The color variations are imperceptible, so it likely isn't worth trying to track down what is causing it.

Comment 43

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 320176 [details]
Firefox icon with new Vista-friendly sizes

Thanks for quickly fixing the issue.  Overall this looks great, notes on some slight color variations are in comment #42.

Comment 44

[:Gavin Sharp [email: [e-mail]]]

Does this new icon need to land on the branch as well?

Comment 45

[:Gavin Sharp [email: [e-mail]]]

That is, did attachment 227265 [details] (which was checked in on the branch for Firefox 2) also have this problem?

Comment 46

[:Gavin Sharp [email: [e-mail]]]

mozilla/other-licenses/branding/firefox/firefox.ico 	1.7 

Comment 47

[Hasham]

Looks fine on Vista now. Marking as verified. Attaching screenshot.

Comment 48

[Hasham]

Attachment: FF Icon Large

It looks sharp. :)