402848 - update win32 ref platform to include newer platform SDK, newer mozillabuild, and then deploy

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[(not currently active) Ted Mielczarek]

This sucks, but bug 346214 is a M10 blocker, and fixing it is going to require a newer platform SDK on the Firefox Win32 tinderbox.  It's also going to require an updated MozillaBuild, which we haven't released yet of course.  I can get the fix in for that, and release a quick rev of MB, or we can locally patch the MB in the refplatform, whatever build would prefer.

Comment 1

[[e-mail] (:bhearsum)]

Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild

Comment 2

[Phil Ringnalda (:philor)]

Surely this bug, about putting a newer SDK and the new MozillaBuild on a tinderbox, isn't a MozillaBuild bug?

Comment 3

[(not currently active) Ted Mielczarek]

He missed this one in the fixup.  :-)

Comment 4

[(not currently active) Ted Mielczarek]

Ok, we finally got MozillaBuild 1.2 out the door, so this is possible.  You'll need to install the updated MozillaBuild, and a Platform SDK.  You should probably install the Vista SDK, unless there's reason to install something else, since that's the latest one, and it will future-proof us for a little bit.

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Needed well in advance of beta3, because of the vista icon bug (bug#340976).

Comment 6

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Adding dependency on nsis bug#403078

Comment 7

[(not currently active) Ted Mielczarek]

I don't think that's a dependency.  That's for the 1.8 branch, and those boxes don't use the ref platform.

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Yes, bug#403078 is about updating nsis on the 1.8 branch, definitely no ref platform there. However, bug#403078 specifies to use the same version of nsis as is used on trunk (I assume because of the vista install problem in bug#370571).

If we truly need the same version of nsis on 1.8 and on trunk, then I would like to confirm what version of nsis that needs to be *before* we start rolling out this new win32 ref platform on trunk. If the nsis on trunk is currently correct, great, no change. However, if the nsis on trunk is wrong, I'd hate to do this new ref platform update now for the vista icon problem, and then have to another new ref platform update in early Jan when we hit the vista installer problem on trunk and want to update nsis on trunk.

Not sure if that makes sense - I'm just reading the bugs, so please let me know if I'm misunderstanding?!?

Comment 9

[(not currently active) Ted Mielczarek]

MozillaBuild already includes NSIS 2.22, so there shouldn't be a problem.  We also included the Unicode version (2.33u) as per Rob Strong's instruction, but that's a separate issue.  I think you're good to go here.

Comment 10

[[e-mail] (:bhearsum)]

I'm cloning a VM to give this a shot with.

Comment 11

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #9)
> MozillaBuild already includes NSIS 2.22, so there shouldn't be a problem.  We
> also included the Unicode version (2.33u) as per Rob Strong's instruction, but
> that's a separate issue.  I think you're good to go here.
Ah, great to hear. Thanks for the confirm, Ted.

Comment 12

[[e-mail] (:bhearsum)]

I've got Firefox building with the icon on my cloned VM. I'll work on getting that polished on Monday.

Comment 13

[[e-mail] (:bhearsum)]

I've updated win2k3sp2-vc8tools-ref-vm and the wiki page for it (http://wiki.mozilla.org/ReferencePlatforms/Win32).

The only changes are installing the new psdk and MozillaBuild 1.2. We should be able update any existing machines in place rather than cloning and re-deploying.

MozillaBuild should "just work" with the new psdk after installing 1.2. I had no trouble getting a build to work with the new icon.

Comment 14

[[e-mail] (:bhearsum)]

Here's a list of machines that (I believe to) need updating:
fx-win32-1.9-slave1
fx-win32-1.9-slave2
moz2-win32-slave1
staging-try1-win32-slave
try1-win32newref-slave
fx-win32-tbox
tbnewref-win32-tbox
l10n-win32-tbox
xr-win32-tbox

If I'm missing anything, or a machine listed above shouldn't be updated please correct me.

I think we should update either fx-win32-1.9-slave1 (staging release automation trunk builder) or fx-win32-tbox first to get some better testing. I've successfully done a build but nothing more than that.

Thoughts, anyone?

Comment 15

[[e-mail] (:bhearsum)]

I'm going to go ahead and upgrade fx-win32-1.9-slave1 after this current run and see how that goes.

Comment 16

[[e-mail] (:bhearsum)]

I've updated fx-win32-1.9-slave1 to the new reference platform. I'm kicking off a run right now that will include the new icon.

Comment 17

[[e-mail] (:bhearsum)]

The new ref platform appears to build and use the new icon just fine. I'm going to upgrade fx-win32-1.9-slave2 and the tryserver slaves this afternoon. I think we'll have to arrange for downtime to update the rest of them.

Comment 18

[[e-mail] (:bhearsum)]

The following machines have been updated to the new reference platform:
tbnewref-win32-tbox (had to comment out the 'export PATH' in .bash_profile to make the build work)
fx-win32-tbox
xr-win32-tbox
l10n-win32-tbox
fxdbug-win32-tbox
moz2-win32-slave1
try1-win32-slave
fx-linux-1.9-slave2

I still need to update the staging win32 try builder, which should be done later today.

Other than the aformentioned problem with tbnewref-win32-tbox things seem to be fine. Once I get the last machine updated I'll update and close this bug.

Comment 19

[[e-mail] (:bhearsum)]

OK. All win32 machines in the Build network that were running the ref platform with MSYS should now be updated. Any machines running cygwin were left (to upgrade them I think we should just clone the ref platform vm).