342711 - Thunderbird displays useless "Don't import anything" dialog on first launch

Status: VERIFIED FIXED

(Thunderbird :: Migration, defect)

Description

[Matthew T (active 1999-2002)]

Thunderbird 1.5.0.4, Ubuntu 6.06

I just installed Thunderbird, and the first thing it did when I ran it was show me a dialog asking what I wanted to import. That would have been great (I'd like my Evolution settings imported), but there was only one radio button in the dialog: "Don't import anything".

If Thunderbird can't find anything to import, it would be much better not to show this window at all.

Comment 1

[Magnus Melin [:mkmelin]]

*** Bug 344133 has been marked as a duplicate of this bug. ***

Comment 2

[timeless]

Attachment: look through the known importers before deciding to construct a useless dialog

i hit this bug while using thunderbird for the first time on opensolaris. it was a terrible first run experience.

Comment 3

[timeless]

Comment on attachment 229710 [details] [diff] [review]
look through the known importers before deciding to construct a useless dialog

mozilla/mail/components/migration/src/nsProfileMigrator.cpp 	1.10

Comment 4

[Adam Guthrie]

Verified FIXED with Thunderbird version 3 alpha 1 (20060731).

Comment 5

[Adam Guthrie]

Comment on attachment 229710 [details] [diff] [review]
look through the known importers before deciding to construct a useless dialog

We should get this in on branch.

Comment 6

[Magnus Melin [:mkmelin]]

timeless: this has approval‑thunderbird2+

Comment 7

[Magnus Melin [:mkmelin]]

This probably caused bug 367723.

Comment 8

[Adam Guthrie]

Comment on attachment 229710 [details] [diff] [review]
look through the known importers before deciding to construct a useless dialog

Apparently this breaks importing if data exists to import. (See bug 367723.)

Fortunately, timeless did NOT check this in on the 1.8 branch. Removing approval flag until we can figure out what to do.

Comment 10

[Tobias Koenig]

Attachment: Patch against 1.8 branch

This patch is a backport of the original patch against the 1.8 branch (well, there was not much to change ;))

Comment 11

[Noèl Köthe]

will this patch for 1.8 be included?

Comment 12

[Magnus Melin [:mkmelin]]

Probably not as the 1.8 branch is for security and crash fixes. This is polish, and thunderbird3 is scheduled to be out in not so many months anyway.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 331562 [details] [diff] [review]
Patch against 1.8 branch

Comment 12 sounds right to me: I don't think we'd take this on branch.  Because we're resource constrained the only way we can ensure sufficient branch stability is by minimizing the amount of patches we take there.  Sorry for not responding to the review request sooner.