Closed Bug 342743 Opened 14 years ago Closed 14 years ago

Clear Private Data shortcut (Cmd+Shift+Delete) requires Fn to be held on Mac laptops

Categories

(Firefox :: Keyboard Navigation, defect)

PowerPC
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3 alpha1

People

(Reporter: pionex, Assigned: sdwilsh)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060626 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060626 Minefield/3.0a1

I am unable to use the clear private data shortcut (cmd-shift-delete) in Mac OSX.  I used the latest stable version of firefox in addition to the most recently nightly build and the error does not appear to have been corrected.  To be sure, other shortcuts such as cmd-shift-h work for history, but not the one for clear private data.  I'm hitting the only delete key present on the macbook.

 

Reproducible: Always

Steps to Reproduce:
1.Hit cmd+shift+delete
2.Nothing happens
3.

Actual Results:  
Nothing...  that is the problem

Expected Results:  
The clear private data dialog should pop up
Does the menu item work History -> Clear Private Data?
Assignee: nobody → hwaara
(In reply to comment #1)
> Does the menu item work History -> Clear Private Data?
> 

Yeah, the menu item works fine.  Just not the shortcut.
You have to hold Fn (in addition to Cmd and Shift) for it to work, at least on my PowerBook.  Is that what you're seeing too?  Seems like a bug to me.
(In reply to comment #3)
> You have to hold Fn (in addition to Cmd and Shift) for it to work, at least on
> my PowerBook.  Is that what you're seeing too?  Seems like a bug to me.
> 

It does work if I hold down the Fn key.  Guess it is a bug.  At least this works though.  Thanks.
OS: Mac OS X 10.3 → Mac OS X 10.4
Version: unspecified → 1.5.0.x Branch
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2?
Summary: Clear Private Data Shortcut (cmd-shift-delete) does not appear to work in OSX → Clear Private Data shortcut (Cmd+Shift+Delete) requires Fn to be held on Mac laptops
Version: 1.5.0.x Branch → Trunk
We won't block for this, but it seems like a simple patch so if you get it reviewed and baked on trunk please nominate it for landing.

I'm not sure what the shortcut would be on Mac.
Flags: blocking-firefox2?
DOM Inspector has a similar problem (bug 344302).  Bookmarks used to (bug 271496).  It might be good to make a lowish-level fix to fix both problems, so we don't have to keep adding ifdefs for Mac OS X.
Attached patch v1.0 (obsolete) — Splinter Review
Very similar to Bug 344302, but I'm using an ifdef here.  Let me know if someone wants me to toss a comment in there as well.
Assignee: hwaara → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #239969 - Flags: superreview?(neil)
Attachment #239969 - Flags: review?(gavin.sharp)
Attachment #239969 - Flags: superreview?(neil)
Attachment #239969 - Flags: review?(gavin.sharp) → review?(mano)
Comment on attachment 239969 [details] [diff] [review]
v1.0

(with the #ifdef XP_MACOSX blocks merged).
Attached patch v1.1Splinter Review
Combines #ifdef's.  I also added my name to the list of contributors.

r=mano
Attachment #239969 - Attachment is obsolete: true
Whiteboard: [checkin needed]
Out of curiousity, how/where is the sanitize_mac key used? Is the "_mac" suffix a magic platform override?
(In reply to comment #11)
> Out of curiousity, how/where is the sanitize_mac key used? Is the "_mac" suffix
> a magic platform override?
> 

It is just an arbitrary id - it now works with with cmd-shift-backspace, which is the only delete key on the mac laptops.
mozilla/browser/base/content/browser-sets.inc 	1.82
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha1
You need to log in before you can comment on or make changes to this bug.