Closed Bug 344302 Opened 19 years ago Closed 19 years ago

[Mac] Delete (to remove nodes) doesn't work unless I hold Fn

Categories

(Other Applications :: DOM Inspector, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha

People

(Reporter: jruderman, Assigned: sdwilsh)

Details

Attachments

(1 file, 2 obsolete files)

Steps to reproduce (on a PowerBook): 1. Select a node in DOM Inspector. 2. Press Delete. Result: nothing happens. If I press Fn+Delete instead, it works. cf bug 342743.
Confirming. This also affect 1.5, and presumably 2.0 as well.
Attached patch v1.0 (obsolete) — Splinter Review
Using an ifdef like Bug 271496.
Assignee: dom-inspector → comrade693+bmo
Status: NEW → ASSIGNED
Attachment #239349 - Flags: superreview?
Attachment #239349 - Flags: review?(timeless)
Attachment #239349 - Flags: superreview? → superreview?(neil)
Comment on attachment 239349 [details] [diff] [review] v1.0 I don't think this #ifdef would be a good idea, you would need different .xpi files for the Mac.
Attachment #239349 - Flags: superreview?(neil) → superreview-
(In reply to comment #3) > (From update of attachment 239349 [details] [diff] [review] [edit]) > I don't think this #ifdef would be a good idea, you would need different .xpi > files for the Mac. Err...well, I'm open to suggestions then on how to fix this. It is rather annoying since I've been using my mac more with the domi and right clicking to delete every time is getting old.
Attached patch v2.0 (obsolete) — Splinter Review
Alright, this is per conversations on irc with Neil and Mano. I haven't been able to test this on Windows yet because my build won't start, but it works wonderfully on my mac.
Attachment #239349 - Attachment is obsolete: true
Attachment #239832 - Flags: superreview?(neil)
Attachment #239832 - Flags: review?(timeless)
Attachment #239349 - Flags: review?(timeless)
Attachment #239832 - Flags: superreview?(neil) → superreview+
Attached patch 2.1Splinter Review
After testing it on my Windows box I noticed that I had the wrong id of the item to be disabled. We need to be disabling keyEditDeleteMac as there is no cmdEditDeleteMac. Whoops...
Attachment #239832 - Attachment is obsolete: true
Attachment #239848 - Flags: review?(timeless)
Attachment #239832 - Flags: review?(timeless)
Attachment #239848 - Flags: review?(timeless) → review+
Whiteboard: [checkin needed]
mozilla/extensions/inspector/resources/content/editingOverlay.xul 1.2 mozilla/extensions/inspector/resources/content/inspector.js 1.31
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
QA Contact: timeless → dom-inspector
I found a bug that is similar to my problem .T was listed a bug 344202. Firefox will not let me install the adobe flash player plugin. Therefore, I can not download videos on You Tube. Ho do I correct this prolem. I keep getting a message that I need to close Firefox inoder to complete the adobe flash player installation.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: