343875 - The old labels prefs dialog should be removed or adapted to the new tags feature

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Tools -> Options... -> Display -> Labels

This dialog is outdated.

Comment 1

[Karsten Düsterloh]

XRef SM Bug 342560.

Comment 2

[Scott MacGregor]

I thought I had a tracking bug for this already but I don't see it now. 

Comment 3

[Scott MacGregor]

Attachment: the fix

This UI might just be temporary for the alpha, but it gets the job done for letting users delete tags. We might end up re-designing this after the alpha.

I haven't implemented editing yet, but left the l10n strings in there so localizers can start filling that in.

Comment 4

[Scott MacGregor]

Comment on attachment 229285 [details] [diff] [review]
the fix

I didn't diff the right set of files.

Comment 5

[Scott MacGregor]

Attachment: the fix

UI for adding and removing tags.

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

Deleting a tag is more than successfull...

Tb 2.0a1 20060717

In the first moment only the deleted tag is removed out of the list. Close the options dialog and reopen it (or try to tag a message). You'll see, there are multiple tags removed - including some default tags. And the previous selected message (in the moment I deleted the tag(s)) has been tagged with any tag.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Restarting Thunderbird restores the missing tags.

Is it intended to be able to delete default tags? They were removed out of prefs.js

Comment 8

[Alex Ihrig [:Thunderbird_Mail_DE]]

One more thing.

Delete some tags. Close the options dialog. Select a message and choose the context menu > Tag message.

The shown tags list includes empty ghosts of the deleted tags. It's necessary to restart Thunderbird to rebuild the list without the ghosts.

Comment 9

[Karsten Düsterloh]

*** Bug 348123 has been marked as a duplicate of this bug. ***

Comment 10

[Mike Cowperthwaite]

xref Seamonkey bug 342560.

Comment 11

[Mike Cowperthwaite]

The fix at the dupe is for TB as well as SM.  Current builds are at least functional now, but the new dialog is not complete yet.

*** This bug has been marked as a duplicate of 342560 ***

Comment 12

[Karsten Düsterloh]

(In reply to comment #11)
> The fix at the dupe is for TB as well as SM.

Erm, no.
There's a band-aid patch there to keep tags working in SM 1.1a, but the actual panel will most probably not be a TB solution, since TB and SM use quite different pref windows.
I could try to deal with the TB panel, but my knowledge there is quite limited and I'd rather not do this, so I suggest to reopen this bug here for TB solution.

Comment 13

[David :Bienvenu]

ok, I'll re-open for now.

Comment 14

[Scott MacGregor]

Alexander, I think we can close this out as fixed now right? Both seamonkey and Thunderbird now have re-vamped options UI for adding, editing and deleting tags.

Comment 15

[Alex Ihrig [:Thunderbird_Mail_DE]]

Seems to be fixed in 2.0b1. Thanks.

Comment 16

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 with my tests and also verified by comment #15.