Closed Bug 344389 Opened 18 years ago Closed 18 years ago

feed parser doesn't expose guid/atom:id/rdf:about correctly

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: sayrer, Assigned: sayrer)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

normalize id values, 7 unit tests
19.74 KB, patch
bugs
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
change the attribute name to "id", and make sure everything is normalized properly

        Attachment #228977 -
        Flags: review?(bugs)

    
    

    
  


  

        Attachment #228977 -
        Attachment is obsolete: true

        Attachment #228978 -
        Flags: review?(bugs)

        Attachment #228977 -
        Flags: review?(bugs)

    
  
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta2

    
    

    
  
robert, what is this actually about?
Flags: blocking-firefox2? → blocking-firefox2+

    
    

    
  
(In reply to comment #3)
> robert, what is this actually about?
> 

The unique identifier for entries lives in different places in different formats, and the interface needs to correctly provide a convenience accessor for that value after it has been normalized. Sometimes the link *is* the guid in RSS2, so that needs to be correct for feed preview.

    
  
Blocks: 344991

    
  

        Attachment #228978 -
        Flags: review?(bugs) → review?(mconnor)

    
  

        Attachment #228978 -
        Flags: review?(mconnor) → review?(bugs)
Whiteboard: [has patch][needs review ben]

    
    

    
  
Comment on attachment 228978 [details] [diff] [review]
normalize id values, 7 unit tests

r=ben@mozilla.org

        Attachment #228978 -
        Flags: review?(bugs) → review+

    
    

    
  
Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.4; previous revision: 1.3
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.5; previous revision: 1.4
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_id.xml,v
done
Checking in test/xml/rfc4287/entry_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_id.xml,v  <--  entry_id.xml
initial revision: 1.1
done
Checking in test/xml/rfc4287/feed_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_id.xml,v  <--  feed_id.xml
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_id.xml,v
done
Checking in test/xml/rss1/feed_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_id.xml,v  <--  feed_id.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_id.xml,v
done
Checking in test/xml/rss1/item_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_id.xml,v  <--  item_id.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_bogus_url.xml,v
done
Checking in test/xml/rss2/item_guid_bogus_url.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_bogus_url.xml,v  <--  item_guid_bogus_url.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_isPermaLink.xml,v
done
Checking in test/xml/rss2/item_guid_isPermaLink.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_isPermaLink.xml,v  <--  item_guid_isPermaLink.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_normalized.xml,v
done
Checking in test/xml/rss2/item_guid_normalized.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_normalized.xml,v  <--  item_guid_normalized.xml
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_with_link.xml,v
done
Checking in test/xml/rss2/item_guid_with_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_with_link.xml,v  <--  item_guid_with_link.xml
initial revision: 1.1
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  

        Attachment #228978 -
        Flags: approval1.8.1?

    
    

    
  
Comment on attachment 228978 [details] [diff] [review]
normalize id values, 7 unit tests

a=drivers. Please go ahead and land on the 181 branch.

        Attachment #228978 -
        Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [has patch][needs review ben] → [checkin needed (1.8 branch)]

    
    

    
  
Checking in public/nsIFeedContainer.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedContainer.idl,v  <--  nsIFeedContainer.idl
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.6; previous revision: 1.1.2.5
done
Checking in test/xml/rfc4287/entry_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/entry_id.xml,v  <--  entry_id.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rfc4287/feed_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/feed_id.xml,v  <--  feed_id.xml
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in test/xml/rss1/feed_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/feed_id.xml,v  <--  feed_id.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rss1/item_id.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss1/item_id.xml,v  <--  item_id.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rss2/item_guid_bogus_url.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_bogus_url.xml,v  <--  item_guid_bogus_url.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rss2/item_guid_isPermaLink.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_isPermaLink.xml,v  <--  item_guid_isPermaLink.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rss2/item_guid_normalized.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_normalized.xml,v  <--  item_guid_normalized.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/xml/rss2/item_guid_with_link.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rss2/item_guid_with_link.xml,v  <--  item_guid_with_link.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: