Closed Bug 344442 Opened 18 years ago Closed 18 years ago

openWalletPasswordDialog and checkWallet are not used.

Categories

(Calendar :: Internal Components, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Sunbird 0.3

People

(Reporter: jminta, Assigned: sipaq)

Details

Attachments

(1 file, 1 obsolete file)

The function openWalletPasswordDialog became obsolete a long time ago, and became very obsolete when we decided to kill the old calendar extension.  It should be removed.
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#523
Same for checkWallet()
Whiteboard: [good first bug]
Assignee: base → bugzilla
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → Sunbird 0.3
Joey, should I also remove launchPreferences() <http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#183> while I'm at it? It is also obsolete with the move to the NuPref architecture.
(In reply to comment #2)
> Joey, should I also remove launchPreferences()

That was removed with my checkin of bug 343601. If you update your working copy it should disappear.
Attached patch Patch v1 with additional cleanup (obsolete) — Splinter Review
This patch removes the unused function openWalletPasswordDialog() from calendar.js

In addition it also

- removes the unused function checkWallet()
- corrects some overlong lines of code to a length of 80 chars or less
- removes an empty trailing line at the end of the file

To test our new review process, I'm asking ssitter for a first-review, since he should be familiar with the changes I made and jminta as my 2nd reviewer.

I tested the additional changes in a recent Sunbird nightly by

- opening the Sunbird about window
- customizing my toolbar from the context menu and from the main menu

I noted no issues with the patch.
Attachment #230871 - Flags: second-review?(jminta)
Attachment #230871 - Flags: first-review?(ssitter)
This is a 2nd version of the patch without the "long-line" cleanup.

This patch simply removes the unused functions openWalletPasswordDialog() and checkWallet()
Attachment #230871 - Attachment is obsolete: true
Attachment #230975 - Flags: second-review?(jminta)
Attachment #230975 - Flags: first-review?
Attachment #230871 - Flags: second-review?(jminta)
Attachment #230871 - Flags: first-review?(ssitter)
Attachment #230975 - Flags: first-review? → first-review?(ssitter)
Comment on attachment 230975 [details] [diff] [review]
Patch v2 (without cleanup)

Looks good. r=ssitter
Attachment #230975 - Flags: first-review?(ssitter) → first-review+
Comment on attachment 230975 [details] [diff] [review]
Patch v2 (without cleanup)

much better... r=jminta
Attachment #230975 - Flags: second-review?(jminta) → second-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: openWalletPasswordDialog is not used. → openWalletPasswordDialog and checkWallet are not used.
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: