344442 - openWalletPasswordDialog and checkWallet are not used.

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

The function openWalletPasswordDialog became obsolete a long time ago, and became very obsolete when we decided to kill the old calendar extension.  It should be removed.
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#523

Comment 1

[Joey Minta]

Same for checkWallet()

Comment 2

[Simon Paquet [:sipaq]]

Joey, should I also remove launchPreferences() <http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendar.js#183> while I'm at it? It is also obsolete with the move to the NuPref architecture.

Comment 3

[Matthew (lilmatt) Willis]

(In reply to comment #2)
> Joey, should I also remove launchPreferences()

That was removed with my checkin of bug 343601. If you update your working copy it should disappear.

Comment 4

[Simon Paquet [:sipaq]]

Attachment: Patch v1 with additional cleanup

This patch removes the unused function openWalletPasswordDialog() from calendar.js

In addition it also

- removes the unused function checkWallet()
- corrects some overlong lines of code to a length of 80 chars or less
- removes an empty trailing line at the end of the file

To test our new review process, I'm asking ssitter for a first-review, since he should be familiar with the changes I made and jminta as my 2nd reviewer.

I tested the additional changes in a recent Sunbird nightly by

- opening the Sunbird about window
- customizing my toolbar from the context menu and from the main menu

I noted no issues with the patch.

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch v2 (without cleanup)

This is a 2nd version of the patch without the "long-line" cleanup.

This patch simply removes the unused functions openWalletPasswordDialog() and checkWallet()

Comment 6

[Stefan Sitter [:ssitter]]

Comment on attachment 230975 [details] [diff] [review]
Patch v2 (without cleanup)

Looks good. r=ssitter

Comment 7

[Joey Minta]

Comment on attachment 230975 [details] [diff] [review]
Patch v2 (without cleanup)

much better... r=jminta

Comment 8

[Joey Minta]

patch checked in.