34484 - popups confuse modal-on-a-modal and input

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Alec Flett]

if you have a window with a modal dialog, and another modal dialog on top of it,
then have a <menulist> in the top modal:
- the menulist works the first time and you can select something with the popup
that appears.
- from this point forward, the top modal won't accept any more input (keyboard
or mouse)
- now the toolkit seems to think that the bottom modal dialog has modality,
because you can now hit ok/cancel in the previous dialog.

It seems like the modality has been switched between these two dialogs after
using the menulist - because the bottom modal is accepting input when it's not
supposed to and the top is not accepting input when it should.

I'll be checking in some UI that is a good example.
I'll bet this is Linux-only, but I'm not sure.

Comment 1

[Alec Flett]

actually, it looks like all popups (even html:selects) are causing problems
witha a modal-on-a-modal
This makes it impossible to create an IMAP account on linux.

Adding trudelle for traction.

Comment 2

[Peter Trudelle]

targetting p1 for M15.  cc'ing danm for modality and pink for menus. Who should 
really own this? 

Comment 3

[Peter Trudelle]

Mass-moving most M15 bugs to M16

Comment 4

[Christopher Blizzard (:blizzard)]

Is there a test case for this somewhere?  If it's linux specific I'll bet it's
my bug.

Comment 5

[Alec Flett]

there are a few actually
Open mail. Edit->Mail/News Account Settings. 
Now, a few cases:
- click the "Advanced" button on the main panel for an account. use the menulist
widget to select a server.... you'll get stuck and have to close the window
manually.
- Click New Account. Click Next twice - use the select widget to select
anything. Again, you get stuck in this state

Comment 6

[Dan M]

.

Comment 7

[Dan M]

*** Bug 33550 has been marked as a duplicate of this bug. ***

Comment 8

[lchiang]

damm, alec - do you think we should take this fix for M15?  Reason: we can't 
create IMAP accounts on Linux.  Perhaps the sooner we take it, the longer we 
have to test it for M15 (?)

Comment 9

[Alec Flett]

yes, I think this needs to be an m15 bug. Peter/Dan?

Comment 10

[Christopher Blizzard (:blizzard)]

Someone has a patch.  Is it in widget/ or is it in layout?

Comment 11

[Peter Trudelle]

whoops, didn't mean to move this one. If you can't create new accounts, then 
couldn't this be masking other bugs?  Seems like we should take a 
well-understood fix.

Comment 12

[lchiang]

*** Bug 35047 has been marked as a duplicate of this bug. ***

Comment 13

[Dan M]

All modal dialogs are now temporarily not modal for the lifetime of the combobox 
popup window. This little sleight of hand stems the confusion, and doesn't seem 
to hurt anything.

Comment 14

[Christopher Blizzard (:blizzard)]

I don't like this fix.  I've worked on the grab + modal code at length and this
doesn't feel like the right fix.

Comment 15

[Christopher Blizzard (:blizzard)]

Assigning to me.

Comment 16

[Christopher Blizzard (:blizzard)]

Moving to m16 since there's already a work around in place.

Comment 17

[Alec Flett]

*** Bug 34928 has been marked as a duplicate of this bug. ***

Comment 18

[Christopher Blizzard (:blizzard)]

I'll go back and look at this if it becomes a problem.  I haven't seen anything
bad from it yet.

Comment 19

[Christopher Blizzard (:blizzard)]

Please ignore the spam.  Changing address.

Comment 20

[Christopher Blizzard (:blizzard)]

busted from my reassign

Comment 21

[Christopher Hoess (gone)]

LATER is deprecated per bug 35839.  Reopening, futuring.

Comment 22

[John Morrison]

Works for me for the two case cited in comment #7 (first one works; second one 
no longer applies due to UI changes). Linux 4/25 branch rc1 build.

re: comment #18 "I'll go back and look at this if it becomes a problem."
Two years seems like a sufficient waiting period.

WFM.