344915 - Non-installed modules are reported incorrectly

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Teemu Mannermaa (:wicked)]

There's output like this for modules that are not installed/found:

Checking for  LWP::UserAgent (any)     ok: not found

So checksetup thinks it's ok to not have these. As such there's also no output explaining why you would need that module.

Probably a regression from bug 281494.

Comment 1

[Colin Ogilvie [:cso]]

Looks to be a regression from bug 344661 to me...

If I remove the two lines added in that patch, my output goes from:

  Checking for   Image::Magick (any)     ok: not found

to

  Checking for   Image::Magick (any)      not found

Comment 2

[Max Kanat-Alexander]

Attachment: v1

It turns out to be a slight bug in the regex--it was stripping *all* starting zeros, including the 0 in 0.14 and in "0" itself. Now it only strips real padding zeros.

Comment 3

[Colin Ogilvie [:cso]]

Comment on attachment 229633 [details] [diff] [review]
v1

This fixes the problem on this bug, however, I don't know if it fixes the problem that the original regex was designed to solve.

Comment 4

[Frédéric Buclin]

Comment on attachment 229633 [details] [diff] [review]
v1

r=LpSolit

Comment 5

[Max Kanat-Alexander]

For anybody else who reads the bug: Yes, the regex does still fix the original problem it was designed to fix (checking the version of PostgreSQL).

Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
new revision: 1.3; previous revision: 1.2
done