345468 - port fix for bug #341697 (branding wizards) to tbird

Status: RESOLVED FIXED

Description

[(not reading, please use [e-mail] instead)]

port fix for bug #341697 (branding wizards) to tbird

add new icon48.png for tbird, fix the jar.mn, and then use branded=true where desired.

I'll attach the icon48.png for tbird

Comment 1

[(not reading, please use [e-mail] instead)]

Created attachment 230131 [details]
icon

Comment 2

[(not reading, please use [e-mail] instead)]

scott, to you intend to brand any wizards for 2.0?

Comment 3

[(not reading, please use [e-mail] instead)]

you'll need to make it your version of this icon is at chrome://branding/content/icon48.png, so that the css changes to toolkit will work for you.

Comment 4

[Magnus Melin [:mkmelin]]

wanted‑thunderbird3+; Offhand doesn't look like a lot of work if someone is interested, assuming what is needed is to do corresponding changes (attachment 230088 [details] [diff] [review]) as in browser/ for mail/ + adding the icon.

Comment 5

[Mark Banner (:standard8)]

I can take this, looks like the only change will be to profile migration - the import screen isn't a wizard, and I don't think branding is really suitable for the account manager.

Comment 6

[Mark Banner (:standard8)]

Created attachment 325021 [details]
Migration Wizard - before

As I said in comment 5, its only really the profile migration wizard that can be changed/needs to be branded. I think its really important, as migrating users will see this on first visit, and it'll be nice to have the logo there from the start.

Attaching screenshot of the migration wizard before the change.

Comment 7

[Mark Banner (:standard8)]

Created attachment 325022 [details]
Migration Wizard - after (unbranded)

Here's the unbranded version

Comment 8

[Mark Banner (:standard8)]

Created attachment 325027 [details]
Migration Wizard - after (branded)

Here's the Migration Wizard with branding on. For this I used the icon that Seth supplied on this bug. For the unbranded version I used http://mxr.mozilla.org/seamonkey/source/mail/base/content/icon64.png from the source tree and did a straight reduction to 48x48.

Although we probably want to change the unbranded icons at some stage, I'm working with what we've got at the moment.

I've also dropped the additional "From" that was on the title of the migration wizard.

Comment 9

[Mark Banner (:standard8)]

Created attachment 325029 [details] [diff] [review]
The fix

Here's the patch that does this change. I think that as the change in title of the wizard is only a grammar correction, then I believe we don't need to change the name of the entity.

Let me know if you have problems applying it, this is the first time I've done a patch with binaries in it like this.

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 325029 [details] [diff] [review]
The fix

Applied just fine: |patch| ignored the binary bits, I thought about whether I wanted to switch to Mercurial-CVS, and decided resizing the images myself was easier :)

r=philringnalda, looks and works just fine.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 325027 [details]
Migration Wizard - after (branded)

looks good

Comment 12

[Mark Banner (:standard8)]

Patch checked in -> fixed.