port fix for bug #341697 (branding wizards) to tbird

RESOLVED FIXED in Thunderbird 3

Status

Thunderbird
Mail Window Front End
P3
normal
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: standard8)

Tracking

({helpwanted})

Trunk
Thunderbird 3
helpwanted
Dependency tree / graph
Bug Flags:
wanted-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

port fix for bug #341697 (branding wizards) to tbird

add new icon48.png for tbird, fix the jar.mn, and then use branded=true where desired.

I'll attach the icon48.png for tbird
Depends on: 341697
Version: 1.5 → Trunk
Created attachment 230131 [details]
icon
scott, to you intend to brand any wizards for 2.0?
you'll need to make it your version of this icon is at chrome://branding/content/icon48.png, so that the css changes to toolkit will work for you.

Updated

10 years ago
Flags: wanted-thunderbird3.0a2?

Comment 4

10 years ago
wanted‑thunderbird3+; Offhand doesn't look like a lot of work if someone is interested, assuming what is needed is to do corresponding changes (attachment 230088 [details] [diff] [review]) as in browser/ for mail/ + adding the icon.
Assignee: mscott → nobody
Flags: wanted-thunderbird3.0a2? → wanted-thunderbird3+
Keywords: helpwanted
Hardware: PC → All
(Assignee)

Comment 5

10 years ago
I can take this, looks like the only change will be to profile migration - the import screen isn't a wizard, and I don't think branding is really suitable for the account manager.
Assignee: nobody → bugzilla
(Assignee)

Comment 6

10 years ago
Created attachment 325021 [details]
Migration Wizard - before

As I said in comment 5, its only really the profile migration wizard that can be changed/needs to be branded. I think its really important, as migrating users will see this on first visit, and it'll be nice to have the logo there from the start.

Attaching screenshot of the migration wizard before the change.
Attachment #230131 - Attachment is obsolete: true
(Assignee)

Comment 7

10 years ago
Created attachment 325022 [details]
Migration Wizard - after (unbranded)

Here's the unbranded version
(Assignee)

Comment 8

10 years ago
Created attachment 325027 [details]
Migration Wizard - after (branded)

Here's the Migration Wizard with branding on. For this I used the icon that Seth supplied on this bug. For the unbranded version I used http://mxr.mozilla.org/seamonkey/source/mail/base/content/icon64.png from the source tree and did a straight reduction to 48x48.

Although we probably want to change the unbranded icons at some stage, I'm working with what we've got at the moment.

I've also dropped the additional "From" that was on the title of the migration wizard.
Attachment #325027 - Flags: ui-review?(clarkbw)
(Assignee)

Updated

10 years ago
Attachment #325027 - Attachment is patch: false
Attachment #325027 - Attachment mime type: text/plain → image/png
(Assignee)

Comment 9

10 years ago
Created attachment 325029 [details] [diff] [review]
The fix

Here's the patch that does this change. I think that as the change in title of the wizard is only a grammar correction, then I believe we don't need to change the name of the entity.

Let me know if you have problems applying it, this is the first time I've done a patch with binaries in it like this.
Attachment #325029 - Flags: review?(philringnalda)
Comment on attachment 325029 [details] [diff] [review]
The fix

Applied just fine: |patch| ignored the binary bits, I thought about whether I wanted to switch to Mercurial-CVS, and decided resizing the images myself was easier :)

r=philringnalda, looks and works just fine.
Attachment #325029 - Flags: review?(philringnalda) → review+
(Assignee)

Updated

10 years ago
Priority: -- → P3
Comment on attachment 325027 [details]
Migration Wizard - after (branded)

looks good
Attachment #325027 - Flags: ui-review?(clarkbw) → ui-review+
(Assignee)

Comment 12

10 years ago
Patch checked in -> fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Target Milestone: --- → Thunderbird 3
(Assignee)

Updated

10 years ago
Depends on: 445501
You need to log in before you can comment on or make changes to this bug.