Closed Bug 345468 Opened 16 years ago Closed 14 years ago

port fix for bug #341697 (branding wizards) to tbird

Categories

(Thunderbird :: Mail Window Front End, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: moco, Assigned: standard8)

References

Details

(Keywords: helpwanted)

Attachments

(4 files, 1 obsolete file)

port fix for bug #341697 (branding wizards) to tbird

add new icon48.png for tbird, fix the jar.mn, and then use branded=true where desired.

I'll attach the icon48.png for tbird
Depends on: 341697
Version: 1.5 → Trunk
Attached image icon (obsolete) —
scott, to you intend to brand any wizards for 2.0?
you'll need to make it your version of this icon is at chrome://branding/content/icon48.png, so that the css changes to toolkit will work for you.
Flags: wanted-thunderbird3.0a2?
wanted‑thunderbird3+; Offhand doesn't look like a lot of work if someone is interested, assuming what is needed is to do corresponding changes (attachment 230088 [details] [diff] [review]) as in browser/ for mail/ + adding the icon.
Assignee: mscott → nobody
Flags: wanted-thunderbird3.0a2? → wanted-thunderbird3+
Keywords: helpwanted
Hardware: PC → All
I can take this, looks like the only change will be to profile migration - the import screen isn't a wizard, and I don't think branding is really suitable for the account manager.
Assignee: nobody → bugzilla
As I said in comment 5, its only really the profile migration wizard that can be changed/needs to be branded. I think its really important, as migrating users will see this on first visit, and it'll be nice to have the logo there from the start.

Attaching screenshot of the migration wizard before the change.
Attachment #230131 - Attachment is obsolete: true
Here's the unbranded version
Here's the Migration Wizard with branding on. For this I used the icon that Seth supplied on this bug. For the unbranded version I used http://mxr.mozilla.org/seamonkey/source/mail/base/content/icon64.png from the source tree and did a straight reduction to 48x48.

Although we probably want to change the unbranded icons at some stage, I'm working with what we've got at the moment.

I've also dropped the additional "From" that was on the title of the migration wizard.
Attachment #325027 - Flags: ui-review?(clarkbw)
Attachment #325027 - Attachment is patch: false
Attachment #325027 - Attachment mime type: text/plain → image/png
Attached patch The fixSplinter Review
Here's the patch that does this change. I think that as the change in title of the wizard is only a grammar correction, then I believe we don't need to change the name of the entity.

Let me know if you have problems applying it, this is the first time I've done a patch with binaries in it like this.
Attachment #325029 - Flags: review?(philringnalda)
Comment on attachment 325029 [details] [diff] [review]
The fix

Applied just fine: |patch| ignored the binary bits, I thought about whether I wanted to switch to Mercurial-CVS, and decided resizing the images myself was easier :)

r=philringnalda, looks and works just fine.
Attachment #325029 - Flags: review?(philringnalda) → review+
Priority: -- → P3
Comment on attachment 325027 [details]
Migration Wizard - after (branded)

looks good
Attachment #325027 - Flags: ui-review?(clarkbw) → ui-review+
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Depends on: 445501
You need to log in before you can comment on or make changes to this bug.