Closed
Bug 345603
Opened 16 years ago
Closed 10 years ago
move Clear Recent History from the Tools to the History menu
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
relnote-firefox | --- | - |
People
(Reporter: steffen.wilberg, Assigned: bwinton)
Details
Attachments
(1 file, 1 obsolete file)
3.36 KB,
patch
|
limi
:
ui-review+
|
Details | Diff | Splinter Review |
Bug 329750 moved Clear Private Data from the Tools menu to the History menu, but into the #ifdef MOZ_PLACES section. As places was disabled on the branch, bug 333930 added it back to the Tools menu for the #ifndef MOZ_PLACES case. So the current status on the branch is this: #ifdef MOZ_PLACES: History menu http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-menubar.inc&rev=1.57.2.38&mark=327,328,366-369#327 #ifndef MOZ_PLACES: Tools menu http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-menubar.inc&rev=1.57.2.38&mark=512,532-538#512 Should we finally move it to the History menu?
Updated•13 years ago
|
Summary: move Clear Private Data from the Tools to the History menu → move Clear Recent History from the Tools to the History menu
Version: 2.0 Branch → Trunk
Reporter | ||
Comment 1•12 years ago
|
||
This is no longer valid.
Assignee | ||
Comment 2•10 years ago
|
||
Why is this no longer valid? (I've got a patch that moves it, if we want…) Thanks, Blake.
Comment 3•10 years ago
|
||
we should still do this.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee | ||
Comment 4•10 years ago
|
||
Cool, here's a patch! (I set Dao as the reviewer, because he's extra-thorough, and because I like him, but feel free to steal the review, if you want, Mak.) Thanks, Blake.
Assignee: nobody → bwinton
Attachment #708633 -
Flags: ui-review?(limi)
Attachment #708633 -
Flags: review?(dao)
Comment 5•10 years ago
|
||
Comment on attachment 708633 [details] [diff] [review] Move the menu item. >--- a/browser/base/content/browser-menubar.inc >+++ b/browser/base/content/browser-menubar.inc >@@ -360,17 +360,22 @@ > <menuseparator id="historyMenuHomeSeparator" > class="show-only-for-keyboard"/> > <menuitem id="menu_showAllHistory" > label="&showAllHistoryCmd2.label;" > #ifndef XP_MACOSX > key="showAllHistoryKb" > #endif > command="Browser:ShowAllHistory"/> >- <menuseparator id="showAllHistorySeparator"/> >+ <menuitem id="sanitizeItem" >+ accesskey="&clearRecentHistory.accesskey;" >+ label="&clearRecentHistory.label;" >+ key="key_sanitize" >+ command="Tools:Sanitize"/> >+ <menuseparator id="sanitizeSeparator"/> The history menu intentionally doesn't have access keys, so don't add one here and also remove clearRecentHistory.accesskey from browser.dtd.
Attachment #708633 -
Flags: review?(dao) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Done and done. Thank you!
Attachment #708633 -
Attachment is obsolete: true
Attachment #708633 -
Flags: ui-review?(limi)
Attachment #708660 -
Flags: ui-review?(limi)
Comment 7•10 years ago
|
||
Comment on attachment 708660 [details] [diff] [review] Version 2 of the patch to move the menu item. Hooray!
Attachment #708660 -
Flags: ui-review?(limi) → ui-review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfb1cc4ca87f
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bfb1cc4ca87f
Status: REOPENED → RESOLVED
Closed: 12 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Updated•10 years ago
|
relnote-firefox:
--- → ?
Comment 10•10 years ago
|
||
CCing, :tyler & :Matt to help cover as part of Support, if we see anything around this instead of release noting .
You need to log in
before you can comment on or make changes to this bug.
Description
•