move Clear Recent History from the Tools to the History menu

RESOLVED FIXED in Firefox 21

Status

()

RESOLVED FIXED
13 years ago
6 years ago

People

(Reporter: steffen.wilberg, Assigned: bwinton)

Tracking

Trunk
Firefox 21
Points:
---

Firefox Tracking Flags

(relnote-firefox -)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Bug 329750 moved Clear Private Data from the Tools menu to the History menu, but into the #ifdef MOZ_PLACES section. As places was disabled on the branch, bug 333930 added it back to the Tools menu for the #ifndef MOZ_PLACES case.

So the current status on the branch is this:

#ifdef MOZ_PLACES: History menu
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-menubar.inc&rev=1.57.2.38&mark=327,328,366-369#327

#ifndef MOZ_PLACES: Tools menu
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-menubar.inc&rev=1.57.2.38&mark=512,532-538#512

Should we finally move it to the History menu?

Updated

9 years ago
Summary: move Clear Private Data from the Tools to the History menu → move Clear Recent History from the Tools to the History menu
Version: 2.0 Branch → Trunk
(Reporter)

Comment 1

8 years ago
This is no longer valid.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: uiwanted
Resolution: --- → INVALID
(Assignee)

Comment 2

6 years ago
Why is this no longer valid?  (I've got a patch that moves it, if we want…)

Thanks,
Blake.
we should still do this.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(Assignee)

Comment 4

6 years ago
Created attachment 708633 [details] [diff] [review]
Move the menu item.

Cool, here's a patch!  (I set Dao as the reviewer, because he's extra-thorough, and because I like him, but feel free to steal the review, if you want, Mak.)

Thanks,
Blake.
Assignee: nobody → bwinton
Attachment #708633 - Flags: ui-review?(limi)
Attachment #708633 - Flags: review?(dao)
Comment on attachment 708633 [details] [diff] [review]
Move the menu item.

>--- a/browser/base/content/browser-menubar.inc
>+++ b/browser/base/content/browser-menubar.inc
>@@ -360,17 +360,22 @@
>                 <menuseparator id="historyMenuHomeSeparator"
>                                class="show-only-for-keyboard"/>
>                 <menuitem id="menu_showAllHistory"
>                           label="&showAllHistoryCmd2.label;"
> #ifndef XP_MACOSX
>                           key="showAllHistoryKb"
> #endif
>                           command="Browser:ShowAllHistory"/>
>-                <menuseparator id="showAllHistorySeparator"/>
>+                <menuitem id="sanitizeItem"
>+                          accesskey="&clearRecentHistory.accesskey;"
>+                          label="&clearRecentHistory.label;"
>+                          key="key_sanitize"
>+                          command="Tools:Sanitize"/>
>+                <menuseparator id="sanitizeSeparator"/>

The history menu intentionally doesn't have access keys, so don't add one here and also remove clearRecentHistory.accesskey from browser.dtd.
Attachment #708633 - Flags: review?(dao) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 708660 [details] [diff] [review]
Version 2 of the patch to move the menu item.

Done and done.  Thank you!
Attachment #708633 - Attachment is obsolete: true
Attachment #708633 - Flags: ui-review?(limi)
Attachment #708660 - Flags: ui-review?(limi)
Comment on attachment 708660 [details] [diff] [review]
Version 2 of the patch to move the menu item.

Hooray!
Attachment #708660 - Flags: ui-review?(limi) → ui-review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bfb1cc4ca87f
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
relnote-firefox: --- → ?
CCing, :tyler & :Matt to help cover as part of Support, if we see anything around this instead of release noting .
relnote-firefox: ? → -
You need to log in before you can comment on or make changes to this bug.