345650 - mailnews.max_header_display_length is now obsolete

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

With the new code for displaying multiple e-mail address headers, we no longer use the pref:

mailnews.max_header_display_length

We can remove that. And while we are at it, there was some code in mailWidgets.xml for the header widgets called getTextAttribute / setTextAttribute, I don't know why those exist, we can call setAttribute / getAttribute directly.

Comment 1

[Scott MacGregor]

Attachment: the fix

Removes an obsolete pref from seamonkey and thunderbird now that we have your new header display code. Removes get/setTextAttribute.

Comment 2

[Scott MacGregor]

*** Bug 345818 has been marked as a duplicate of this bug. ***

Comment 3

[Scott MacGregor]

This just went into the branch this morning. I had to wait until we spun out the alpha builds.

Comment 4

[Krang]

(In reply to comment #3)
> This just went into the branch this morning. I had to wait until we spun out
> the alpha builds.

It looks like the patch for mail/base/content/msgHdrViewOverlay.js was accidentally applied to mailnews/base/resources/content/msgHdrViewOverlay.js in CVS.  As a result, the check for AddExtraAddressProcessing on line 882 was removed, which breaks the mail header view pane in SeaMonkey on the branch.  This is the error that appears on the Error Console:

Error: AddExtraAddressProcessing is not defined
Source File: chrome://messenger/content/msgHdrViewOverlay.js
Line: 879

Comment 5

[Scott MacGregor]

(In reply to comment #4)
> (In reply to comment #3)
> > This just went into the branch this morning. I had to wait until we spun out
> > the alpha builds.
> 
> It looks like the patch for mail/base/content/msgHdrViewOverlay.js was
> accidentally applied to mailnews/base/resources/content/msgHdrViewOverlay.js in
> CVS.  As a result, the check for AddExtraAddressProcessing on line 882 was
> removed, which breaks the mail header view pane in SeaMonkey on the branch. 
> This is the error that appears on the Error Console:
> 
> Error: AddExtraAddressProcessing is not defined
> Source File: chrome://messenger/content/msgHdrViewOverlay.js
> Line: 879
> 

good catch. I cvs joined the mail version into the mailnews version by mistake. I just fixed this on the 1.8 branch for seamonkey users. Trunk was ok. Thanks!

Comment 6

[Scott MacGregor]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > This just went into the branch this morning. I had to wait until we spun out
> > > the alpha builds.
> > 
> > It looks like the patch for mail/base/content/msgHdrViewOverlay.js was
> > accidentally applied to mailnews/base/resources/content/msgHdrViewOverlay.js in
> > CVS.  As a result, the check for AddExtraAddressProcessing on line 882 was
> > removed, which breaks the mail header view pane in SeaMonkey on the branch. 
> > This is the error that appears on the Error Console:
> > 
> > Error: AddExtraAddressProcessing is not defined
> > Source File: chrome://messenger/content/msgHdrViewOverlay.js
> > Line: 879
> > 
> 
> good catch. I cvs joined the mail version into the mailnews version by mistake.
> I just fixed this on the 1.8 branch for seamonkey users. Trunk was ok. Thanks!

I meant to say I made a bad merge. Not my day today. 

Comment 7

[Scott MacGregor]

*** Bug 347094 has been marked as a duplicate of this bug. ***