346802 - session restore dialog thinks shutting down w32 is a "serious error"

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops. Bug 337390 neglected to realize that if a user shuts down Windows XP without first closing Firefox, they'll get the Session Restore bug when they next start up. That's not a "serious error". Patch coming up to change the string so it's less scary.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes to strings and entity names

Comment 2

[Reed Loden [:reed]]

Comment on attachment 231553 [details] [diff] [review]
changes to strings and entity names

Requesting a1.8.1. Just a string and entity name change.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 	1.4
mozilla/browser/components/sessionstore/src/nsSessionStartup.js 	1.9

Comment 4

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Created an attachment (id=231553) [edit]

> [...] if you think the problem was related to [...]

Isn't that still confusing?

And why doesn't Firefox store the data properly anyway? I think Windows is very generous when shutting down. Other applications have even time to ask the user whether he wants to save his data or not.

Comment 6

[Jesse Ruderman]

I filed  a new bug on the remaining confusion and arguably sub-optimal default behavior:

Bug 358667 - Session Store should not restore after a user-initiated OS shutdown.