347533 - [Mac] 3px vertical gap between native-theme tabs and horizontal bar after Pinstripe visual refresh

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Mark Mentovai]

Following the visual refresh, there is a 3px vertical gap between tabs drawn in the native appearance and the horizontal bar beneath the tabs from which the tabs are supposed to appear to protrude.  This is visible in the tab strips in Tools:Page Info, Firefox:Preferences:Advanced, and Firefox:Preferences:Advanced:Encryption:View Certificates.

Comment 1

[Mark Mentovai]

Attachment: Page Info window with a gap in its tab strip

Comment 2

[Kevin Gerich]

Tabs are also aligned to the left when they should be centered.

Comment 3

[Mark Mentovai]

Comment 2 regressed earlier on the road between 1.5 to 2.0 - I noticed when it happened, but forgot to file a bug.  Maybe it should be filed separately (unless it's already been filed)?

Comment 4

[Asaf Romano (gone)]

Please do file a bug and cc me (I bet this is a regression from ben's closebuttons patch).

Comment 5

[Mark Mentovai]

Filed bug 347797 for comments 2-5.

Comment 6

[Asaf Romano (gone)]

Attachment: restore old margin and padding for 'normal' tabs

I don't know why was this change done. Note it doens't affect tabbrowser (browser.css overrides both rules)

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 233345 [details] [diff] [review]
restore old margin and padding for 'normal' tabs

r+a=me (1.8 branch only at this point)

Comment 8

[Asaf Romano (gone)]

Checking in toolkit/themes/pinstripe/global/tabbox.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/tabbox.css,v  <--  tabbox.css
new revision: 1.2.26.3; previous revision: 1.2.26.2
done