347720 - Pad location/search bars like other toolbar elements

Status: RESOLVED DUPLICATE of bug 350742

(Firefox :: Toolbars and Customization, defect)

Description

[Ria Klaassen (not reading all bugmail)]

I think there should be a few pixels more space between Home (or any other icon) and the location bar.
I'll attach a screenshot.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: Screenshot of the problem

Comparison how it is and how it should be IMHO.

Comment 2

[Simon Howes]

What are they like when small?

In regards to bug https://bugzilla.mozilla.org/show_bug.cgi?id=347470

Comment 3

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #2)
> What are they like when small?
> 
> In regards to bug https://bugzilla.mozilla.org/show_bug.cgi?id=347470
>
Then it still needs two pixels more space I think.

Comment 4

[Jay Goldman]

Attachment: Adds an equal amount of space using -moz-margin-start.

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 351607 has been marked as a duplicate of this bug. ***

Comment 6

[Tim De Pauw]

(In reply to comment #1)
> Created an attachment (id=232517) [edit]
> Screenshot of the problem
> 
> Comparison how it is and how it should be IMHO.

While I agree that there should be more space--I filed the dupe--, I think this screenshot creates a new problem, namely the fact that there is a lot more space on the left of the URL bar than on the right.

Comment 7

[Ria Klaassen (not reading all bugmail)]

I did not give a solution, I just set #urlbar {margin-left: 5px !important;} for the screenshot. For me this would work (if I used that theme) but I have not yet studied other set-ups.

Comment 8

[Ria Klaassen (not reading all bugmail)]

Oh well, I see now that the right side does not need more margin, but also the left side of the searchbar has a similar problem.

Comment 9

[Tim De Pauw]

I guess, ideally, the individual toolbar components would be at a distance that is about the same size as the blank space before "File" in the menubar. But then again, that might make the whole thing a bit too ... spacious.

Comment 10

[Peter Kasting]

In theory, it seems like the location and search bars should both have left/right padding equal to the various buttons.  That will make everything space out properly no matter what order you put things in, and whether the theme is RTL.  Changing summary appropriately.

I don't think the current patch on this bug is the right thing to do.

CCing Myk as he's looked at the toolbar element padding lately.

Comment 11

[Peter Kasting]

Actually, I'm going to dupe this against later bug 350742, since that already has blocking-firefox2+.

*** This bug has been marked as a duplicate of 350742 ***

Comment 12

[Steffen Wilberg]

Comment on attachment 232858 [details] [diff] [review]
Adds an equal amount of space using -moz-margin-start.

Removing review request, since this bug has been fixed elsewhere.