347751 - go and search buttons are not native

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jonathan Haas]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060806 BonEcho/2.0b1

In the new winstripe theme, go and search buttons are not native, but simple graphics.

This causes some problems:
1. They do not scale with the urlbar/searchbar when large fonts are used
2. They look misplaced under the classic theme or some third party themes
3. They do not respect ative look and feel

Reproducible: Always

Steps to Reproduce:
1. Use large Fonts (For example 200 dpi)
or
1. Install a third party theme
or
1. Use the classic windows theme and use a dark or colorful color scheme
Actual Results:  
Go and search buttons do not scale with the urlbar and searchbar, do not look native, and look misplaced.

Expected Results:  
Buttons should "respect OS native look and feel" like desribed in http://wiki.mozilla.org/FX2_Visual_Update/Default_Theme_Update .

Comment 1

[Ria Klaassen (not reading all bugmail)]

It is amazing how many people still use the Windows Classic Style. 

Comment 2

[Simon Bünzli]

(In reply to comment #1)
> It is amazing how many people still use the Windows Classic Style. 

Considering that we still have users on non-XP Windows versions and that of the XP users especially power users also have a tendency to switch off Luna, we might well have 20 to 25% users using Classic styling (SWAG).

*** This bug has been marked as a duplicate of 347613 ***

Comment 3

[Jonathan Haas]

Why is this a duplicate? There are not only problems with the classic theme, there are problems, too, for example with large font sizes or third party themes (not classic).

If you mark this bug as duplicate please update Bug 347613 to reflect the other problems.

Comment 4

[Simon Bünzli]

Bug 347613 comment #4 summarizes most (if not all) of the issues you mention. If you feel that bug 347613 is essentially different from this, please REOPEN, otherwise feel free to add what you think is missing in the cited comment to bug 347613.

Comment 5

[Jonathan Haas]

I reopened this, because bug 347613 is only about the windows classic theme. These bugs are not the same, bug 347613 could be fixed for example by using an other graphic if the classic theme is detected. This would not help if large fonts or specific themes are used. Even your mentioned Bug 347613 comment #4 is only about the classic theme.

Will attach screenshots of other themes that cause problems.

Comment 6

[Jonathan Haas]

Attachment: Screenshots of some themes that cause problems

Comment 7

[Jay Goldman]

Attachment: Winstripe image replacements: transparent end cap buttons

These images replace the ones in the new theme, giving the 'endcaps' a transparent background so that they work better when the colour behind them changes. These images should replace the images in:

/mozilla/browser/themes/winstripe/global/icons/

This doesn't address any of the spacing or sizing problems, which are other bugs, but should fix situations in which the theme has changed the OS colours. It should also allow users to make changes in their userChrome.css and apply different background colours to these buttons or to the elements behind them.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 233494 [details]
Winstripe image replacements: transparent end cap buttons

These look great!

Comment 9

[Mike Connor [:mconnor]]

landed with the main window icon updates

Comment 10

[Peter Kasting]

Since this was landed on branch and didn't affect trunk, ->FIXED