348021 - de Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Deafult Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[Robert Kaiser]

The "-AT" is old cruft from xpfe-based suite times, it should really go away.
Firefox has been using "de" for ages :)

Comment 2

[chris hofmann]

using Build-identificering: Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.8.1b1) Gecko/2006081606 BonEcho/2.0b1

I'm noticing amazon search for "test" returns a query like 
http://www.amazon.co.uk/gp/search?search-alias=aps&field-keywords=test

anyone know if this has been fixed for next full builds?

Comment 3

[chris hofmann]

search using ebay also return this query http://search.ebay.com/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300
and english content.

http://wiki.mozilla.org/Firefox2/L10n_Requirements#Search_Plugins indicates an ebay search should query search.ebay.de

Comment 4

[Kadir Topal [:atopal]]

I checked in the changes 12 hours ago, the plugins should work in the latest build.

Comment 5

[Kadir Topal [:atopal]]

There was a problem with the yahoo plugin, searching in .com. I just changed that to .de. Apart from that the Google Suggestions are in english instead of german.

Comment 6

[chris hofmann]

Attachment: v1 de search box test

ok, here is v1 of the test for de builds.  

running the test I see the following problems.

wikipedia is missing the icon in the drop down list.

google search suggest for bier returns bbc, best buy, bank of america..., not german content.

yahoo search suggest for bier returns no search suggestions.

other-wise things look ok.

do we think "search suggests" are query problems, or server side?

can someone drum up a wikipedia branding icon for the search box?

Comment 7

[chris hofmann]

On a second try I did get google search suggest results...  

to recap:

On the first try "b" gave me "...bank of america...", 
but then maybe suggest queries for "bie" and "bier" timed out...????

but on another try I got bierstadt...

Comment 8

[Axel Hecht [:Pike]]

Attachment: convert from latin to utf-8

Abdulkadir, the wikipedia plugin has an encoding problem, too.

Comment 9

[chris hofmann]

I downloaded and installed 
Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2

that seems to have offical branding in the start page
http://www.google.com/firefox?client=firefox-a&rls=org.mozilla:de:official

but not in the search bar
http://www.google.com/search?q=bier&ie=utf-8&oe=utf-8&rls=org.mozilla:de:unofficial&client=firefox-a

or build config
Configure arguments
--enable-application=browser --enable-update-channel=nightly --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-update-packaging

build problem?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> Configure arguments
> --enable-application=browser --enable-update-channel=nightly --enable-optimize
> --disable-debug --disable-tests --enable-static --disable-shared --enable-svg
> --enable-canvas --enable-update-packaging
> 
> build problem?

Yes - that build does not have official branding enabled.

Comment 11

[Mike Schroepfer]

Chris - the beta2 builds have the following buildID:

Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

Comment 12

[Mike Schroepfer]

Bugzilla ate the rest of my comment.  Which was I tested the de build on Win/Mac (with 0821 buildID) and official branding is on in searchbox and homepage.  Downloaded from 

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2.0b2-candidates/rc2/

Buildconfig is as such:

--enable-application=browser --enable-update-channel=beta --enable-official-branding --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-update-packaging

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 235788 [details]
v1 de search box test

There are a few copy and paste errors in here, Amazon should use the german key, and AFAICT, we dropped the official release tag for yahoo (waiting for confirmation from Mic/Phil), and of course, ebay should search on ebay.de, not ebay.fr.

Comment 14

[Axel Hecht [:Pike]]

I'm pretty sure that schrep didn't mean to resolve this, too.

Comment 15

[chris hofmann]

Attachment: v2 with some corrections for the de locale

Comment 16

[Axel Hecht [:Pike]]

There is an XML parsing error in the wikipedia plugin, CCing Mic for sign-off.

Comment 17

[Mic Berman]

axel,
i'm unclear what i need to sign off on, it seems yahoo search suggest is enabled and working, wikipedia will be added but is currently experiencing a parsing error (to be fixed?), other issues?
thanks
mic

Comment 18

[chris hofmann]

here is what I see testing Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b2) Gecko/2006090703 BonEcho/2.0b2

Google
http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:de:unofficial&client=firefox-a
search suggests turned on and suggesting de content for a term like "hilfe" which lead to 
http://www.google.com/search?q=hilfen&ie=utf-8&oe=utf-8&rls=org.mozilla:de:unofficial&client=firefox-a

*** so google is ok with the exception of the "offical" code which should get turned on for final soon..

Yahoo
Yahoo is listed at the bottom of the search plugin dropdown.  
**** need to fix this.

http://de.search.yahoo.com/search?p=tele&ei=UTF-8&fr=moz2
search suggest is turned on with term "tele" getting telphon, telekom, and others

Wikipedy is listed second and points at
http://fy.wikipedia.org/w/index.php?title=Wiki:Search&search=test

Wikipedia (de) is listed 5th and points at
http://de.wikipedia.org/wiki/Test
*** wikipedia (de) doesn't have the assoiated wikipedia branding logo in the drop down.

Amazon.de points at
http://www.amazon.de/s/303-3594171-7766611?ie=UTF8&tag=firefox-de-21&index=blended&link%5Fcode=qs&field-keywords=test&sourceid=Mozilla-search

eBay points at
http://search.ebay.de/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300

Comment 19

[chris hofmann]

so from https://bugzilla.mozilla.org/show_bug.cgi?id=348021#c18 it appears that:

mic is done with branding/site contact help... all sites are approved.  if this is in error add the "needs-mic" status back to status whiteboard.

this bug is blocking on yahoo ship order, and maybe the wikipedia.de branding logo problem.    

is the wikipedia order between the de/fy sites the best for usability?  be nice to be sure on that, but most likely not a blocker.

we should try and get these problems cleaned up by end of day 9/12 if possible.

Comment 20

[chris hofmann]

some how that fy wikipedia plugin found its way to my testing profile.  (don't recall installing it..)  

when I removed it and restarted with a clean profile, all the order problems went away.  looks like we are in good shape with the exeption of the wikipedia.de branding logo...  be best to fix that to stay on the right side of any terms of service policies related to branding if they exist.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 235797 [details] [diff] [review]
convert from latin to utf-8

I checked this in, together with an additional <Image> so that this displays fine.

Comment 22

[Axel Hecht [:Pike]]

AFAICT, this bug can be closed, Abdulkadir?

Comment 23

[Kadir Topal [:atopal]]

Yes, as far as I can see, and thanks for taking my bugs, while I was stuck.

Comment 24

[Mike Schroepfer]

Should this also be marked fixed1.8.1?

Comment 25

[Tracy Walker [:tracy]]

verified with de 2.0rc1 build