Closed Bug 348100 Opened 19 years ago Closed 18 years ago

zh-TW Search Feature Tracking for Firefox 2

Categories

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

Product:
Mozilla Localizations
Component:
zh-TW / Chinese (Traditional)
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: chofmann, Assigned: Pike)

References

Details

(Keywords: verified1.8.1, Whiteboard: BD OK, 1.5 parity)

Attachments

(1 file)

zh-TW searchplugins update
7.96 KB, patch
Details | Diff | Splinter Review
tracking bug to make sure we get things on the list below working correctly for each locale: Full Default Search partner list/order. primary/secondary search selection behavior Search codes. Search Suggests enable/disable for locales where available or not
Blocks: fx20-zh-TW
just a note to make sure the yahoo code is correct fr=moz1 %IDENTIFIER% when Yahoo is in the #1 search position fr=moz2 %IDENTIFIER% when Yahoo is in the #2 search position
I had the answers.com problem on several tries, but now seems to be working.
Flags: blocking-firefox2?
Whiteboard: sever not found on Answer search → blocking yahoo fr=moz1 code
Flags: blocking-firefox2? → blocking-firefox2+
We shouldn't over-specify the ordering in region.properties, Yahoo first, Google second, that should do it. The further entries like browser.search.order.3=Amazon.com should be removed. (They don't work anyway.) Please don't ship google-zh-TW.xml but instead just reference the google.xml from the en-US directory. Nothing needs to be done for that apart adding 'google' to list.txt. You can cvs remove the google-zh-TW.xml file, as well as the amazondotcom.xml and creativecommons.xml. Traditional chinese did not have answers.com on 1.5, if you think that was a good choice, I don't see us requiring to keep it. If there's a better suggestion for a dictionary (wikipedia would be an easy pick), that'd be good to hear.
Assignee: nobody → josesun
QA Contact: nobody → josesun
Depends on: 351817
we need to make these corrections soon since the lockdown is coming for the first release candidates. josesun, do you have questions or comment on comment 4 ?
Whiteboard: blocking yahoo fr=moz1 code → blocking yahoo fr=moz1 code -1.5 parity
Yahoo has been fixed by bsmedberg, but google needs to be fixed.
Whiteboard: blocking yahoo fr=moz1 code -1.5 parity → blocking on google plugin - 1.5 parity
(In reply to comment #4) > We shouldn't over-specify the ordering in region.properties, Yahoo first, > Google second, that should do it. The further entries like > browser.search.order.3=Amazon.com should be removed. (They don't work anyway.) > > Please don't ship google-zh-TW.xml but instead just reference the google.xml > from the en-US directory. Nothing needs to be done for that apart adding > 'google' to list.txt. You can cvs remove the google-zh-TW.xml file, as well as > the amazondotcom.xml and creativecommons.xml. > > Traditional chinese did not have answers.com on 1.5, if you think that was a > good choice, I don't see us requiring to keep it. If there's a better > suggestion for a dictionary (wikipedia would be an easy pick), that'd be good > to hear. > I took a trip for few days..= = I removed browser.search.order.3=Amazon.com ,answers.com, mazondotcom.xml and creativecommons.xml. Added wikipedia-zh.xml. Thanks.
Status: NEW → ASSIGNED
The latest check-in busted stuff. None of the following plugins will be picked up from your locale: eBay google yahoo Both eBay and yahoo should be differently named, and make sure to resurrect the yahoo plugin that Benjamin did. google.xml can be cvs removed, just referencing 'google' from list.txt is enough for the build to pick up google.xml from en-US.
(In reply to comment #8) > The latest check-in busted stuff. > > None of the following plugins will be picked up from your locale: > > eBay > google > yahoo > > Both eBay and yahoo should be differently named, and make sure to resurrect the > yahoo plugin that Benjamin did. > google.xml can be cvs removed, just referencing 'google' from list.txt is > enough for the build to pick up google.xml from en-US. > But google.xml is different from en-US. zh-TW is search :http://www.google.com.tw/search but en-US is : http://www.google.com/search although "http://www.google.com/" can display Chinese, but only "http://www.google.com.tw/" can limit search results to Taiwan.
We have an request from google to only use google.com as entry point for the search. Usually, google uses geolocation to forward users in a country, having that language in their accept lang to the local google domain. That should work for Taiwan, too. That is, Taiwanese users searching from Taiwan should get to google.com.tw. If that's not the case, we'll need to confirm that with google, and may have to opt for a google-zh-TW.xml.
Shouldn't the yahoo plugin be using yahoo-fr-cjkt instead of yahoo-fr for the fr MozParam?
Note the latest: http://wiki.mozilla.org/Firefox2/L10n_Requirements#Yahoo.21 Says we should be matching FF15 - and using moz2 here
(In reply to comment #12) > Note the latest: > > http://wiki.mozilla.org/Firefox2/L10n_Requirements#Yahoo.21 > > Says we should be matching FF15 - and using moz2 here > Well...I don't know how to use moz2....Q.Q Can you paste .xml file directly? Thanks.
Taking. I'll clean up some of the technical stuff here for Jose directly in the repository.
Assignee: josesun → l10n
Status: ASSIGNED → NEW
I checked in what I think is the essence of the discussion here: amazondotcom creativecommons eBay-zh-TW google yahoo-zh-TW wikipedia-zh in list.txt, I revert yahoo to :bs' version, ebay should be tw, not cn, and removed the en-US copies. Patch for reference coming up. Jose, I think we should be fine. If the list above is wrong, please follow up in the bug here, otherwise I'll close this bug once my tool ran a verification in an hour or so. If that's happening before you comment, you can of course reopen the bug, too.
So, we have the creativecommons plugin still in addition to what we had in 1.5, though it's probably of little value to chinese users. Should we remove it? It's merely deleting that line from list.txt, I can do that quickly. Just want to know if Jose agrees.
Whiteboard: blocking on google plugin - 1.5 parity → BD OK, 1.5 parity
(In reply to comment #17) > So, we have the creativecommons plugin still in addition to what we had in 1.5, > though it's probably of little value to chinese users. > > Should we remove it? It's merely deleting that line from list.txt, I can do > that quickly. Just want to know if Jose agrees. > I think we should remove it. amazon.com and creativecommons plugins are not popular in Taiwan. Actually,most of peoples never use it. If someone need these plugins,they can add it manually. I found you revised directly in the repository, thank you so much.^^"
Status: NEW → ASSIGNED
Sorry, I was confused. We had both creative commons and amazon.com in 1.5, so let me reconsider this. Given how late we are, I'm closing this bug. We may re-evaluate the two for 2.0, with a little more time on our hands. Marking FIXED, please test all plugins on a nightly and a fresh profile and mark this bug VERIFIED if they work as expected. Note, bug 352781 will affect the yahoo search codes sent, still, but there is not change required in the localization anymore.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
verified on Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-TW; rv:1.8.1) Gecko/20060918 Firefox/2.0
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: