348335 - Tabstrip scroll arrows no longer look disabled when there's no where to scroll

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Asaf Romano (gone)]

At least in Pinstripe, the tabstirp scroll arrows no longer look disabled when there's no where to scroll. Even worse, they provide a hover feedback at this state.

Comment 1

[(not reading, please use [e-mail] instead)]

I see both issues on pinstripe.

similar theme changes are coming for winstripe, so it may end up being there too.

I'll be in this code working on related issues, so taking.

Comment 2

[Jay Goldman]

Seth - let me know if you need graphics for it.

Comment 3

[Asaf Romano (gone)]

I have a patch for this but I do need the images. Jay: could you also review the *enabled* arrow images? They look almost disabled right now (esp. the left arrow). Also note we're probably going to remove the hover style rules for the arrows.

Comment 4

[Asaf Romano (gone)]

Checking in browser/base/content/macBrowserOverlay.xul;
/cvsroot/mozilla/browser/base/content/macBrowserOverlay.xul,v  <--  macBrowserOverlay.xul
new revision: 1.10; previous revision: 1.9
done

Comment 5

[Asaf Romano (gone)]

oops, wrong bug.

Comment 6

[Jay Goldman]

Attachment: Pinstripe arrow image replacements

The icons are all 11 x 14 and are in the order on | hover | disabled | click.

- on/normal: 0, 11, 14, 0
- hover: 0, 22, 14, 11
- disabled: 0, 33, 14, 22
- click: 0, 44, 14, 33

Should be correct but please verify.

Comment 7

[Jay Goldman]

Attachment: Winstripe arrow image replacements

Uses the same dimensions and order as the pinstripe images (see previous comment).

Comment 8

[Asaf Romano (gone)]

Attachment: Pinstripe bits

Comment 9

[Asaf Romano (gone)]

Attachment: Winstripe bits

The RTL case is still isn't as pretty, but that's progress ;)

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 234568 [details] [diff] [review]
Pinstripe bits

r+a=me on this theme change

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 234894 [details] [diff] [review]
Winstripe bits

r+a=me on this theme change

As a note, we know the images still aren't going to be quite bright enough since opacity is in play, following up with Jay already to get those punched up.

Comment 12

[Asaf Romano (gone)]

Attachment: Updated pinstripe bits (checked in on branch)

mozilla/toolkit/themes/pinstripe/global/browser.css  1.7.4.16
mozilla/toolkit/themes/pinstripe/global/Attic/tab-arrow-end.png 1.1.2.2
mozilla/toolkit/themes/pinstripe/global/Attic/tab-arrow-start.png 1.1.2.2

Comment 13

[Asaf Romano (gone)]

Attachment: Updated Winstripe bits (checked in on branch)

mozilla/toolkit/themes/winstripe/global/browser.css 1.9.4.22
mozilla/toolkit/themes/winstripe/global/globalBindings.xml 1.3.24.2;
mozilla/toolkit/themes/winstripe/global/icons/Attic/tab-arrow-end.png 1.1.2.2
mozilla/toolkit/themes/winstripe/global/icons/Attic/tab-arrow-start.png 1.1.2.2

Comment 14

[Asaf Romano (gone)]

-> fixed. There are few bugs filed on replacing these images.