User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:126.96.36.199) Gecko/20060802 Firefox/188.8.131.52 Build Identifier: There are some XPCOM methods that accept an array and its size, e.g. nsIWebBrowserStream::appendToStream(). If the size parameter comes after the array, it is not initialized when the array size is being calculated. This causes invalid data being passed to the method. Reproducible: Always
Vladimir, if you want the patch to be reviewed, you need to set the review flags to it, probably firstname.lastname@example.org should review it (I'm not sure, though). Thanks for the patch.
Comment on attachment 233754 [details] [diff] [review] Patch I am currently taking a look at this and the other bugs opened by Vladimir.
Created attachment 240614 [details] [diff] [review] The same patch without indentation This patch does not change code indentation, so it is clearer.
Created attachment 263398 [details] [diff] [review] patch The problem was with methods in which the array size parameter came after the array parameter. This patch fixes it. Also handles sized strings, and handles an issue with byte arrays.
Checked in to trunk. -> FIXED
There was no review needed for this? Also, maybe this needs some automated tests?
The patch includes tests. They are run when 'make check' is called in the tests directory. Currently, I think the only tbox that does this for XULRunner, though, is FF-XR tbox in MozillaExperimental.
Created attachment 263614 [details] [diff] [review] dependency fix Check in caused a build break on the MozillaExperimental tbox. The dependencies for MozillaInterfaces.jar aren't set up correctly. This patch should fix it. Already checked in to trunk.
Comment on attachment 263398 [details] [diff] [review] patch Asking for 184.108.40.206 approval. This patch is XULRunner only. One of the files touched is in xpidl, but that bit of code (in xpidl_java) is only exercised when building XULRunner. This patch is necessary to fix the use of |nsIWebBrowserStream.appendStream()|, an issue that has been reported by several JavaXPCOM users.
Comment on attachment 263398 [details] [diff] [review] patch This is not something we're going to "slip in" if we need to respin our release candidates, so early next time.
Comment on attachment 263398 [details] [diff] [review] patch Who reviewed the xpidl change? I know it's small, but some ownerish person should still put their stamp on it. Looks like dougt, shaver or bsmedberg maybe.
Comment on attachment 263398 [details] [diff] [review] patch Would like a review on at least the xpidl changes.
Comment on attachment 263398 [details] [diff] [review] patch approved for 220.127.116.11, a=dveditz for release-drivers
Comment on attachment 263398 [details] [diff] [review] patch closing tree early, this will have to wait for next time
Can the original reporter please verify this fix with the 18.104.22.168 RC2 build of Firefox? If it cannot be verified with 22.214.171.124, can QA please be told of a way to verify the fix is present in our code?