348865 - [Mac] Livemark and container icons in bookmarks toolbar have a darker background when hovered or opened

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Mentovai]

After the visual refresh, the icons in bookmarks bar have a noticeably darker background than the rest of the button when a button is hovered or opened.

When favicons for items are added (bug 348719), this problem affects those bookmark buttons as well.

This is probably another opacity-matching problem.

Comment 1

[Mark Mentovai]

Attachment: 1.5 v. 2

1.5 hovering a livemark
2.0 hovering a livemark
1.5 opening a folder
2.0 opening a folder

These images were taken with favicons on regular bookmarks (bug 348719) but this bug occurs independently of that change.

Comment 2

[Wayne Woods]

Man, I never noticed that till you mentioned it, and now I see it all the time ;)

It looks like chrome://browser/skin/bookmark-hover-right.png is darker than chrome://browser/skin/bookmark-hover-left.png and bookmark-hover-mid.png (and the same with the bookmark-open-* images as well).

Comment 3

[Jay Goldman]

Attachment: Screenshot of livemark hover with new images

This is the livemark hover with the replacement images from <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=348837">348837</a>. I'm not seeing the darker background behind the icon anymore. Mark - can you grab the new graphics and give it a shot?

fwiw: there isn't any opacity in the CSS for the backgrounds on hover :)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** Bug 350222 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Connor [:mconnor]]

Jay, with the new images, I still see this when open, but hover is ok.

Comment 6

[Mike Connor [:mconnor]]

landed new hover images to fix 348837 and bug 348863.  this is halfway fixed now, looks like we need open images as well

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Indeed, we do! Maybe Pam has these images? I know that she did some stuff around this sometime. Or at least I think I know that.

Comment 8

[Pam Greene]

Attachment: Complete set of images

Okay, here's a full set of matching Mac bookmark images of the required width to fix both this and bug 343897, without regressing bug 348837 as far as I can tell.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 237204 [details]
Complete set of images

looks good, landed these with the rollup

Comment 10

[Wayne Woods]

(In reply to comment #9)
> (From update of attachment 237204 [details] [edit])
> looks good, landed these with the rollup

Mike, unless I'm jumping the gun, I think bookmark-open-right.png wasn't checked in.

Comment 11

[Phil Ringnalda (:philor)]

diff ./open-bookmark-right.png ~/Desktop/mac-bookmarks/open-bookmark-right.png says... no difference, so no commit. That one must have been the one that was already right, and the new -left and -mid now match it.

Comment 12

[Wayne Woods]

You're right, sorry. I thought that image had been modified further (for bug 348837), as well. I forgot that only the hover images were fixed, not the open ones. (So the open images still have the light bottom that makes them look a bit squashed... I did mention this back in bug 348837 comment 15, but I'm beginning to think everyone else is filtering me ;) )