348984 - 'All Tabs' Menu Button misaligned with tabs on the Tabstrip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1

The 'All Tabs' menu button seems to be misaligned with the tabs i.e. it seems to be lower than the tabs by 1 pixel or so. As a result, when hovered/clicked, the bottom of the 'All Tabs' button overflows beyond the tabstrip bottom border.

Reproducible: Always

Comment 1

[ronin.achilles]

Attachment: 'All Tabs' menu button misaligned with tabs

Comment 2

[Bryan]

I would also suggest that the chevron be "centered" over the scrollbar chevron if at all possible.  That would look much better.

~B

Comment 3

[Arpad Borsos [:Swatinem]]

Attachment: screenshot

This Screenshot shows the problem even better.

Comment 4

[Arpad Borsos [:Swatinem]]

I don't see this anymore with todays build.

Comment 5

[ronin.achilles]

(In reply to comment #4)
> I don't see this anymore with todays build.
> 

I still see this problem with 0818 build when there is 'No Overflow'. During overflow, the AllTabs menu along with the right scroll button align themselves to the tabs properly. 
Hence the problem still needs to be fixed when in 'no overflow' state. 

There are other problems with the AllTabs menu button when in overflow state though, as mentioned in the following bugs that I filed today:

https://bugzilla.mozilla.org/show_bug.cgi?id=349286
https://bugzilla.mozilla.org/show_bug.cgi?id=349287

Comment 6

[ronin.achilles]

Request to Block Fx2

Comment 7

[Darin Fisher]

Confirming.  I'm still seeing this in the 8/20 branch build.

Comment 8

[(not reading, please use [e-mail] instead)]

taking.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

While you're doing this, it's also misaligned in pinstripe ...

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 348950 has been marked as a duplicate of this bug. ***

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 234401 [details]
screenshot

this screen shot from arpad  has since been fixed (by michael wu.)  the other screen shot (and the original bug) is still valid.

Comment 12

[(not reading, please use [e-mail] instead)]

mac has a slightly different misalignment, but it is still misaligned.

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: mac all tabs misalignment

Comment 14

[(not reading, please use [e-mail] instead)]

changes to mozilla/toolkit on the MOZILLA_1_8_BRANCH on 8-26-06 have fixed the all tabs button alignment for winstripe.  (I'll attach a screen shot)

pinstripe still needs work.

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of winstripe all tabs (overflow and no overflow) after 8-26-06 changes

Comment 16

[(not reading, please use [e-mail] instead)]

part of the problem with pinstripe, unlike winstripe, is the tab images (http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/pinstripe/global/tab-left.png, tab-middle.png and tab-right.png) have a px transparent row at the top.  

the new images from jay (see bug #350139) do not have this problem, so I think this bug should be fixable by:

setting the height of the scrollbuttons and all tabs button elements to be the same height as the tabs (22px), an setting the margin-bottom to be the same as the tabs (3px).

Comment 17

[(not reading, please use [e-mail] instead)]

fixed with changes for bug #350139.