349038 - Text/favicon in active tab breaks out of tab itself

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alex R.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1

The tab boundary directly above the site favicon and title in the currently active tab appears to protrude a pixel out from the rest of the tab, including the close button. Note that it does not occur in any other tabs.

Screenshot:
http://img217.imageshack.us/img217/3402/tabprotrudeli6.png

Reproducible: Always

Steps to Reproduce:
1. Open several tabs.

Comment 1

[Alex R.]

As a note, it appears that the "broken-out" portion of the tab is the only part that is level with the other tabs in the strip. This would be consistent with the "broken" appearance of the line directly underneath the tab strip.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot

I can only reproduce that when I make giant letters.

Comment 3

[Ria Klaassen (not reading all bugmail)]

*** Bug 349041 has been marked as a duplicate of this bug. ***

Comment 4

[Alex R.]

That's odd - I'm on the XP default font size. I am, however, on a 1400 x 1050 monitor. Could that have any affect on the fonts?

Comment 5

[Ria Klaassen (not reading all bugmail)]

I have a 1024 x 768 screen. 
It should not happen in any case I think.

Comment 6

[Michael Wu [:mwu]]

This bug depends on your font size and dpi. Smaller fonts and lower dpis can make this problem go away. The problem is .tab-image-middle gets some extra margins and padding when selected, but the tab-image-left and tab-image-right and the close button do not. They need the same padding/margin adjustments as tab-image-middle.

Comment 7

[Peter Kasting]

Confirming, darin can reproduce at will on his machine.

Comment 8

[Michael Wu [:mwu]]

Attachment: Expand scope of select tab rules

Comment 9

[Michael Wu [:mwu]]

Comment on attachment 234328 [details] [diff] [review]
Expand scope of select tab rules

Crap, this doesn't do it.

Comment 10

[Michael Wu [:mwu]]

Comment on attachment 234328 [details] [diff] [review]
Expand scope of select tab rules

This helps a bit, but the image itself is a little too small.. it really can't handle big fonts.

Comment 11

[Phil Ringnalda (:philor)]

*** Bug 349089 has been marked as a duplicate of this bug. ***

Comment 12

[Dave Buco]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b2) Gecko/20060818 BonEcho/2.0b2 - Build ID: 2006081807

In my case (1024 x 768 screen), the threshold seems to be 99 - 100 DPI. At 99 DPI and below, the tab is fine. At 100 and above, the tab is as described in this bug.

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 234328 [details] [diff] [review]
Expand scope of select tab rules

looks reasonable, and michael demonstrated this fix (by varying his dpi).

assuming this doesn't cause any problems when asaf fixes the focus feedback bug (see #348959), r=sspitzer

seeking second review from mconnor

Comment 14

[(not reading, please use [e-mail] instead)]

michael:  what was the dpi pref you were changing when you demonstrated this patch for me?

(and, what values were you using?)

Comment 15

[Michael Wu [:mwu]]

(In reply to comment #14)
> michael:  what was the dpi pref you were changing when you demonstrated this
> patch for me?
> 
> (and, what values were you using?)
> 
layout.css.dpi was the pref I was using. I was using 96, 124 (actually -1 to read system settings), and 150. It also depends on your system font size settings.

Comment 16

[Mike Connor [:mconnor]]

Comment on attachment 234328 [details] [diff] [review]
Expand scope of select tab rules

looks good, r+a=me for this branch-only theme change

Comment 17

[Michael Wu [:mwu]]

Checking in toolkit/themes/winstripe/global/browser.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/browser.css,v  <--  browser.css
new revision: 1.9.4.17; previous revision: 1.9.4.16
done

Sorry for not putting the summary in the commit - I screwed up a middle click paste.