Status

()

defect
RESOLVED FIXED
13 years ago
6 years ago

People

(Reporter: zwnj, Assigned: Ehsan)

Tracking

(Blocks 1 bug, {fixed1.9.1, l12y, rtl})

Trunk
Firefox 3.6a1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

"About Firefox" dialog needs better RTL support.

I'm going to attach screenshots of current problems.
- "Powered by GeckoTM" has RTL direction.
- Copyright note has RTL direction and right align.
- Trademark and US EU notes are not localizable.
- US EU note is useless for non-US users.
Some pixels of first words of each line are out of drawing box.
Blocks: fx35-l10n-fa
No longer blocks: Persian-Fx3.5
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
I can reproduce the "Powered by GeckoTM" thing on Hebrew Firefox 3.1b2pre. The fastest solution would be to add LRM character to the string.
(In reply to comment #1)
> - "Powered by GeckoTM" has RTL direction.

This happens because the HTML container element is LTR, we need to fix this.

> - Copyright note has RTL direction and right align.

This does happen on trunk, which we need to fix.

> - Trademark and US EU notes are not localizable.

I think they are intentionally left English.  Is that right, Axel?

> - US EU note is useless for non-US users.

Axel should provide feedback here.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Target Milestone: Firefox 2 → ---
Version: 2.0 Branch → Trunk
Posted patch Patch (v1)Splinter Review
This is a trivial patch to make sure that all translatable text pieces appear RTL for RTL locales in credits.xhtml.
Attachment #355114 - Flags: review?(gavin.sharp)
No idea about the trademark piece. Harvey?
What determines whether an element should have a dir attribute set? I'm not sure I really understand why it's needed on some elements but not others, or why you can't just set it on the document body.
This page includes some English text, which is LTR, so if I set the dir on the body element, that text would also be made LTR.  (There is also some markup responsible of showing the graphics on that page, which I wasn't sure how it would turn up in RTL mode -- but I didn't test that).

In this patch, I have set the direction attribute only on the elements which have translatable link.  This way, only those elements which are actually translated will get the RTL direction for RTL locales.
Attachment #355114 - Flags: review?(gavin.sharp) → review+
Posted patch Checked inSplinter Review
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/2723c17e5502
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-litmus?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Attachment #356667 - Attachment description: For check-in → Checked in
Attachment #356667 - Flags: approval1.9.1?
Comment on attachment 356667 [details] [diff] [review]
Checked in

a191=beltzner
Attachment #356667 - Flags: approval1.9.1? → approval1.9.1+
No longer blocks: fx35-l10n-fa
Attachment #356667 - Flags: review?(ehsan.akhgari)
Attachment #356667 - Flags: review?(ehsan.akhgari)
Attachment #356667 - Flags: review?(ehsan.akhgari)
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.