349176 - [RTL] About Firefox

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Behnam Esfahbod [:zwnj]]

"About Firefox" dialog needs better RTL support.

I'm going to attach screenshots of current problems.

Comment 1

[Behnam Esfahbod [:zwnj]]

Attachment: About Firefox [fa-IR]

- "Powered by GeckoTM" has RTL direction.
- Copyright note has RTL direction and right align.
- Trademark and US EU notes are not localizable.
- US EU note is useless for non-US users.

Comment 2

[Behnam Esfahbod [:zwnj]]

Attachment: About Firefox [fa-IR] - Main layout

Some pixels of first words of each line are out of drawing box.

Comment 3

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).

Comment 4

[Tomer Cohen :tomer]

I can reproduce the "Powered by GeckoTM" thing on Hebrew Firefox 3.1b2pre. The fastest solution would be to add LRM character to the string.

Comment 5

[(no longer active)]

(In reply to comment #1)
> - "Powered by GeckoTM" has RTL direction.

This happens because the HTML container element is LTR, we need to fix this.

> - Copyright note has RTL direction and right align.

This does happen on trunk, which we need to fix.

> - Trademark and US EU notes are not localizable.

I think they are intentionally left English.  Is that right, Axel?

> - US EU note is useless for non-US users.

Axel should provide feedback here.

Comment 6

[(no longer active)]

Attachment: Patch (v1)

This is a trivial patch to make sure that all translatable text pieces appear RTL for RTL locales in credits.xhtml.

Comment 7

[Axel Hecht [:Pike]]

No idea about the trademark piece. Harvey?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

What determines whether an element should have a dir attribute set? I'm not sure I really understand why it's needed on some elements but not others, or why you can't just set it on the document body.

Comment 9

[(no longer active)]

This page includes some English text, which is LTR, so if I set the dir on the body element, that text would also be made LTR.  (There is also some markup responsible of showing the graphics on that page, which I wasn't sure how it would turn up in RTL mode -- but I didn't test that).

In this patch, I have set the direction attribute only on the elements which have translatable link.  This way, only those elements which are actually translated will get the RTL direction for RTL locales.

Comment 10

[(no longer active)]

Attachment: Checked in

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2723c17e5502

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356667 [details] [diff] [review]
Checked in

a191=beltzner

Comment 13

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6ae473aca441