349297 - [reflow branch] Horizontal scrollbar on hetfotoalbum.nl

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, I get a horizontal scrollbar on hetfotoalbum, which I don't get with the normal builds.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Do you still see this?  I don't.

Comment 3

[Martijn Wargers (dead)]

I'm still seeing this bug with current reflow branch build.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see it now.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And today I don't see it...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, I see it at some window widths but not others.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The problem here is the RoundToPixel call in BasicTableLayoutStrategy::ComputeColumnWidths, which always rounds up.  It's not clear to me when the old code rounded, or why, but I suppose I should probably just remove the rounding.  At least once I have a clean enough tree to do that.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

So I no longer see the bug at all, with or without this patch.

I wrote this patch a few weeks ago, and I'm not sure if it helped at the time, but it didn't fix it completely.

However, I think we do want this patch -- I think it will fix some reftest failures that we currently see at some values of p2t (which I currently see when running them on Mac, on some of the tests for 18217, where an inline-table ends up with an extra pixel of space at the end relative to an inline), and I don't see any reason that tables should round differently from the rest of the code.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Merged with bug 177805.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2007-02-08 11:20 -0800.

If this didn't fix it, then the combination with bug 369318 really should have.

Comment 11

[Martijn Wargers (dead)]

Yes, it is fixed now, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070209 Minefield/3.0a3pre