369318 - 3 inline-table reftests fail on mac due to pixel rounding

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Three of the inline-table reftests fail on Mac, which has sub-pixel positioning and sizing of text.  The problem is that the text following the inline-table in tests bugs/18217-basic-2a.html, bugs/18217-basic-2b.html, and bugs/18217-valign-1.html is slightly too far from the inline-table.

The problematic part of the frame dump shows that the "bcd" text is 347 twips wide, but the table cell's inner block sizes to 360 twips around it.

I'd thought bug 349297 would fix this, but it doesn't seem to be sufficient.  I think an additional patch is needed.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Bernd]

David is this equivalent to not pixel round inside the BasicTableLayoutStrategy?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes.  I want to get rid of the pixel rounding.  I don't see any good reason for it, and it's harmful in cases where platforms can do subpixel rendering or where we're doing things like zooming.

Comment 4

[Bernd]

Comment on attachment 253997 [details] [diff] [review]
patch

I only remember that OS2 was keen to get the pixel rounding that might not be an issue anymore given the transition to cairo.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Merged with bug 177805.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2007-02-08 11:21 -0800.

Comment 7

[Jeff Walden [:Waldo]]

Already tested by the failing tests.