349574 - no "Get themes" or "Get Extensions" link

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Worcester12345]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7pre) Gecko/20060821 Firefox/1.5.0.7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060821 Thunderbird/2.0a1 ID:2006082107

No way to find new themes. I had to go out of Thunderbird, and run it in Firefox, then type over the word firefox with thunderbird in the url and hit enter to get to the right place. THEN, I had to find a compatible one and download it to desktop, THEN I could finally install it.

This is too convoluted, and non-intuitive. 

Of course, the reason for doing this is because the new default theme is too faint to discern when there is email in a folder (the little orange sun thing). I have for years now kept the standard, stock theme, but this one is not very good at all.  The new Firefox 2.0 theme stinks too, for that matter. You can't tell which tab is in foreground and which is in background. What are you mozilla people thinking when you choose these things to be so the features all look similar?

Reproducible: Always

Steps to Reproduce:
1.try to get a theme
2.have a tough time of it
3.

Actual Results:  
Have to dig and dig around to get a theme and install it.

Expected Results:  
Should be easier. Even the 1.5.0.x method was a LITTLE BIT easier than this.

No additional information.

Comment 1

[Mike Cowperthwaite]

Tools | Add Ons | Themes   doesn't do what you want?

Comment 2

[Worcester12345]

(In reply to comment #1)
> Tools | Add Ons | Themes   doesn't do what you want?
> 

There is no way to bring up the themes home page from there that I can see.

Comment 3

[Mike Cowperthwaite]

I'm sorry, you're correct.  In 2a1, I see the expected link in the 0817 build but it's gone with the 0821 build (which is the first 2a1 build I have with the new theme).

Comment 4

[Scott MacGregor]

Hey Rob, did the get theme / get more add-on links intentionally go away in the extension manager?

Comment 5

[Robert Strong (they/them - no direct email)]

It was changed in Bug 348076 and it appears that followup bugs were never filed for Thunderbird or Sunbird. :(

Comment 6

[Dietrich Ayala (:dietrich)]

(In reply to comment #5)
> It was changed in Bug 348076 and it appears that followup bugs were never filed
> for Thunderbird or Sunbird. :(
> 

It's not that followup bugs weren't filed. I thought I'd found a solution for bug 348076 that left those links intact for all the other apps. However, that was obviously not the case. I'm looking into it now.

Comment 7

[Scott MacGregor]

Attachment: part of the fix

This packages the new files that were added to toolkit but weren't added to the Thunderbird packaging manifests.

It also changes the get more extension and theme URLs to use the new formatting code.

Although this patch doesn't fix the problem for me yet. I keep getting an error when I open add-ons about the declared interfaceinfo not being found for the new formatting service even though urlformatter.xpt is in dist\bin\components for me. And so is the formatter JS component. Very strange.

Comment 8

[Scott MacGregor]

I think I understand why this is still broken even though I've made the packaging changes to include the new toolkit component.

nsIURLFormatter.idl in toolkit references an interface called nsIDictionary in xml-rpc which is an optional extension not built by all of the mozilla products. In particular, Thunderbird does not build xml-rpc.

It's not clear to me why the url formatter in toolkit should depend on xml-rpc? 

Comment 9

[Worcester12345]

(In reply to comment #8)
> I think I understand why this is still broken even though I've made the
> packaging changes to include the new toolkit component.
> 
> nsIURLFormatter.idl in toolkit references an interface called nsIDictionary in
> xml-rpc which is an optional extension not built by all of the mozilla
> products. In particular, Thunderbird does not build xml-rpc.
> 
> It's not clear to me why the url formatter in toolkit should depend on xml-rpc? 
> 

See Bugzilla Bug 350123 Update URLFormatter to work with non-Fx apps

Comment 10

[Rob Marshall [tH]]

*** Bug 351368 has been marked as a duplicate of this bug. ***

Comment 11

[Tracy Walker [:tracy]]

updating summary to catch searches for the Get extension link.

Comment 12

[Worcester12345]

Seems to be working for me now in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060912 Thunderbird/2.0a1 ID:2006091203

Comment 13

[Dietrich Ayala (:dietrich)]

(In reply to comment #12)
> Seems to be working for me now in Mozilla/5.0 (Windows; U; Windows NT 5.1;
> en-US; rv:1.8.1b2) Gecko/20060912 Thunderbird/2.0a1 ID:2006091203
> 

Yes, the checkin of bug 350123, plus Scott's patch, should have fixed this. Scott, did the patch attached to this bug get checked in already? (it's not noted here..)

Comment 14

[Scott MacGregor]

Yeah this is now fixed thanks to the great work in Bug 350123 and this patch which  got checked in on 8/20.

Comment 15

[Steffen Wilberg]

Reducing the summary to what was fixed here (no "Get themes" or "Get Extensions" link).

Comment 16

[Carsten Book [:Tomcat]]

verified fixed for 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620

Get themes, Get Extensions is now in the Extension Manager