350225 - Keyboard shortcut for switching tabs (cmd + digit) no longer works

Status: RESOLVED DUPLICATE of bug 355817

(Core :: Widget: Cocoa, defect)

Description

[Robin Whittleton]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060825 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060825 Minefield/3.0a1

I used to be able to select a tab by holding cmd and pressing 1,2,3 etc. For the past couple of weeks this hasn't worked.

Reproducible: Always

Steps to Reproduce:
1. Load multiple tabs
2. Hold cmd and press 2 to switch to the second one.

Actual Results:  
A beep.

Expected Results:  
Switched to the second tab and not beeped.

Comment 1

[Mats Palmgren (inactive)]

It works fine for me in Minefield 20060826 on MacOSX.

If you load about:config and then type ui.key in the Filter text field;
do you have all those settings at "default"?

Comment 2

[philippe (part-time)]

Works fine with the 'standard' Minefield build.
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060826 Minefield/3.0a1 ID:2006082620

Fails with the equivalent Cocoa Firefox Minefield builds 
(from: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/cocoa/latest-trunk/)

Comment 3

[Robin Whittleton]

Oh, sorry :( Should have mentioned that this is with --enable-default-toolkit=cocoa. I'm using Simon's builds ( http://forums.mozillazine.org/viewtopic.php?t=444052 ).

Comment 4

[Mats Palmgren (inactive)]

You did not answer my question in comment 1.
Additional question: you should have two preferences named
"ui.key.contentAccess" and "ui.key.chromeAccess" in the list - do you?

Comment 5

[Robin Whittleton]

Sorry mats. They're all set to 'default', full values are:

ui.key.accelKey              224
ui.key.chromeAccess          2
ui.key.contentAccess         2
ui.key.generalAccessKey      -1
ui.key.menuAccessKey         0
ui.key.menuAccessKeyFocuses  false
ui.key.saveLink.shift        false

Comment 6

[Mats Palmgren (inactive)]

Thanks, those are the correct default values, the same values as I have and
Cmd+digit works for me.

I'm guessing this is a regression from bug 340902. Maybe we missed a file
that is not normally checked out unless you build a Cocoa build?
Looking at the files that that bug changes should help pin-pointing the file
that needs to be fixed. FYI, there is also bug 345902, but that hasn't
been checked in yet.

Comment 7

[Mats Palmgren (inactive)]

It would help a lot if we knew the exact date when this broke -- if there
are older builds available could you check please?  Thanks.

Comment 8

[philippe (part-time)]

(In reply to comment #7)
> It would help a lot if we knew the exact date when this broke -- if there
> are older builds available could you check please?  Thanks.
> 

The oldest 'Cocoa Fox' build I have is dated 20060807, and those keyboard shortcuts are not working.
I suspect it has always been that way. There are more keyboard shortcuts that are non-functional on those Cocoa Fox builds (e.g. bug 346955).
I'll add Josh to the CC, he probably knows more about this.

Comment 9

[Simon Bünzli]

(In reply to comment #6)
> I'm guessing this is a regression from bug 340902.

I don't see how bug 340902 could be responsible for this issue, since this is no _access_ key issue but rather an _accel_ key one (c.f. bug 345902).

Comment 10

[Mats Palmgren (inactive)]

*** Bug 362606 has been marked as a duplicate of this bug. ***

Comment 11

[Josh Aas]

Fixed by 355817.

*** This bug has been marked as a duplicate of 355817 ***