35118 - Sig delimiter malformed for format=flowed

Status: VERIFIED FIXED

(Core :: DOM: Serializers, defect, P3)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Send a flowed mail with a signature with Mozilla
2. View it in View source

Actual result:
The sig delimiter is "--"

Expected result:
The sig delimiter is "-- "

Additional Comments:
This is a violation of both RFC2646 4.3 and son-of-1036.

Comment 1

[Daniel Bratell]

Is the sig separator logically marked in any way? Otherwise it will be some work 
checking newlines and such.

Comment 2

[Ben Bucksch (:BenB)]

Daniel, it wasn't your bug. In pre's you don't strip trailing spaces (is that
correct?); and my sig is plain text and thus in a pre.

The bug here was, that "-- " was never inserted in the first place, but "--".
Per Daniel's request (which is a good idea in general, I think), I'm wrapping
sigs (both plain text and HTML) in a <div class=signature>. I'll attach a patch.

Comment 3

[Ben Bucksch (:BenB)]

Well, if the sig is HTML, we have the described problem, even if "-- " was
inserted (now bug 35158): The delimiter is not in a pre and the flowed code
strips the last space.

Comment 4

[Ben Bucksch (:BenB)]

recreate old state

Comment 5

[Daniel Bratell]

I've fixed this, at least when the advanced composition windows is used to make 
a format=flowed mail. I will attach the patch along with a new test.

Akkana, could cou review and check it in? It's a quite trivial fix. Just 
checking if the current line to output is "-- " while stripping ending white 
space and in that case stop stripping. Only when we're outputting format=flowed 
though. That was the best solution I could think of right now, but if you think 
that we should do this for all formatted output, just tell me and it's easy to 
fix.

The test I added is a simple format=flowed mail with a sig delimiter and lines 
that should be space stuffed.  I will attach the simplemail.html and 
simplemail.out. The normal problems with end-of-line conversions apply. I will 
try to add them with a application/octet-stream mime type and see what that 
does.

Comment 6

[Daniel Bratell]

Attachment: The fix along with test additions

Comment 7

[Daniel Bratell]

Attachment: simplemail.html - the source file for the new test

Comment 8

[Daniel Bratell]

Attachment: simplemail.out - the "correct" output from simplemail.html

Comment 9

[Daniel Bratell]

Setting milestone to M16.

Comment 10

[Daniel Bratell]

A side effect is that "--  " and "--   " and "--    " and "--      " and (I 
think you get my point :-) ) so on, also are output as "-- ".

Comment 11

[Akkana Peck]

Looks fine -- I've checked it in, along with Makefile additions to export the
new test files.  Go ahead and mark this fixed. 

Comment 12

[Daniel Bratell]

Fixed

Comment 13

[scottputterman]

*** Bug 40264 has been marked as a duplicate of this bug. ***

Comment 14

[sujay]

verified in 6/12 build.