351969 - nsImageDocument image scaling should never scale a dimension to 0px

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

A 5000x1 pixel image becomes invisible.  nsImageDocument should not scale either dimension to less than 1 px.  The aspect ratio stretching is fine, because the user won't be able to tell the image contents are stretched when they're jammed into 1 pixel.

Comment 1

[Phil Ringnalda (:philor)]

*** Bug 316376 has been marked as a duplicate of this bug. ***

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

The aspect ratio is incorrect when the smaller dimension is being capped at 1px, but that isn't a problem because you can't actually see anything.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Please ask someone else for review.  I won't be able to get to this any time soon (like in 2006).

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 243140 [details] [diff] [review]
patch

sr=jst

Comment 5

[Eli Friedman]

Small nit: I think you mean NSToIntFloor, not NSToCoordFloor; image widths and heights are in pixels, and NSToCoord* is only supposed to be used with twips/app units. There is no difference at the moment, but that's not guaranteed to remain the case.

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

*** Bug 190551 has been marked as a duplicate of this bug. ***