352168 - Thunderbird trunk l10n tinderboxens burn

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Axel Hecht [:Pike]]

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n has the l10n tinderboxens burning on all three platforms.

Something is odd with the the distclean target in mail/extensions/newsblog, it seems.

make[4]: Entering directory `/cygdrive/c/builds/tinderbox/Tb-Trunk-l10n/WINNT_5.2_Clobber/mozilla/mail/extensions/newsblog'
/cygdrive/c/builds/tinderbox/Tb-Trunk-l10n/WINNT_5.2_Clobber/mozilla/config/rules.mk:812: *** Insufficient number of arguments (1) to function `addprefix'.  Stop.
make[4]: Leaving directory `/cygdrive/c/builds/tinderbox/Tb-Trunk-l10n/WINNT_5.2_Clobber/mozilla/mail/extensions/newsblog'
make[3]: *** [distclean] Error 2

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

In a related question, if all three tinderbox are initially clobbering, why are they then calling "make distclean" after the two standard configure's ?

Comment 2

[Scott MacGregor]

Could this be part of the problem?

http://lxr.mozilla.org/mozilla/source/mail/extensions/newsblog/Makefile.in#51

Where does EXPORT_L10N get defined? That could be causing addprefix to fail.

Comment 3

[Scott MacGregor]

I think this was caused by Bug 301945. EXPORT_L10N should be EXPORT_L10N_DIR I think.

Comment 4

[Axel Hecht [:Pike]]

yessir, I think so, too.

Comment 5

[Adam Guthrie]

Attachment: Use EXPORT_DIR_L10N since it's actually defined

Comment 6

[Scott MacGregor]

Comment on attachment 239368 [details] [diff] [review]
Use EXPORT_DIR_L10N since it's actually defined

benjamin's away I believe, so I'll r and sr this small change.

Comment 7

[Adam Guthrie]

Thanks, Scott. If you could check this in, that would be great.

Comment 8

[Adam Guthrie]

So, my patch still needs to go in, but it looks like something else might've fixed this. 

Things seem to have stopped burning around morning time on 2006-09-11. Checkins: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-09-11+09%3A20&maxdate=2006-09-11+10%3A15&cvsroot=%2Fcvsroot

Could the patch for bug 352173 have fixed this, or did Axel check in a fix locally to all these tinderboxes?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

"fixed" would be saying too much, but that patch did make make ignore errors during "make clean" and similar targets.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/extensions/newsblog/Makefile.in 	1.9