301945 - Account Wizard won't offer to create new RSS or Movemail accounts

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[walter sheets]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050724 Firefox/1.0+

Thunderbird(HEAD/20050724): this bug shows only when I run the program from
it's *installed* location (/usr/local/bin/thunderbird).  When I run it as
obj/dist/bin/thunderbird, then the Account Wizard offers all four types of
new accounts -- weird!

Reproducible: Always

Steps to Reproduce:
1.Compile and install with 'make -f client.mk install'
2.Run TB from /usr/local/bin/thunderbird
3.Try adding an RSS account from the Account Wizard -- you can't.
4.Run TB from obj/dist/bin/thunderbird -- and it works normally.
Actual Results:  
Account Wizard offers only 'Newsgroups' and 'Email' accounts.  RSS and
Movemail accounts are not mentioned.

Expected Results:  
Account Wizard should offer all types of accounts.

My gut feeling is that the 'make install' target is broken for the Account
Wizard -- but I don't know which Makefiles are involved.

Comment 1

[Pontus Freyhult]

I noticed the same issue. The issue seems to be that defaults/isp is not
properly installed.

Comment 2

[walter sheets]

I believe there should be an 'install' target added to
mail/extensions/newsblog/Makefile.in

Comment 3

[walter sheets]

Attachment: Fixes the RSS omission

This fixes the RSS omission.

Comment 4

[walter sheets]

Attachment: And this fixes the movemail omission.

I don't understand why the same files are installed in both the 'isp'
directory and in the 'isp/US' directory.

If this is really necessary then a second line needs to be added to the
'install' targets to add the isp/US subdirectory.

Comment 5

[Benjamin Smedberg]

Comment on attachment 191070 [details] [diff] [review]
And this fixes the movemail omission.

Why would you $(addprefix $(srcdir)/, movemail.rdf)? 

Just use $(srcdir)/movemail.rdf.

And please attach patches with more context (8 or 12 is generall what I
prefer).

Comment 6

[Benjamin Smedberg]

Comment on attachment 191068 [details] [diff] [review]
Fixes the RSS omission

again, only use $(addprefix) when you have a list of items instead of a single
item.

Comment 7

[walter sheets]

(In reply to comment #6)
> again, only use $(addprefix) when you have a list of items instead of a single
> item.

I copied it from a similar Makefile with two items -- in fact I'm still wondering
if a second copy should be placed in the l10n subdirectory.  I don't understand
why it is necessary.  (Is it?)

Comment 8

[Scott MacGregor]

this bug is in danger of being cut from the blocker list.

Comment 9

[Scott MacGregor]

Minusing for now. Will consider a safe patch but not a blocker.

In the linux builds we make, folks have seen the option for creating rss
accounts and what not, so it's working in our release builds. 

Comment 10

[Pontus Freyhult]

Attachment: Another go at fixing the rss submission.

Comment 11

[Pontus Freyhult]

Attachment: and the movemail submission.

Comment 12

[Pontus Freyhult]

The release builds have the appropiate files, so they should work allright, this
should only be a problem for those who build from source.

Comment 13

[Adam Guthrie]

*** Bug 328512 has been marked as a duplicate of this bug. ***

Comment 14

[Adam Guthrie]

Attachment: patch

This is a first stab at getting this fixed. This is heavily borrowed from mailnews/base/ispdata/Makefile.in.

Comment 15

[Adam Guthrie]

Note that the movemail issue was covered in bug 281084.

Comment 16

[Scott MacGregor]

Comment on attachment 230828 [details] [diff] [review]
patch

nice work adam!

Comment 17

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/extensions/newsblog/Makefile.in 	1.8

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Checked in, with the bustage fix from bug 352168.
mozilla/mail/extensions/newsblog/Makefile.in 	1.7.4.1