352321 - need alltabs background images that match new background tab images

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

need alltabs background images that match new background tab images

due to bug #352315, all four versions of the background images for the
alltabs button need to be replaced.  these images should match with a
non-hovered tab (from tomorrow's build.)

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

note, this is important for high-contrast mode so that you can see the all tabs button.

the current non-hovered version of this image is invisible (when in high contrast mode).

Comment 3

[Dão Gottwald [:dao]]

Attachment: alltabs-box-start-bkgnd.png

Comment 4

[Dão Gottwald [:dao]]

Attachment: alltabs-box-end-bkgnd.png

Comment 5

[Dão Gottwald [:dao]]

Attachment: alltabs-box-overflow-start-bkgnd.png

Comment 6

[Dão Gottwald [:dao]]

Attachment: alltabs-box-overflow-end-bkgnd.png

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #0)
> need alltabs background images that match new background tab images

note: it still won't match exactly because the alltabs button doesn't use -moz-dialog, I think.

Comment 8

[Peter Kasting]

(In reply to comment #7)
> note: it still won't match exactly because the alltabs button doesn't use
> -moz-dialog, I think.

Seth, can you fix that in whatever patch you checkin?  We should put -moz-dialog behind all the tab strip buttons so they appear to have the same colors.

Comment 9

[(not reading, please use [e-mail] instead)]

> Seth, can you fix that in whatever patch you checkin?  We should put
> -moz-dialog behind all the tab strip buttons so they appear to have the same
> colors.

yes, I'll take care of this.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 237964 [details]
alltabs-box-overflow-end-bkgnd.png

seeking approval for all four images for the branch.

Comment 11

[(not reading, please use [e-mail] instead)]

note, in high contrast mode, the drop marker is not very visible, see bug #352479 on that issue.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: new images in action

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: new images in action (high contrast)

Comment 14

[Dão Gottwald [:dao]]

(In reply to comment #12)
> Created an attachment (id=238164) [edit]
> new images in action

I wonder why they are still darker than the tab.

Comment 15

[(not reading, please use [e-mail] instead)]

> I wonder why they are still darker than the tab.

I need some css to set the background-color to be -moz-dialog (and also to round out the corners)

some css coming...

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: patch, use -moz-dialog as bg color for left, right, alltabs (which means I need -moz-border-radius* rules)

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: new images in action + css changes

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: new images in action + css changes (high contrast)

Comment 19

[Dão Gottwald [:dao]]

(In reply to comment #17)
> Created an attachment (id=238171) [edit]
> new images in action + css changes

Now I think I prefer attachment 238164 [details] ...

Comment 20

[Mike Connor [:mconnor]]

Comment on attachment 238168 [details]
patch, use -moz-dialog as bg color for left, right, alltabs (which means I need -moz-border-radius* rules)

whee!

Comment 21

[(not reading, please use [e-mail] instead)]

fix landed on the branch.

>> Seth, can you fix that in whatever patch you checkin?  We should put
>> -moz-dialog behind all the tab strip buttons so they appear to have the same
>> colors.
>
>yes, I'll take care of this.

note, I took care of that for the scroll left, scroll right, and all tabs buttons.

Comment 22

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381