need alltabs background images that match new background tab images

RESOLVED FIXED in Firefox 2

Status

()

defect
RESOLVED FIXED
13 years ago
2 months ago

People

(Reporter: moco, Assigned: moco)

Tracking

({access, fixed1.8.1})

2.0 Branch
Firefox 2
x86
Windows XP
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx2 theme change])

Attachments

(8 attachments, 2 obsolete attachments)

need alltabs background images that match new background tab images

due to bug #352315, all four versions of the background images for the
alltabs button need to be replaced.  these images should match with a
non-hovered tab (from tomorrow's build.)
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
note, this is important for high-contrast mode so that you can see the all tabs button.

the current non-hovered version of this image is invisible (when in high contrast mode).
Keywords: access, sec508
(In reply to comment #0)
> need alltabs background images that match new background tab images

note: it still won't match exactly because the alltabs button doesn't use -moz-dialog, I think.
Blocks: NewTheme
Whiteboard: [Fx2 theme change]
(In reply to comment #7)
> note: it still won't match exactly because the alltabs button doesn't use
> -moz-dialog, I think.

Seth, can you fix that in whatever patch you checkin?  We should put -moz-dialog behind all the tab strip buttons so they appear to have the same colors.
> Seth, can you fix that in whatever patch you checkin?  We should put
> -moz-dialog behind all the tab strip buttons so they appear to have the same
> colors.

yes, I'll take care of this.
Flags: blocking-firefox2? → blocking-firefox2+
Attachment #237960 - Flags: review? → review+
Attachment #237961 - Flags: review? → review+
Attachment #237962 - Flags: review? → review+
Attachment #237964 - Flags: review? → review+
Comment on attachment 237964 [details]
alltabs-box-overflow-end-bkgnd.png

seeking approval for all four images for the branch.
Attachment #237964 - Flags: approval1.8.1?
note, in high contrast mode, the drop marker is not very visible, see bug #352479 on that issue.
Blocks: 352479
(In reply to comment #12)
> Created an attachment (id=238164) [edit]
> new images in action

I wonder why they are still darker than the tab.
> I wonder why they are still darker than the tab.

I need some css to set the background-color to be -moz-dialog (and also to round out the corners)

some css coming...
Attachment #237964 - Flags: approval1.8.1?
Attachment #238168 - Flags: review?(mconnor)
Attachment #238168 - Flags: review?
Attachment #238168 - Flags: approval1.8.1?
Whiteboard: [Fx2 theme change] → [Fx2 theme change][fix in hand, seeing r/a=mconnor]
(In reply to comment #17)
> Created an attachment (id=238171) [edit]
> new images in action + css changes

Now I think I prefer attachment 238164 [details] ...
Comment on attachment 238168 [details]
patch, use -moz-dialog as bg color for left, right, alltabs (which means I need -moz-border-radius* rules)

whee!
Attachment #238168 - Flags: review?(mconnor)
Attachment #238168 - Flags: review+
Attachment #238168 - Flags: approval1.8.1?
Attachment #238168 - Flags: approval1.8.1+
fix landed on the branch.

>> Seth, can you fix that in whatever patch you checkin?  We should put
>> -moz-dialog behind all the tab strip buttons so they appear to have the same
>> colors.
>
>yes, I'll take care of this.

note, I took care of that for the scroll left, scroll right, and all tabs buttons.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][fix in hand, seeing r/a=mconnor] → [Fx2 theme change]
You need to log in before you can comment on or make changes to this bug.