351775 - left, right, all tab button images should be semi-transparent so that they work with the OS theme and high contrast mode

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

left, right, all tab button images should be semi-transparent so that they work with the OS theme and high contrast mode

this is the other half of bug #350690

there are a couple bugs requesting new images for these elements, but this tracks the issue that they need to work properly in high contrast mode and with the os theme.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Seth, I've been duping these against bug 350687 as you note. I'll mark this one as blocking+, I guess, per your rationale, but I think we want to make sure that Jay sees this requirement at the time he's making the new images. I'll point it out to him via IM.

Comment 2

[Jay Goldman]

Just to clarify - we're working on new icons for the tabs, but I was under the impression that Seth and Dao were working together on the transparency of the various background image pieces. Let me know if that's incorrect.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> Just to clarify - we're working on new icons for the tabs, but I was under the
> impression that Seth and Dao were working together on the transparency of the
> various background image pieces. Let me know if that's incorrect.

I thought you were working on the background images, too. But then lets keep it like that, I can create the backgrounds.

Comment 4

[Jay Goldman]

(In reply to comment #3)

> I thought you were working on the background images, too. But then lets keep it
> like that, I can create the backgrounds.

Thanks Dao!

Comment 5

[Dão Gottwald [:dao]]

Most of the background images have a white line at the bottom. Is this required?

Comment 6

[Jay Goldman]

(In reply to comment #5)

> Most of the background images have a white line at the bottom. Is this
> required?

I'm not 100% sure - Seth might be better to answer - but I don't think it is unless it lines up with the white stripe that runs across the bottom of the tabstrip. Seth?

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> I'm not 100% sure - Seth might be better to answer - but I don't think it is
> unless it lines up with the white stripe that runs across the bottom of the
> tabstrip.

I'll leave them out. Even if the buttons need to connect with the white strip, they just have to be 1px higher, like the active tab.

Comment 8

[Dão Gottwald [:dao]]

By the way, this one can be removed:

http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/winstripe/global/icons/alltabs.png

Comment 9

[Dão Gottwald [:dao]]

Attachment: tabstrip buttons v1

As per bug 350687 comment 6, I added those images:

alltabs-box-end-bkgnd-hover.png
alltabs-box-start-bkgnd-hover.png
alltabs-box-overflow-start-bkgnd-hover.png
alltabs-box-overflow-end-bkgnd-hover.png
tab-arrow-start-bkgnd-disabled.png
tab-arrow-end-bkgnd-disabled.png

In terms of naming, I wasn't sure about "-bkgnd-hover", maybe "-hover" is enough.

*-animate.png presume that they are overlayed by the normal background images, not vice-versa. (I don't know if this is already the case, because the old images are opaque.)

Also note that there are a number of CSS changes needed. I guess Seth is aware of this ...

Comment 10

[Dão Gottwald [:dao]]

Attachment: tabstrip buttons v2

With this set, *-animate.png DON'T have to be overlayed by the normal background images. I.e. the current stacking order can remain.

Comment 11

[(not reading, please use [e-mail] instead)]

dao, thanks for these images!  I'll go try them out and work on the css changes that will be necessary.

to answer an earlier question, yes, we want to get rid of the white strip at the bottom of the images.

and yes, good catch, I need to cvs remove the crufty alltabs.png from jar.mn (it may be used on the trunk, but that will change once we backport all the theme work.)

Comment 12

[(not reading, please use [e-mail] instead)]

plan on landing these images, plus the v5 from bug #350689 plus the new image from bug #351779.

patch coming...

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: patch to use these new images, other new images from dao, and some cleanup

Comment 14

[Mike Connor [:mconnor]]

Comment on attachment 237942 [details] [diff] [review]
patch to use these new images, other new images from dao, and some cleanup

r+a=me on the patch and accompanying images

thanks Seth and Dao!

Comment 15

[(not reading, please use [e-mail] instead)]

fix checked into the branch.  I need a couple additional images in order to fix three open issues.  I'll log them as spin off bugs and ask dao if he can help create new images.

Comment 16

[(not reading, please use [e-mail] instead)]

here are the issues:

1)  due to bug #352315, all four versions of the background images for the alltabs button need to be replaced.  these images should match with a non-hovered tab (from tomorrow's build.)

2)  also due to bug #352315, we need a third state for scroll right / left:  we have disabled and we have hovered, but we need a third state to be used when the scroll right /left buttons are enabled, but not hovered.  these images should match with a non-hovered tab (from tomorrow's build.)

3) the scroll right button (when in LTR mode) doesn't appear disabled like the scroll left (when in LTR mode).  this does not require new images from dao, but I think I have a way to fix it.

Comment 17

[(not reading, please use [e-mail] instead)]

> 1)  due to bug #352315, all four versions of the background images for the...

see bug #352321

> 2)  also due to bug #352315, we need a third state for scroll right / left...

see bug #352320

> 3)  the scroll right button (when in LTR mode) doesn't appear disabled like the...

see bug #352323

Comment 18

[Peter Kasting]

This is on branch and all followups are in spinoff bugs -> RESOLVED FIXED

Comment 19

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381