Closed Bug 352477 Opened 16 years ago Closed 15 years ago

chrome://global/skin/arrow/arrow-dn.gif does not show up in high contrast mode

Categories

(Toolkit :: XUL Widgets, defect)

1.8 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: moco, Assigned: dao)

References

Details

(Keywords: access)

Attachments

(4 files, 1 obsolete file)

chrome://global/skin/arrow/arrow-dn.gif does not show up in high conrtrast mode

I'm running into this with the alltabs button, and from a search in bugzilla, it's also being reported in a number of other places.

note, chrome://global/skin/arrow/arrow-dn-dis.gif is not black, but grey, so the down arrow shows up for a disabled forward button, but does not for an enabled back

see the screen shot.
Flags: blocking-firefox2?
I'm pretty sure this is a dupe.
No longer blocks: 352479
Whiteboard: DUPEME?
note to mscott: this also affects tbird, and tbird also has left / right version of this same icon used in the toolbarbuttons that cycle through the folder view.
Summary: chrome://global/skin/arrow/arrow-dn.gif does not show up in high conrtrast mode → chrome://global/skin/arrow/arrow-dn.gif does not show up in high contrast mode
looks like bug 352288.
> looks like bug 352288.

thanks dao.

in that bug, mconnor writes:  "too late to block on high contrast versions of the icons."
Flags: blocking-firefox2? → blocking-firefox2-
Not a dupe, was intentionally spun off from bug 345753.
Whiteboard: DUPEME?
At Trunk, drop down button of Location bar has same problem.
Attached image arrow-dn.gif (obsolete) —
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #298884 - Flags: ui-review?(faaborg)
Just to make sure I understand the solution, you are using transparent grey so that the icon has a visible V when on black?
(In reply to comment #9)
> We have a lot of arrows, do we need to update all of them?
> 
> http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/arrow/

arrow-dn.gif is the most important one, but we should update all of them.

(In reply to comment #10)
> Just to make sure I understand the solution, you are using transparent grey so
> that the icon has a visible V when on black?

Yes, except that it's not transparent.
Comment on attachment 298884 [details]
arrow-dn.gif

While hardly perceptible, can we have the center top three pixels black as well, and just leverage the anti-aliasing on the V for appearing on black backgrounds.
out of curiosity, why do we use gifs instead of pngs for small monochrome icons?
Attached image arrow-dn.gif
Attachment #298884 - Attachment is obsolete: true
Attachment #298891 - Flags: ui-review?(faaborg)
Attachment #298884 - Flags: ui-review?(faaborg)
(In reply to comment #13)
> out of curiosity, why do we use gifs instead of pngs for small monochrome
> icons?

Because these images are very old.
(In reply to comment #12)
> (From update of attachment 298884 [details])
> just leverage the anti-aliasing on the V for appearing on black
> backgrounds.

I'm not sure where to anti-alias and how it should work at this size (4 black and 5 gray pixels atm), but given the 45 degrees I don't think it would improve things.
Comment on attachment 298891 [details]
arrow-dn.gif

looks good, perhaps if we ever go back and fix all of them we can switch them over to pngs in the process.
Attachment #298891 - Flags: ui-review?(faaborg) → ui-review+
Just to put in my two pennies ... some non-zero number of extensions will be looking for these files (with their traditional names) in the default theme.  I guess most add-on authors would notice it if an arrow went missing because the filename changed, but it would also be good if this got added to the documentation  for the list of things changed for Fx3, if the names did get changed.
I think we likely want to keep everything the same for Firefox 3 so we don't break anything, and do a massive amount of refactoring of icons to clean everything up in Firefox 4.  We should probably release a script to automate updating existing themes to the new names and locations, but we'll worry about that after 3 ships.
Comment on attachment 298891 [details]
arrow-dn.gif

other arrows to follow later
Attachment #298891 - Flags: approval1.9?
Unless there's a good reason, like wanting to use alpha-transparency, I don't think switching over to PNGs will ever be worthwhile here. It's likely that we break much for Firefox 4, even more than for Firefox 3. However, that doesn't mean we have to break everything :)
Comment on attachment 298891 [details]
arrow-dn.gif

a=beltzner for 1.9
Attachment #298891 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
(In reply to comment #20)
> other arrows to follow later

Open a new bug?

Checking in toolkit/themes/winstripe/global/arrow/arrow-dn.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn.gif,v  <--  arrow-dn.gif
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Blocks: 413961
filed bug 413961
Component: General → XUL Widgets
Product: Firefox → Toolkit
Target Milestone: Firefox 3 M11 → mozilla1.9 M11
Version: 2.0 Branch → 1.8 Branch
Comment on attachment 298891 [details]
arrow-dn.gif

Let's switch to a highlight of (153,153,153) to match the 23 arrows updated in bug 413961
Attachment #298891 - Flags: ui-review+ → ui-review-
reopening to get the all of the arrows to use the same highlight.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
QA Contact: general → xul.widgets
I did not uses (153,153,153) to highlight edige of arrow at Bug 413961.
It is used for only body of disabled arrow like arrow-dn-dis.gif.
Photoshop is displaying the highlight at 153,153,153
arrow-up.gif in Bug 413961 is REALLY honrizontal reversed image of
attachment 298891 [details].
I'll attach reversed image of this to Bug 413961.
Attachment #299706 - Flags: ui-review?(faaborg)
Attachment #299706 - Flags: ui-review?(faaborg) → ui-review+
Attachment #298891 - Flags: ui-review-
Keywords: checkin-needed
Comment on attachment 299706 [details]
arrow-dn.gif with (153,153,153)

a=beltzner
Attachment #299706 - Flags: approval1.9b3+
Checking in toolkit/themes/winstripe/global/arrow/arrow-dn.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn.gif,v  <--  arrow-dn.gif
new revision: 1.4; previous revision: 1.3
done
Assignee: dao → masa141421356
Status: REOPENED → NEW
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: masa141421356 → dao
Status: REOPENED → NEW
Status: NEW → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.