352477 - chrome://global/skin/arrow/arrow-dn.gif does not show up in high contrast mode

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[(not reading, please use [e-mail] instead)]

chrome://global/skin/arrow/arrow-dn.gif does not show up in high conrtrast mode

I'm running into this with the alltabs button, and from a search in bugzilla, it's also being reported in a number of other places.

note, chrome://global/skin/arrow/arrow-dn-dis.gif is not black, but grey, so the down arrow shows up for a disabled forward button, but does not for an enabled back

see the screen shot.

Comment 1

[Reed Loden [:reed]]

I'm pretty sure this is a dupe.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: an example of the issue

Comment 3

[(not reading, please use [e-mail] instead)]

note to mscott: this also affects tbird, and tbird also has left / right version of this same icon used in the toolbarbuttons that cycle through the folder view.

Comment 4

[Dão Gottwald [:dao]]

looks like bug 352288.

Comment 5

[(not reading, please use [e-mail] instead)]

> looks like bug 352288.

thanks dao.

in that bug, mconnor writes:  "too late to block on high contrast versions of the icons."

Comment 6

[Mark Pilgrim (inactive)]

Not a dupe, was intentionally spun off from bug 345753.

Comment 7

[Masahiro YAMADA]

At Trunk, drop down button of Location bar has same problem.

Comment 8

[Dão Gottwald [:dao]]

Attachment: arrow-dn.gif

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

We have a lot of arrows, do we need to update all of them?

http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/arrow/

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Just to make sure I understand the solution, you are using transparent grey so that the icon has a visible V when on black?

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #9)
> We have a lot of arrows, do we need to update all of them?
> 
> http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/arrow/

arrow-dn.gif is the most important one, but we should update all of them.

(In reply to comment #10)
> Just to make sure I understand the solution, you are using transparent grey so
> that the icon has a visible V when on black?

Yes, except that it's not transparent.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 298884 [details]
arrow-dn.gif

While hardly perceptible, can we have the center top three pixels black as well, and just leverage the anti-aliasing on the V for appearing on black backgrounds.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

out of curiosity, why do we use gifs instead of pngs for small monochrome icons?

Comment 14

[Dão Gottwald [:dao]]

Attachment: arrow-dn.gif

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #13)
> out of curiosity, why do we use gifs instead of pngs for small monochrome
> icons?

Because these images are very old.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #12)
> (From update of attachment 298884 [details])
> just leverage the anti-aliasing on the V for appearing on black
> backgrounds.

I'm not sure where to anti-alias and how it should work at this size (4 black and 5 gray pixels atm), but given the 45 degrees I don't think it would improve things.

Comment 17

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 298891 [details]
arrow-dn.gif

looks good, perhaps if we ever go back and fix all of them we can switch them over to pngs in the process.

Comment 18

[mcdavis941 (sporadically reading bugmail)]

Just to put in my two pennies ... some non-zero number of extensions will be looking for these files (with their traditional names) in the default theme.  I guess most add-on authors would notice it if an arrow went missing because the filename changed, but it would also be good if this got added to the documentation  for the list of things changed for Fx3, if the names did get changed.

Comment 19

[Alex Faaborg [:faaborg] (Firefox UX)]

I think we likely want to keep everything the same for Firefox 3 so we don't break anything, and do a massive amount of refactoring of icons to clean everything up in Firefox 4.  We should probably release a script to automate updating existing themes to the new names and locations, but we'll worry about that after 3 ships.

Comment 20

[Dão Gottwald [:dao]]

Comment on attachment 298891 [details]
arrow-dn.gif

other arrows to follow later

Comment 21

[Dão Gottwald [:dao]]

Unless there's a good reason, like wanting to use alpha-transparency, I don't think switching over to PNGs will ever be worthwhile here. It's likely that we break much for Firefox 4, even more than for Firefox 3. However, that doesn't mean we have to break everything :)

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 298891 [details]
arrow-dn.gif

a=beltzner for 1.9

Comment 23

[Reed Loden [:reed]]

(In reply to comment #20)
> other arrows to follow later

Open a new bug?

Checking in toolkit/themes/winstripe/global/arrow/arrow-dn.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn.gif,v  <--  arrow-dn.gif
new revision: 1.3; previous revision: 1.2
done

Comment 24

[Dão Gottwald [:dao]]

filed bug 413961

Comment 25

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 298891 [details]
arrow-dn.gif

Let's switch to a highlight of (153,153,153) to match the 23 arrows updated in bug 413961

Comment 26

[Alex Faaborg [:faaborg] (Firefox UX)]

reopening to get the all of the arrows to use the same highlight.

Comment 27

[Masahiro YAMADA]

I did not uses (153,153,153) to highlight edige of arrow at Bug 413961.
It is used for only body of disabled arrow like arrow-dn-dis.gif.

Comment 28

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Highlight of arrows in 413961

Photoshop is displaying the highlight at 153,153,153

Comment 29

[Masahiro YAMADA]

arrow-up.gif in Bug 413961 is REALLY honrizontal reversed image of
attachment 298891 [details].

Comment 30

[Masahiro YAMADA]

Attachment: arrow-dn.gif with (153,153,153)

I'll attach reversed image of this to Bug 413961.

Comment 31

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299706 [details]
arrow-dn.gif with (153,153,153)

a=beltzner

Comment 32

[Reed Loden [:reed]]

Checking in toolkit/themes/winstripe/global/arrow/arrow-dn.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn.gif,v  <--  arrow-dn.gif
new revision: 1.4; previous revision: 1.3
done

Comment 33

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381