Closed
Bug 413961
Opened 15 years ago
Closed 15 years ago
chrome://global/skin/arrow/* icons don't show up in high contrast mode
Categories
(Toolkit :: Themes, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: dao, Assigned: masa141421356)
References
()
Details
(Keywords: access)
Attachments
(25 files, 13 obsolete files)
56 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
59 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
57 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
57 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
59 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
59 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
57 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
60 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
60 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
64 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
57 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
58 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
57 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
53 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
53 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
64 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
54 bytes,
image/gif
|
faaborg
:
ui-review+
|
Details |
spin-off from bug 352477, where arrow-dn.gif has been fixed: (bug 352477 comment 0) > chrome://global/skin/arrow/arrow-dn.gif does not show up in high conrtrast mode > > I'm running into this with the alltabs button, and from a search in bugzilla, > it's also being reported in a number of other places. (bug 352477 comment 9) > We have a lot of arrows, do we need to update all of them? > > http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/arrow/
Reporter | ||
Updated•15 years ago
|
Summary: chrome://global/skin/arrow/* don't show up in high contrast mode → chrome://global/skin/arrow/* icons don't show up in high contrast mode
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
Assignee | ||
Comment 3•15 years ago
|
||
Assignee | ||
Comment 4•15 years ago
|
||
Smaller than attachement 299137
Attachment #299137 -
Attachment is obsolete: true
Assignee | ||
Comment 5•15 years ago
|
||
Attachment #299135 -
Attachment is obsolete: true
Assignee | ||
Comment 6•15 years ago
|
||
Attachment #299136 -
Attachment is obsolete: true
Assignee | ||
Comment 7•15 years ago
|
||
Assignee | ||
Comment 8•15 years ago
|
||
Assignee | ||
Comment 9•15 years ago
|
||
I think chevron.gif (">>" mark displayed when many tabs are open) is also needed to fix.
Reporter | ||
Comment 10•15 years ago
|
||
Note that arrow-down.png should be removed. It's used by venkman only, which should switch to arrow-dn.gif.
Assignee: nobody → masa141421356
Assignee | ||
Comment 11•15 years ago
|
||
Assignee | ||
Comment 12•15 years ago
|
||
Assignee | ||
Comment 13•15 years ago
|
||
Assignee | ||
Comment 14•15 years ago
|
||
Assignee | ||
Comment 15•15 years ago
|
||
Is it needed to cahnge menulist-arrow-act.gif and menulist-arrow-dis.gif of pinstripe ?
Status: NEW → ASSIGNED
Reporter | ||
Comment 16•15 years ago
|
||
Comment on attachment 299156 [details]
menulist-arrow.gif
this is pinstripe
Attachment #299156 -
Attachment is obsolete: true
Reporter | ||
Comment 17•15 years ago
|
||
(In reply to comment #15) > Is it needed to cahnge menulist-arrow-act.gif and menulist-arrow-dis.gif of > pinstripe ? No.
Assignee | ||
Comment 18•15 years ago
|
||
I changed color of left side of lines. But it may be better to change color of right side. (It is impossible to change color of both side , because width of line is only 2px)
Assignee | ||
Comment 19•15 years ago
|
||
Assignee | ||
Comment 20•15 years ago
|
||
Assignee | ||
Comment 21•15 years ago
|
||
Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)
arrow-up.gif of winstrip
Assignee | ||
Updated•15 years ago
|
Attachment #299138 -
Attachment description: arrow-up.gif rv.2.0 → arrow-up.gif of winstrip
Assignee | ||
Comment 22•15 years ago
|
||
Assignee | ||
Comment 23•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #299140 -
Attachment description: arrwo-lft.gif rv.2.0 → arrwo-lft.gif 11x11 (pinstripe/global/arrow)
Assignee | ||
Updated•15 years ago
|
Attachment #299138 -
Attachment description: arrow-up.gif of winstrip → arrow-up.gif 5x3 (winstripe/global/arrow)
Assignee | ||
Updated•15 years ago
|
Attachment #299141 -
Attachment description: arrow-rit.gif rv.2.0 → arrow-rit.gif 11x11 (pinstripe/global/arrow)
Assignee | ||
Updated•15 years ago
|
Attachment #299163 -
Attachment description: pmstripe/global/arrow/arrow-dn.gif → arrow-dn.gif 8x13 (pmstripe/global/arrow)
Assignee | ||
Updated•15 years ago
|
Attachment #299164 -
Attachment description: pmstripe/global/arrow/arrow-up.gif → arrow-up.gif 8x13 (pmstripe/global/arrow/)
Assignee | ||
Comment 24•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #299160 -
Attachment description: arrow-lft-sharp.gif → arrow-lft-sharp.gif 5x9 (winstripe & pinstripe)
Assignee | ||
Comment 25•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #299161 -
Attachment description: arrow-rit-sharp.gif → arrow-rit-sharp.gif 5x9 (winstripe & pinstripe)
Assignee | ||
Comment 26•15 years ago
|
||
Assignee | ||
Comment 27•15 years ago
|
||
Reporter | ||
Comment 28•15 years ago
|
||
Masahiro, please keep this bug limited to winstripe.
Assignee | ||
Comment 29•15 years ago
|
||
Assignee | ||
Comment 30•15 years ago
|
||
Assignee | ||
Comment 31•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #299140 -
Attachment is obsolete: true
Assignee | ||
Comment 32•15 years ago
|
||
(In reply to comment #28) > Masahiro, please keep this bug limited to winstripe. > OK. I'll change them to obsolete. And I have a question. Is it needed to cahnge arrow-*-dis.gif and arrow-*-hov.gif ?
Assignee | ||
Updated•15 years ago
|
Attachment #299141 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #299163 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #299164 -
Attachment is obsolete: true
Reporter | ||
Comment 33•15 years ago
|
||
(In reply to comment #32) > Is it needed to cahnge arrow-*-dis.gif and arrow-*-hov.gif ? Not as badly as the others, but using a dark gray theme they can disappear as well, so that's not ideal either.
Assignee | ||
Updated•15 years ago
|
Attachment #299169 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #299173 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #299174 -
Attachment is obsolete: true
Assignee | ||
Comment 34•15 years ago
|
||
Assignee | ||
Comment 35•15 years ago
|
||
Assignee | ||
Comment 36•15 years ago
|
||
Assignee | ||
Comment 37•15 years ago
|
||
Assignee | ||
Comment 38•15 years ago
|
||
Assignee | ||
Comment 39•15 years ago
|
||
Assignee | ||
Comment 40•15 years ago
|
||
Assignee | ||
Comment 41•15 years ago
|
||
This image uses color #bfbfbf for edge of arrow. (Color of arrow is #7f7f7f) Is there better color for it ?
Assignee | ||
Comment 42•15 years ago
|
||
Assignee | ||
Comment 43•15 years ago
|
||
Assignee | ||
Comment 44•15 years ago
|
||
Are there other arrows ?
Assignee | ||
Updated•15 years ago
|
Attachment #299138 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299146 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299147 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299149 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299152 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299154 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299159 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299160 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299161 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299166 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299172 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299175 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299176 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299177 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299178 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299179 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299180 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299181 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299182 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299183 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299184 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299185 -
Flags: ui-review?(faaborg)
Assignee | ||
Updated•15 years ago
|
Attachment #299168 -
Flags: ui-review?(faaborg)
Assignee | ||
Comment 45•15 years ago
|
||
I forgot index optimization at attachment 299167 [details] .
Attachment #299167 -
Attachment is obsolete: true
Attachment #299357 -
Flags: ui-review?(faaborg)
Updated•15 years ago
|
Attachment #299146 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299147 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299149 -
Flags: ui-review?(faaborg) → ui-review+
Comment 46•15 years ago
|
||
Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)
let's use (153,153,153) for the highlight like you have on the other arrows since it stands out more when on a black background.
Comment 47•15 years ago
|
||
Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)
forgot to minus, switch highlight to 153,153,153
Attachment #299138 -
Flags: ui-review?(faaborg) → ui-review-
Updated•15 years ago
|
Attachment #299152 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299154 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299159 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299160 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299161 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299166 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299168 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299172 -
Flags: ui-review?(faaborg) → ui-review+
Comment 48•15 years ago
|
||
Requesting blocking since this is an accessibility issue and low risk (just some image replacements)
Flags: blocking1.9?
Updated•15 years ago
|
Attachment #299175 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299176 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299177 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299178 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299179 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299180 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299181 -
Flags: ui-review?(faaborg) → ui-review+
Comment 49•15 years ago
|
||
Comment on attachment 299182 [details]
arrow-dn-dis.gif
In high contrast mode on black this is going to get lighter which will make it easier to see. Kind of counter intuitive, but I don't see an obvious way around the problem.
Attachment #299182 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299183 -
Flags: ui-review?(faaborg) → ui-review+
Comment 50•15 years ago
|
||
Comment on attachment 299184 [details]
arrow-rit-dis.gif
same problem as the other disabled arrow. At least the shape is changing so people will be able to eventually infer that this is the disabled state.
Attachment #299184 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299185 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299357 -
Flags: ui-review?(faaborg) → ui-review+
Comment 51•15 years ago
|
||
Masahiro: thanks for working on this
Updated•15 years ago
|
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Assignee | ||
Comment 52•15 years ago
|
||
It may be needed to fix chrome://global/skin/tree/columnpicker.gif (See bug 414243).
Updated•15 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 53•15 years ago
|
||
Attachment #299138 -
Attachment is obsolete: true
Attachment #299707 -
Flags: ui-review?(faaborg)
Updated•15 years ago
|
Attachment #299707 -
Flags: ui-review?(faaborg) → ui-review+
Updated•15 years ago
|
Attachment #299155 -
Flags: ui-review?(faaborg)
Updated•15 years ago
|
Attachment #299155 -
Flags: ui-review?(faaborg) → ui-review+
Comment 54•15 years ago
|
||
a=beltzner for checking in the image replacements for beta 3
Comment 55•15 years ago
|
||
Checking in editor/composer/src/res/table-add-column-after-active.gif; /cvsroot/mozilla/editor/composer/src/res/table-add-column-after-active.gif,v <-- table-add-column-after-active.gif new revision: 1.4; previous revision: 1.3 done Checking in editor/composer/src/res/table-add-column-before-active.gif; /cvsroot/mozilla/editor/composer/src/res/table-add-column-before-active.gif,v <-- table-add-column-before-active.gif new revision: 1.5; previous revision: 1.4 done Checking in editor/composer/src/res/table-add-row-after-active.gif; /cvsroot/mozilla/editor/composer/src/res/table-add-row-after-active.gif,v <-- table-add-row-after-active.gif new revision: 1.4; previous revision: 1.3 done Checking in editor/composer/src/res/table-add-row-before-active.gif; /cvsroot/mozilla/editor/composer/src/res/table-add-row-before-active.gif,v <-- table-add-row-before-active.gif new revision: 1.4; previous revision: 1.3 done Checking in layout/style/arrow.gif; /cvsroot/mozilla/layout/style/arrow.gif,v <-- arrow.gif new revision: 1.4; previous revision: 1.3 done Checking in layout/style/arrowd.gif; /cvsroot/mozilla/layout/style/arrowd.gif,v <-- arrowd.gif new revision: 3.4; previous revision: 3.3 done Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-dis.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-dis.gif,v <-- arrow-dn-dis.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-hov.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-hov.gif,v <-- arrow-dn-hov.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-sharp.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-sharp.gif,v <-- arrow-dn-sharp.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-hov.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-hov.gif,v <-- arrow-lft-hov.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-sharp-end.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-sharp-end.gif,v <-- arrow-lft-sharp-end.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-sharp.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-sharp.gif,v <-- arrow-lft-sharp.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-lft.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft.gif,v <-- arrow-lft.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-dis.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-dis.gif,v <-- arrow-rit-dis.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-hov.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-hov.gif,v <-- arrow-rit-hov.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-sharp-end.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-sharp-end.gif,v <-- arrow-rit-sharp-end.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-sharp.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-sharp.gif,v <-- arrow-rit-sharp.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-rit.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit.gif,v <-- arrow-rit.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-up-dis.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-dis.gif,v <-- arrow-up-dis.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-up-hov.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-hov.gif,v <-- arrow-up-hov.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-up-sharp.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-sharp.gif,v <-- arrow-up-sharp.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/arrow/arrow-up.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up.gif,v <-- arrow-up.gif new revision: 1.3; previous revision: 1.2 done Checking in toolkit/themes/winstripe/global/toolbar/chevron-rtl.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/toolbar/chevron-rtl.gif,v <-- chevron-rtl.gif new revision: 1.2; previous revision: 1.1 done Checking in toolkit/themes/winstripe/global/toolbar/chevron.gif; /cvsroot/mozilla/toolkit/themes/winstripe/global/toolbar/chevron.gif,v <-- chevron.gif new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta3
Comment 56•15 years ago
|
||
Still missing replacements for the following: * Most of editor/composer/src/res/ * toolkit/themes/winstripe/global/arrow/arrow-down.png * toolkit/themes/winstripe/global/arrow/arrow-lft-dis.gif * Some of toolkit/themes/winstripe/global/toolbar/ Of course, need the pinstripe ones (new bug, please!).
Reporter | ||
Updated•12 years ago
|
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
Comment 58•3 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•