413961 - chrome://global/skin/arrow/* icons don't show up in high contrast mode

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Dão Gottwald [::dao]]

spin-off from bug 352477, where arrow-dn.gif has been fixed:

(bug 352477 comment 0)
> chrome://global/skin/arrow/arrow-dn.gif does not show up in high conrtrast mode
> 
> I'm running into this with the alltabs button, and from a search in bugzilla,
> it's also being reported in a number of other places.

(bug 352477 comment 9)
> We have a lot of arrows, do we need to update all of them?
> 
> http://mxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/arrow/

Comment 1

[Masahiro YAMADA]

Attachment: arrow-lft.gif

Comment 2

[Masahiro YAMADA]

Attachment: arrow-rit.gif

Comment 3

[Masahiro YAMADA]

Attachment: arrow-up.gif

Comment 4

[Masahiro YAMADA]

Attachment: arrow-up.gif 5x3 (winstripe/global/arrow)

Smaller than attachement 299137

Comment 5

[Masahiro YAMADA]

Attachment: arrwo-lft.gif 11x11 (pinstripe/global/arrow)

Comment 6

[Masahiro YAMADA]

Attachment: arrow-rit.gif 11x11 (pinstripe/global/arrow)

Comment 7

[Masahiro YAMADA]

Attachment: /layout/style/arrow.gif

Comment 8

[Masahiro YAMADA]

Attachment: arrow-dn-sharp.gif

Comment 9

[Masahiro YAMADA]

Attachment: chevron.gif

I think chevron.gif (">>" mark displayed when many tabs are open) is also needed to fix.

Comment 10

[Dão Gottwald [::dao]]

Note that arrow-down.png should be removed. It's used by venkman only, which should switch to arrow-dn.gif.

Comment 11

[Masahiro YAMADA]

Attachment: table-add-column-before-active.gif

Comment 12

[Masahiro YAMADA]

Attachment: arrowd.gif

Comment 13

[Masahiro YAMADA]

Attachment: arrow-up-sharp.gif

Comment 14

[Masahiro YAMADA]

Attachment: menulist-arrow.gif

Comment 15

[Masahiro YAMADA]

Is it needed to cahnge menulist-arrow-act.gif and menulist-arrow-dis.gif of pinstripe ?

Comment 16

[Dão Gottwald [::dao]]

Comment on attachment 299156 [details]
menulist-arrow.gif

this is pinstripe

Comment 17

[Dão Gottwald [::dao]]

(In reply to comment #15)
> Is it needed to cahnge menulist-arrow-act.gif and menulist-arrow-dis.gif of
> pinstripe ?

No.

Comment 18

[Masahiro YAMADA]

Attachment: chevron-rtl.gif

I changed color of left side of lines.
But it may be better to change color of right side.
(It is impossible to change color of both side , because width of line is only 2px)

Comment 19

[Masahiro YAMADA]

Attachment: arrow-lft-sharp.gif 5x9 (winstripe & pinstripe)

Comment 20

[Masahiro YAMADA]

Attachment: arrow-rit-sharp.gif 5x9 (winstripe & pinstripe)

Comment 21

[Masahiro YAMADA]

Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)

arrow-up.gif of winstrip

Comment 22

[Masahiro YAMADA]

Attachment: arrow-dn.gif 8x13 (pmstripe/global/arrow)

Comment 23

[Masahiro YAMADA]

Attachment: arrow-up.gif 8x13 (pmstripe/global/arrow/)

Comment 24

[Masahiro YAMADA]

Attachment: arrow-lft.gif 3x5 (Winstripe/global/arrow/)

Comment 25

[Masahiro YAMADA]

Attachment: arrow-lft-sharp-end.gif 7x9 (winstripe & pinstripe)

Comment 26

[Masahiro YAMADA]

Attachment: arrow-rit.gif 3x5 (winstripe/global/arrow/)

Comment 27

[Masahiro YAMADA]

Attachment: arrow-rit.gif 13x8 (pmstripe/global/arrow/)

Comment 28

[Dão Gottwald [::dao]]

Masahiro, please keep this bug limited to winstripe.

Comment 29

[Masahiro YAMADA]

Attachment: arrow-rit-sharp-end.gif 7x9 (winstripe & pinstripe)

Comment 30

[Masahiro YAMADA]

Attachment: arrow-up.gif 8x13 (pmstripe/global/arrow)

Comment 31

[Masahiro YAMADA]

Attachment: arrow-up.gif 11x11 (pinstripe/global/arrows/)

Comment 32

[Masahiro YAMADA]

(In reply to comment #28)
> Masahiro, please keep this bug limited to winstripe.
> 

OK. I'll change them to obsolete.

And I have a question.
Is it needed to cahnge arrow-*-dis.gif and arrow-*-hov.gif ?

Comment 33

[Dão Gottwald [::dao]]

(In reply to comment #32)
> Is it needed to cahnge arrow-*-dis.gif and arrow-*-hov.gif ?

Not as badly as the others, but using a dark gray theme they can disappear as well, so that's not ideal either.

Comment 34

[Masahiro YAMADA]

Attachment: table-add-row-after-active.gif

Comment 35

[Masahiro YAMADA]

Attachment: table-add-column-after-active.gif

Comment 36

[Masahiro YAMADA]

Attachment: table-add-row-before-active.gif

Comment 37

[Masahiro YAMADA]

Attachment: arrow-dn-hov.gif

Comment 38

[Masahiro YAMADA]

Attachment: arrow-lft-hov.gif

Comment 39

[Masahiro YAMADA]

Attachment: arrow-rit-hov.gif

Comment 40

[Masahiro YAMADA]

Attachment: arrow-up-hov.gif

Comment 41

[Masahiro YAMADA]

Attachment: arrow-dn-dis.gif

This image uses color #bfbfbf for edge of arrow.
(Color of arrow is #7f7f7f)
Is there better color for it ?

Comment 42

[Masahiro YAMADA]

Attachment: arrow-lft-hov.gif

Comment 43

[Masahiro YAMADA]

Attachment: arrow-rit-dis.gif

Comment 44

[Masahiro YAMADA]

Attachment: arrow-up-dis.gif

Are there other arrows ?

Comment 45

[Masahiro YAMADA]

Attachment: arrow-lft-sharp-end.gif

I forgot index optimization at attachment 299167 [details] .

Comment 46

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)

let's use (153,153,153) for the highlight like you have on the other arrows since it stands out more when on a black background.

Comment 47

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 299138 [details]
arrow-up.gif 5x3 (winstripe/global/arrow)

forgot to minus, switch highlight to 153,153,153

Comment 48

[Alex Faaborg [:faaborg] (Firefox UX)]

Requesting blocking since this is an accessibility issue and low risk (just some image replacements)

Comment 49

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 299182 [details]
arrow-dn-dis.gif

In high contrast mode on black this is going to get lighter which will make it easier to see.  Kind of counter intuitive, but I don't see an obvious way around the problem.

Comment 50

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 299184 [details]
arrow-rit-dis.gif

same problem as the other disabled arrow.  At least the shape is changing so people will be able to eventually infer that this is the disabled state.

Comment 51

[Alex Faaborg [:faaborg] (Firefox UX)]

Masahiro: thanks for working on this

Comment 52

[Masahiro YAMADA]

It may be needed to fix chrome://global/skin/tree/columnpicker.gif (See bug 414243).

Comment 53

[Masahiro YAMADA]

Attachment: arrow-up.gif with (153,153,153)

Comment 54

[Mike Beltzner [:beltzner, not reading bugmail]]

a=beltzner for checking in the image replacements for beta 3

Comment 55

[Reed Loden [:reed] (use needinfo?)]

Checking in editor/composer/src/res/table-add-column-after-active.gif;
/cvsroot/mozilla/editor/composer/src/res/table-add-column-after-active.gif,v  <--  table-add-column-after-active.gif
new revision: 1.4; previous revision: 1.3
done
Checking in editor/composer/src/res/table-add-column-before-active.gif;
/cvsroot/mozilla/editor/composer/src/res/table-add-column-before-active.gif,v  <--  table-add-column-before-active.gif
new revision: 1.5; previous revision: 1.4
done
Checking in editor/composer/src/res/table-add-row-after-active.gif;
/cvsroot/mozilla/editor/composer/src/res/table-add-row-after-active.gif,v  <--  table-add-row-after-active.gif
new revision: 1.4; previous revision: 1.3
done
Checking in editor/composer/src/res/table-add-row-before-active.gif;
/cvsroot/mozilla/editor/composer/src/res/table-add-row-before-active.gif,v  <--  table-add-row-before-active.gif
new revision: 1.4; previous revision: 1.3
done
Checking in layout/style/arrow.gif;
/cvsroot/mozilla/layout/style/arrow.gif,v  <--  arrow.gif
new revision: 1.4; previous revision: 1.3
done
Checking in layout/style/arrowd.gif;
/cvsroot/mozilla/layout/style/arrowd.gif,v  <--  arrowd.gif
new revision: 3.4; previous revision: 3.3
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-dis.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-dis.gif,v  <--  arrow-dn-dis.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-hov.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-hov.gif,v  <--  arrow-dn-hov.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-dn-sharp.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-dn-sharp.gif,v  <--  arrow-dn-sharp.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-hov.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-hov.gif,v  <--  arrow-lft-hov.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-sharp-end.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-sharp-end.gif,v  <--  arrow-lft-sharp-end.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-lft-sharp.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft-sharp.gif,v  <--  arrow-lft-sharp.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-lft.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-lft.gif,v  <--  arrow-lft.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-dis.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-dis.gif,v  <--  arrow-rit-dis.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-hov.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-hov.gif,v  <--  arrow-rit-hov.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-sharp-end.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-sharp-end.gif,v  <--  arrow-rit-sharp-end.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-rit-sharp.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit-sharp.gif,v  <--  arrow-rit-sharp.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-rit.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-rit.gif,v  <--  arrow-rit.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-up-dis.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-dis.gif,v  <--  arrow-up-dis.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-up-hov.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-hov.gif,v  <--  arrow-up-hov.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-up-sharp.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up-sharp.gif,v  <--  arrow-up-sharp.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/arrow/arrow-up.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/arrow/arrow-up.gif,v  <--  arrow-up.gif
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/themes/winstripe/global/toolbar/chevron-rtl.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/toolbar/chevron-rtl.gif,v  <--  chevron-rtl.gif
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/winstripe/global/toolbar/chevron.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/global/toolbar/chevron.gif,v  <--  chevron.gif
new revision: 1.3; previous revision: 1.2
done

Comment 56

[Reed Loden [:reed] (use needinfo?)]

Still missing replacements for the following:
* Most of editor/composer/src/res/
* toolkit/themes/winstripe/global/arrow/arrow-down.png
* toolkit/themes/winstripe/global/arrow/arrow-lft-dis.gif
* Some of toolkit/themes/winstripe/global/toolbar/

Of course, need the pinstripe ones (new bug, please!).

Comment 58

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381