352787 - Option to go to survey page on uninstall not displayed on Vista and above

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

We don't display the survey url unless we find IE on the system. Probably due to us checking the reg key for IE 6 and it not being the same key for IE 7. This only affects browser apps since we have to launch the executable directly instead of letting the OS choose the app since there may no longer be an http handler after a browser app is uninstalled.

Comment 1

[Marcia Knous [:marcia]]

*** Bug 359310 has been marked as a duplicate of this bug. ***

Comment 2

[Marcia Knous [:marcia]]

Nominating this for the next release since it is probably a good thing to fix, I see this using Build identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2) Gecko/2007020823 Firefox/2.0.0.2.

Comment 3

[Robert Strong (they/them - no direct email)]

Instead of reading the reg keys directly I think we should set IE as the default (see bug 255225) if we were the default and then use shellexecute. I am making this depend on bug 255225 though we could do this another way.

Comment 4

[Robert Strong (they/them - no direct email)]

Taking to get this on my radar

Comment 5

[Daniel Veditz [:dveditz]]

Would be nice to get fixed, but it's not going to kill us not having this data.

Comment 6

[Robert Strong (they/them - no direct email)]

For Vista we can use the NSIS plugin for bug 397884 to reset IE as the default and then use shellexecute as noted in comment #3

Comment 7

[Robert Strong (they/them - no direct email)]

bah... shellexecute won't de-elevate. I'll have to get the topmost window's token and use CreateProcessWithTokenW in the same way we de-elevate on startup when we restart on startup

Comment 8

[Carsten Book [:Tomcat]]

This affects also Firefox 3 Beta Builds, so requesting blocking Firefox 3 on the Radar, but i think its also more a wanted bug.

Comment 9

[AndrewM]

Also, Version should be changed to Trunk :)

Comment 10

[Robert Strong (they/them - no direct email)]

We can't do this without launching the new process de-elevated since the uninstaller is elevated when it is launched by the control panel applet. This is problematic in that the only way I know of to accomplish this is to clone the desktop's token which is to say the least hacky and prone to failure. This is why most uninstallers on Vista don't launch other processes.

Comment 11

[Robert Strong (they/them - no direct email)]

Also, we need to check launching IE using the desktop token with UAC turned off to see if it is elevated.

Comment 12

[Robert Strong (they/them - no direct email)]

Launching anything from an installer that was initiated by Vista's "Programs and Features" (or for that matter "Add or Remove Programs" in previous versions of Windows) is to say the least problematic and any solution is going to be a hack since it will be initiated elevated. I'm taking this off my radar at least for now.

Comment 13

[raymond [:retornam] (inactive)]

The  option to go to survey page on uninstall is also not displayed on Windows 7

Comment 14

[Mark Smith [:mcs]]

I just noticed this bug when I was experimenting with the uninstaller.  I searched for solutions, and one that seems promising on the surface is to launch IE via a Windows Task Scheduler task.  Is that a possibility?

See the last solution suggested in this Stack Overflow question:
http://stackoverflow.com/questions/196949/how-to-run-not-elevated-in-vista-net

Comment 15

[Robert Strong (they/them - no direct email)]

Saw that a few years ago. The main problem with this is that there is no guarantee that the user account performing the uninstall is the same as the desktop's user account (e.g. they launched the uninstall using runas). It would probably work the vast majority of time but I don't think the risk and complexity (e.g. only show the check box when the task scheduler is running, etc.) is worth the value.

Comment 16

[Robert Strong (they/them - no direct email)]

Now that bug 617787 has removed the uninstall survey this is WONTFIX