353470 - Deleting a Todo also deletes an Email

Status: RESOLVED WORKSFORME

(Calendar :: Calendar Frontend, defect)

Description

[Christian Jansen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Lightning

Deleting a Todo from the Todo tab also deletes an Email.

Reproducible: Always

Steps to Reproduce:
1.Select an Email
2.Select Lightning's Todo Tab
3.Select an Todo
4.Hit the Delete key

Actual Results:  
Todo & Email has been deleted

Expected Results:  
Delete only the selected Todo

See screen shot attached

Comment 1

[Christian Jansen]

Attachment: Todo & Email selected

Comment 2

[Joey Minta]

Attachment: now tested patch

Intuition tells me this is the right fix, someone should examine that and then ask for review if I'm right.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 239365 [details] [diff] [review]
now tested patch

r1=lilmatt
r2=dmose (verbal)

Tested this in Lightning. You fixeded it!

Comment 4

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 5

[Sebastian Schwieger]

There is still one case where this bug can happen:

1. select task
2. select email
3. click on slected task again
4. press del in order to delete last clicked task

--> both email and task are deleted
REOPEN?

using lightning 2006092204/Thunderbird version 2 beta 1 (20060921)

Comment 6

[Joey Minta]

(In reply to comment #5)
> --> both email and task are deleted
> REOPEN?
Yes, that's precisely what this patch was supposed to fix.

Comment 7

[Matthew (lilmatt) Willis]

This now seems like a selection issue, rather than an event propagation issue.

Comment 8

[Matthew (lilmatt) Willis]

Attachment: Sets focus on todo item appropriately (thanks to jminta)

This fixes the problem with deleting the email message by mistake.

It does _not_ fix the problem where you can try to edit an already deleted todo item (bug 353791).

Mad propz to jminta for spoon-feeding the solution to me.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 239831 [details] [diff] [review]
Sets focus on todo item appropriately (thanks to jminta)

r2=dmose

Comment 10

[cmtalbert]

Comment on attachment 239831 [details] [diff] [review]
Sets focus on todo item appropriately (thanks to jminta)

Looks good. Good job.

Comment 11

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 12

[Andreas Treumann]

I reopen this bug, because this issue isn't fixed for asyncron providers (e.g. WCAP)

This bugfix works with the home calendar.

Comment 13

[Simon Paquet [:sipaq]]

Andreas, is this still happening after the checkin for bug 371916? 

I can' test this right now, due to lack of Windows Lightning nightly builds, but I can't really imagine that this still happens with the patch from bug 371916 going in.

Comment 14

[Simon Paquet [:sipaq]]

Marking as WORKSFORME, as this shouldn't be happening after the checkin for bug 371916.

Comment 15

[Stefan Sitter [:ssitter]]

Issue still exists with the Today Pane using Lightning 0.7pre (2007072308). 

The first press of the Delete key deletes the task from task section of the Today Pane, the second press of Delete key will delete the previously selected email.

Comment 16

[Stefan Sitter [:ssitter]]

Correction: the issue reported in Comment #15 is tracked with Bug 360216.