360216 - Deleting multiple tasks in Todo tab deletes email due to focus issue

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Sergey]

User-Agent:       Opera/9.01 (Windows NT 5.1; U; en)
Build Identifier: Thunderbird 1.5.0.8 (20061025)

When I'm editing Todo list in Lighthing extension for Thunderbird I just push delete button for removing highlighted task, but after deletion one focus in moved to mail messages list in inbox and if I try to push the delete button again I remove some of my mail messages.
I thing it's a bad usabiliy bug.

Reproducible: Always

Steps to Reproduce:
1. install thunderbird with Lightthing calendar extension
2. create mail box with expaned list of all mail directories
3. recieve at least one mail message in to this mail box
4. create several (more than 1) task in todo list
5. go to Todo list and set the focus to some of tasks
6. just push delete button several times
Actual Results:  
As you can see after first pushing of delete button you remove a task,
after second pushing you remove a mail message

Expected Results:  
The focus should be still in Todo list and next task in list should be highlighted.

I hope the calendar in Thunderbird will more useful and functional because I plan to use it, it's a good feature that motivate me don't use MS Outlook for scheduling of my tasks and events.
Thanks.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed using Thunderbird/1.5.0.8 (20061025) and Lightning/0.4a1 (2006111006)
on Windows 2000.

Bug 353470 fixed this issue if a task is selected in Todo tab. But after deletion focus moves back to mail folder instead to the next task in Todo tab. Pressing delete again will remove mail message.

Comment 2

[Martin Schröder [:mschroeder]]

We have to verify if this is still an issue after the patch from bug 371916 has landed.

Comment 3

[Stefan Sitter [:ssitter]]

Issue still exists with the Today Pane using Lightning 0.7pre (2007072308).

Comment 4

[Sebastian Schwieger]

Attachment: select next Task

The patch selects the next task after deletion. If the last task is deleted, the one before is selected.
This still deletes an email after all tasks have been deleted.

Comment 5

[Michael Büttner (no reviews TFN)]

Comment on attachment 278331 [details] [diff] [review]
select next Task

>+                  var index = this.selectedIndex;
>                   event.stopPropagation();
>                   this.fireEvent("item-delete");
>+                  this.selectedIndex = index;
>+                  if (this.selectedIndex == -1) {
>+                      this.selectedIndex = index - 1;
>+                  }
You could easily calculate the new selection index instead of relying on the listbox. Furthermore, as you already said it doesn't work if the last task has been deleted from the list. In that case it would be better to not fire the event at all.

> This still deletes an email after all tasks have been deleted.
Unfortunately r- since it doesn't solve the problem.

As a side note, this bug would be obsolete after Bug 372830 has landed.

Comment 6

[Daniel Boelzle [:dbo]]

(In reply to comment #5)
> As a side note, this bug would be obsolete after Bug 372830 has landed.
Unfortunately the unifinder todo does not solve this problem.

Comment 7

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

The delete key isn't handled at all by the unifinder todo list, that's why the corresponding patch doesn't solve the problem [bug 372830] out of the box. This patch adds the missing bits and pieces. Also, what actually caused all the trouble that the event has been erroneously been propagated to the rest of the hierarchy, a missing call to preventDefault() in essence.

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 280337 [details] [diff] [review]
patch v1

r=dbo

Comment 9

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 10

[Andreas Treumann]

Checked in Lightning build 2007091703 -> set task to VERIFIED