353716 - crash on quit [@ nsMacEventHandler::HandleMouseMoveEvent] or [@ nsMacEventHandler::ConvertOSEventToMouseEvent]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[(not reading, please use [e-mail] instead)]

crash on quit [@nsMacEventHandler::HandleMouseMoveEvent]

this was with my debug, mac os x, trunk build

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a1) Gecko/20060921 Minefield/3.0a1

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x4a7400a2

0x158e9ff1 in nsMacEventHandler::HandleMouseMoveEvent (this=0x34128680, aOSEvent=@0xbfffee10) at /Users/sspitzer/Desktop/trunk/mozilla/widget/src/mac/nsMacEventHandler.cpp:1679
1679              lastWidgetPointed->GetBounds(bounds);
(gdb) print lastWidgetPointed
$1 = (nsWindow *) 0x20000
(gdb) where

I'll attach the full stack.

so far, I haven't been able to reproduce it.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: stack, from within gdb

Comment 2

[Mark Mentovai]

Reproducible?

Comment 3

[(not reading, please use [e-mail] instead)]

> Reproducible?

sorry mark, not yet.  :(

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: hit it again, but still not reproducable

Comment 5

[(not reading, please use [e-mail] instead)]

josh / mark, does that second crash report look like a different issue, or the the same as my stack attached as comment #1?  (The top of the stack looks similar).

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: another crash log, similar (but different), in case this helps

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: stack trace from user in #firefox

A user (quix) reported this stack trace, which seems similar to the ones on this bug. This was with Firefox 2; he didn't know what the trigger was, but had been switching back to the app when it crashed.

Comment 8

[Adam Guthrie]

*** Bug 360047 has been marked as a duplicate of this bug. ***

Comment 10

[Chris Dolan]

Possibly related: bug 368907 which describes a nsMacEventHandler::HandleMouseMoveEvent crash on window close.

Comment 12

[Samuel Sidler (old account; do not CC)]

This is a pretty popular crash on Mac with over 100 crashes thus far for Fx 2.0.0.2. Most of the comments in talkback indicate it's happening either when closing a window (as bug 368907 mentions) or on quit, most usually when doing a restart of Firefox for an extension install or update. Looking through a good portion of the crashes in the query below, I didn't see any on 10.3, but that could just be a consequence of most people on 10.4 by now. It's pretty universal across all minor releases of 10.4, however.

Talkback query: http://tinyurl.com/yukrtp

Comment 13

[Mark Mentovai]

Fairly reliable testcase:

From a browser window, get the location bar autocomplete popup to show by starting to type something autocompletable (like "m") in the location bar.  With the popup displayed, begin moving the mouse cursor (within the window?).  With the popup displayed and the cursor moving, press command-W to close the window.

Comment 14

[Mark Mentovai]

widget/src/mac/nsMacEventHandler.cpp:
1640   WindowRef wind = reinterpret_cast<WindowRef>(mTopLevelWidget->GetNativeData(NS_NATIVE_DISPLAY));

Comment 15

[Mark Mentovai]

Caused by a conjunction of bug 344238 and bug 344570 (10.4-only after bug 345388).  A description is in the patch to follow.  The patch will fix this bug, and bug 368907.  I don't know about bug 376012.

Comment 16

[Mark Mentovai]

Attachment: Fix

Comment 17

[Mark Mentovai]

Comment on attachment 260243 [details] [diff] [review]
Fix

1.8.1-only, this is a Mac topcrasher.

Comment 18

[Daniel Veditz [:dveditz]]

Comment on attachment 260243 [details] [diff] [review]
Fix

approved for 1.8.1.4, a=dveditz for release-drivers

Comment 19

[Mark Mentovai]

Checked in on MOZILLA_1_8_BRANCH.