353766 - tab shoulders have a fixed height, which means the titles don't fit

Status: RESOLVED DUPLICATE of bug 350194

(Firefox :: Tabbed Browser, defect)

Description

[Daniel Brooks [:db48x]]

I'll attach a screenshot, but the upshot is that the titles appear to break out of the tabs. This is a result of not using the native theming that used to be used.

Comment 1

[Daniel Brooks [:db48x]]

Attachment: Screenshot-27.png

see also http://db48x.net/temp/Screenshot-21.png

Comment 2

[Asaf Romano (gone)]

If this is also an issue on the branch, this blocks bug 347454, not bug 353673.

Comment 3

[Mike Connor [:mconnor]]

Its also a result of not having time to test flexible height tabs, we have the images in place already, just not the testing on the modded CSS required to make them work.

This is not critical by any criteria and certainly not a blocker (previously discussed).  Short of bumping DPI to something pretty high, or going to extremely large fonts (i.e. beyond Extra Large Fonts on Windows) you can't reproduce this.

We were planning to fix on trunk.

Comment 4

[Daniel Brooks [:db48x]]

My monitor is only 100dpi, and the font size I use is only 14px. Neither of those seem very extreme. 

Isn't this exactly the sort of accessibility problem we've been trying to fix on the web? Didn't we introduce real font zooming in order to allow people with less than perfect eyesight to actually read the webpages they visit? Don't we all cringe when we see a site that completely breaks under font zoom? Why should we repeat the same mistakes others have made?

As far as I know this doesn't actually affect the functionality of the browser, but it does make it ugly. On the other hand, what other hidden inflexibilities lurk in the new theme? If I make my font size a little larger, will the text be cut off? Do we have the time to test all of those possibilities with the new theme?

Comment 5

[Alex R.]

This was supposed to be fixed by 349038.

Comment 6

[Ed Hume]

Not fixed as of 2006-09-28-1702 build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060928 BonEcho/2.0 - Build ID: 2006092816.

Comment 7

[Ed Hume]

Attachment: Screenshot showing tabs with bug.

Comment 8

[Michael Wu [:mwu]]

(In reply to comment #5)
> This was supposed to be fixed by 349038.
> 
Bug 349038 only reduces the severity of the problem so that most systems would not be affected. 

Comment 9

[(not reading, please use [e-mail] instead)]

is this a dup of bug #350194?

Comment 10

[Ed Hume]

We need to make the whiteboard "[Fx2 theme change]" so it shows up in the devs'
queries and they'll make sure to hammer it down for a subsequent release.