355893 - To and CC headers missing twisty when too many addresses for one line

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Nelson Bolyard (seldom reads bugmail)]

(Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060824 SeaMonkey/1.5a

Received a signed email message with an attachment.   The message was 
addressed To 2 recipiencents, and CC'd to quite a few more.

The message header pane showed only one receipient email address for "To:"
and did not show a twisty indicating that there were more To recipients
whose email addresses were unshown.  

100% reproducible. 

Will attach screen shots

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: screen shot shows missing To reipient, no twisty

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: screen shot, proper appearance

If I use "search messages" and search for this message, then in the 
search results window, I click the "Open Message Folder" button, I 
get this display.  But if I select another message in that window,
and then re-select this message again, it goes back to displaying 
as shown in the first attachment above.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

This also affects the CC: header on some messages

The real problem caused by this bug is that it gives me NO CLUE that 
there are other, additional, recipients whose addresses are not being 
shown.  So, I think I'm replying to a message that was just sent to me
and one other person, but when I bonk reply-all, I see that there were 
MANY other recipients of the message.

This has caused me real problems, and consequently I have learned to 
always double-check the list of recipients when doing  reply-all.
That should be unnecessary.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

I wrote: 
> The real problem caused by this bug is that it gives me NO CLUE that 
> there are other, additional, recipients whose addresses are not being 
> shown.

Sometimes, there is a TINY clue: a trailing comma character after the last
To or CC address shown.  This implies that more addresses follow, but 
without a twisty, the only way to see them is to view source. :(

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

This has beem broken on the trunk for a year now.
It's such basic, essential, fundamental functionality that I'm amazed
nothing has been done. 
Is this really just a SM-only problem? 
Or it is common to TB too?

Comment 6

[[e-mail]]

I can't reproduce this bug with To: addresses at all. I can, however, reproduce one version of this bug to do with CC: addresses. Steps to reproduce:
1. Read a message without any CC: addresses
2. Read a message with many CC: addresses
Note that with the following steps I do see a twisty:
1. Read a message with one CC: address
2. Read a message with many CC: addresses
The fix for this issue is to delete line 430 of mailWidgets.xml:
line 430 -- this.toggleIcon.collapsed = true;
Is this your issue, or does this change fix your issue?

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

> I can't reproduce this bug with To: addresses at all. 

I have a set of 3 messages. One is addressed To me only, no CCs. 
The other two are addressed To 11 different people (including me), no CCs.

If I read the mail addressed to me only, then read either of the two messages
with 11 addressees, I see the [+] twisty in front of the To line.  Then, if I read the other of the two messages with 11 addressees, I see no twisty.  
This problem occurs for me 100%.   I could attach copies of the 3 messages,
if that would help.

I will try your suggested patch to mailWidgets.xml next.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

> The fix for this issue is to delete line 430 of mailWidgets.xml:
> line 430 -- this.toggleIcon.collapsed = true;
> Is this your issue, or does this change fix your issue?

This seems to solve the issue for me ... 
However, I'm now experiencing bug 355662 (more than before?). 
I will have to back out the change I just made to see if it is affecting
bug 355662 in any way.

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

I reverted from my patched messenger.jar file (which contained the patch
described in comment6 and comment 8 above) to the original messenger.jar file.
Then the pair of messages with which I was seeing bug 355662 stopped having
that problem.  

So, it seems the one-line patch helps this problem, but exacerbates bug 355662.
:-(

Comment 10

[[e-mail]]

Attachment: Proposed patch

At least on trunk, the patch in bug 348395 is too eager in the case of a collapsed header which tracks its overflow state correctly. However if you expand the header then we stop tracking overflow so we should hide the twisty.

Comment 11

[Scott MacGregor]

Comment on attachment 285906 [details] [diff] [review]
Proposed patch

good fix Neil.

Comment 12

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 285906 [details] [diff] [review]
Proposed patch

This proposed patch seems to work for me, and doesn't seem to cause
twisties to be displayed where they should not be.

Comment 13

[[e-mail]]

Fix checked in.

Comment 15

[Serge Gautherie (:sgautherie)]

V.Fixed between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007102302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007102402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
on my test messages.

NB: In Classic theme, need to workaround bug 382642 to check this.

Comment 16

[Nelson Bolyard (seldom reads bugmail)]

Could this patch be causing horizontal scroll bars to be suppressed ?
I'm still running the same two week old code, except for this patch, 
but now I'm not seeing horizontal scroll bars in text edit boxes, when 
the text obviously exceeds the box width.  I wonder if this patch could 
have caused it.

Comment 17

[[e-mail]]

(In reply to comment #16)
>Could this patch be causing horizontal scroll bars to be suppressed ?
This patch only directly affects the main 3 pane and message windows,
neither of which contain text edit boxes with horizontal scrollbars.