355965 - Improve notification bar animation

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061003 Firefox/2.0.

When the pop up blocker UI comes up on the Mac, it comes up chunky - it is not a smooth animation. For some reason it bothers me quite a bit. I know that it should be shown a certain way so that it is noticed, but I just think there could be some improvement in the way it is shown.

Comment 1

[(not reading, please use [e-mail] instead)]

I'm noticing this more with firefox 3 than I did with firefox 2, and I think it is because "remember" password is now a notification.

I hit this a lot with bugzilla.

fwiw, when I hit "remember" in the remember password notification, the animation for closing the bar is smoother.

See also bug #386404.

Not a fx-3 blocker, but perhaps wanted-firefox-3, if there was a low risk fix for making this animation smoother on the mac?

Comment 3

[Dão Gottwald [:dao]]

Presumably, the problem with the "remember password" notification is that it's appearing and disappearing during pageload.

Comment 5

[Jesse Ruderman]

See also bug 422260, which asks for a pref to disable the animation.

Comment 6

[Dão Gottwald [:dao]]

Attachment: skip frames, don't use getComputedStyle all the time

Comment 9

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/index.cgi/rev/2dfb434673f4

Comment 10

[Samuel Sidler (old account; do not CC)]

Not sure if this is wanted or if it's just something we can pick up in 3.1...

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marcia, is it fixed for you on trunk?

Comment 12

[Dave Townsend [:mossop]]

Can anyone explain how this is supposed to skip frames or what the |off| parameter is meant to be for? It seems to me that it is never anything other than undefined making for some wasted code here.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
see http://ejohn.org/blog/timer-and-interval-offset/

Comment 14

[Samuel Sidler (old account; do not CC)]

Doesn't really meet the requirements of "wanted". We can just pick this up in Firefox 3.1.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marcia, can you verify that the patch fixes your issue?